[PATCH v2] Bluetooth: btqca: use le32_to_cpu for ver.soc_id

Min-Hua Chen posted 1 patch 2 years, 8 months ago
drivers/bluetooth/btqca.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH v2] Bluetooth: btqca: use le32_to_cpu for ver.soc_id
Posted by Min-Hua Chen 2 years, 8 months ago
Use le32_to_cpu for ver.soc_id to fix the following
sparse warning.

drivers/bluetooth/btqca.c:640:24: sparse: warning: restricted
__le32 degrades to integer

Signed-off-by: Min-Hua Chen <minhuadotchen@gmail.com>
---

Change since v1:
fix the line length > 80 error reported by bluez.test.bot

---
 drivers/bluetooth/btqca.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/bluetooth/btqca.c b/drivers/bluetooth/btqca.c
index fd0941fe8608..e7e58a956d15 100644
--- a/drivers/bluetooth/btqca.c
+++ b/drivers/bluetooth/btqca.c
@@ -637,7 +637,7 @@ int qca_uart_setup(struct hci_dev *hdev, uint8_t baudrate,
 		snprintf(config.fwname, sizeof(config.fwname),
 			 "qca/%s", firmware_name);
 	else if (qca_is_wcn399x(soc_type)) {
-		if (ver.soc_id == QCA_WCN3991_SOC_ID) {
+		if (le32_to_cpu(ver.soc_id) == QCA_WCN3991_SOC_ID) {
 			snprintf(config.fwname, sizeof(config.fwname),
 				 "qca/crnv%02xu.bin", rom_ver);
 		} else {
-- 
2.34.1
Re: [PATCH v2] Bluetooth: btqca: use le32_to_cpu for ver.soc_id
Posted by patchwork-bot+bluetooth@kernel.org 2 years, 8 months ago
Hello:

This patch was applied to bluetooth/bluetooth-next.git (master)
by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:

On Fri, 19 May 2023 18:43:23 +0800 you wrote:
> Use le32_to_cpu for ver.soc_id to fix the following
> sparse warning.
> 
> drivers/bluetooth/btqca.c:640:24: sparse: warning: restricted
> __le32 degrades to integer
> 
> Signed-off-by: Min-Hua Chen <minhuadotchen@gmail.com>
> 
> [...]

Here is the summary with links:
  - [v2] Bluetooth: btqca: use le32_to_cpu for ver.soc_id
    https://git.kernel.org/bluetooth/bluetooth-next/c/0f1e103dc579

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html