[PATCH v2] Staging: rts5208: rtsx: Moved else statement to same line with else if

Deepanshu Kartikey posted 1 patch 2 years, 8 months ago
There is a newer version of this series
drivers/staging/rts5208/rtsx.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
[PATCH v2] Staging: rts5208: rtsx: Moved else statement to same line with else if
Posted by Deepanshu Kartikey 2 years, 8 months ago
Moved else statement to same line with else if,
this warning was given by checkpatch.pl

Signed-off-by: Deepanshu Kartikey <kartikey406@gmail.com>

---
Changes in V2:
            - Moved else to the same line with else if
            - Moved comment on else statement to inside of it
---
 drivers/staging/rts5208/rtsx.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/rts5208/rtsx.c b/drivers/staging/rts5208/rtsx.c
index 2284a96abcff..47dacef0aaf8 100644
--- a/drivers/staging/rts5208/rtsx.c
+++ b/drivers/staging/rts5208/rtsx.c
@@ -399,10 +399,8 @@ static int rtsx_control_thread(void *__dev)
 				chip->srb->device->id,
 				(u8)chip->srb->device->lun);
 			chip->srb->result = DID_BAD_TARGET << 16;
-		}
-
-		/* we've got a command, let's do it! */
-		else {
+		} else {
+			/* we've got a command, let's do it! */
 			scsi_show_command(chip);
 			rtsx_invoke_transport(chip->srb, chip);
 		}
-- 
2.25.1
Re: [PATCH v2] Staging: rts5208: rtsx: Moved else statement to same line with else if
Posted by Greg KH 2 years, 8 months ago
On Fri, May 19, 2023 at 03:49:20PM +0530, Deepanshu Kartikey wrote:
> Moved else statement to same line with else if,
> this warning was given by checkpatch.pl
> 
> Signed-off-by: Deepanshu Kartikey <kartikey406@gmail.com>
> 
> ---
> Changes in V2:
>             - Moved else to the same line with else if
>             - Moved comment on else statement to inside of it

I have 2 v2 patches in my mailbox, which are different, so obviously one
of them is lying.  Please fix up and send a v4.

thanks,

greg k-h