drivers/staging/rts5208/rtsx.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)
Moved else statement to same line with else if,
this warning was given by checkpatch.pl
Signed-off-by: Deepanshu Kartikey <kartikey406@gmail.com>
...
Changes in V2:
- Moved else to the same line with else if
- Moved comment on else statement to inside of it
---
drivers/staging/rts5208/rtsx.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/rts5208/rtsx.c b/drivers/staging/rts5208/rtsx.c
index 2284a96abcff..47dacef0aaf8 100644
--- a/drivers/staging/rts5208/rtsx.c
+++ b/drivers/staging/rts5208/rtsx.c
@@ -399,10 +399,8 @@ static int rtsx_control_thread(void *__dev)
chip->srb->device->id,
(u8)chip->srb->device->lun);
chip->srb->result = DID_BAD_TARGET << 16;
- }
-
- /* we've got a command, let's do it! */
- else {
+ } else {
+ /* we've got a command, let's do it! */
scsi_show_command(chip);
rtsx_invoke_transport(chip->srb, chip);
}
--
2.25.1
On Fri, May 19, 2023 at 03:31:19PM +0530, Deepanshu Kartikey wrote: > Moved else statement to same line with else if, > this warning was given by checkpatch.pl > > Signed-off-by: Deepanshu Kartikey <kartikey406@gmail.com> > > ... > Changes in V2: > - Moved else to the same line with else if > - Moved comment on else statement to inside of it > --- > drivers/staging/rts5208/rtsx.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) Please read my blog about how to resend a patch. https://staticthinking.wordpress.com/2022/07/27/how-to-send-a-v2-patch/ regards, dan carpenter
On Fri, May 19, 2023 at 03:31:19PM +0530, Deepanshu Kartikey wrote: > Moved else statement to same line with else if, > this warning was given by checkpatch.pl > > Signed-off-by: Deepanshu Kartikey <kartikey406@gmail.com> > > ... > Changes in V2: > - Moved else to the same line with else if > - Moved comment on else statement to inside of it This needs to go below: > --- That line, so that these comments do not end up in the changelog. thanks, greg k-h
© 2016 - 2026 Red Hat, Inc.