[PATCH v4 1/4] dt-bindings: power: Add power-domain header for JH7110

Changhuang Liang posted 4 patches 2 years, 7 months ago
[PATCH v4 1/4] dt-bindings: power: Add power-domain header for JH7110
Posted by Changhuang Liang 2 years, 7 months ago
Add power-domain header for JH7110 SoC, it can use to operate dphy
power.

Signed-off-by: Changhuang Liang <changhuang.liang@starfivetech.com>
---
 include/dt-bindings/power/starfive,jh7110-pmu.h | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/include/dt-bindings/power/starfive,jh7110-pmu.h b/include/dt-bindings/power/starfive,jh7110-pmu.h
index 132bfe401fc8..341e2a0676ba 100644
--- a/include/dt-bindings/power/starfive,jh7110-pmu.h
+++ b/include/dt-bindings/power/starfive,jh7110-pmu.h
@@ -1,6 +1,6 @@
 /* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */
 /*
- * Copyright (C) 2022 StarFive Technology Co., Ltd.
+ * Copyright (C) 2022-2023 StarFive Technology Co., Ltd.
  * Author: Walker Chen <walker.chen@starfivetech.com>
  */
 #ifndef __DT_BINDINGS_POWER_JH7110_POWER_H__
@@ -14,4 +14,7 @@
 #define JH7110_PD_ISP		5
 #define JH7110_PD_VENC		6
 
+#define JH7110_PD_DPHY_TX	0
+#define JH7110_PD_DPHY_RX	1
+
 #endif
-- 
2.25.1
Re: [PATCH v4 1/4] dt-bindings: power: Add power-domain header for JH7110
Posted by Conor Dooley 2 years, 7 months ago
On Thu, May 18, 2023 at 11:01:59PM -0700, Changhuang Liang wrote:
> Add power-domain header for JH7110 SoC, it can use to operate dphy
> power.

That is not an accurate description of what you are doing here!
**IF** you resubmit for another reason, please change that wording
to match what you are doing here. Otherwise, I will fix it up on
application.

Thanks,
Conor
Re: [PATCH v4 1/4] dt-bindings: power: Add power-domain header for JH7110
Posted by Changhuang Liang 2 years, 7 months ago

On 2023/5/20 2:42, Conor Dooley wrote:
> On Thu, May 18, 2023 at 11:01:59PM -0700, Changhuang Liang wrote:
>> Add power-domain header for JH7110 SoC, it can use to operate dphy
>> power.
> 
> That is not an accurate description of what you are doing here!
> **IF** you resubmit for another reason, please change that wording
> to match what you are doing here. Otherwise, I will fix it up on
> application.
> 

OK, thanks for your comment