[v1] hwmon: (nct6683) Add another customer ID for NCT6687D sensor chip on some MSI boards.

[PATCH] hwmon: (nct6683) Add another customer ID for NCT6687D sensor chip on some MSI boards.

Posted by Gopal Prasad 2 years, 7 months ago

From: llyyr <llyyr.public@gmail.com>

This value was found on a MSI Z690-A PRO DDR5 with NCT6687D.

Signed-off-by: Gopal Prasad <llyyr.public@gmail.com>
---
 drivers/hwmon/nct6683.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/hwmon/nct6683.c b/drivers/hwmon/nct6683.c
index a872f783e..f673f7d07 100644
--- a/drivers/hwmon/nct6683.c
+++ b/drivers/hwmon/nct6683.c
@@ -173,6 +173,7 @@ superio_exit(int ioreg)
 #define NCT6683_CUSTOMER_ID_INTEL	0x805
 #define NCT6683_CUSTOMER_ID_MITAC	0xa0e
 #define NCT6683_CUSTOMER_ID_MSI		0x201
+#define NCT6683_CUSTOMER_ID_MSI2	0x200
 #define NCT6683_CUSTOMER_ID_ASROCK		0xe2c
 #define NCT6683_CUSTOMER_ID_ASROCK2	0xe1b
 
@@ -1220,6 +1221,8 @@ static int nct6683_probe(struct platform_device *pdev)
 		break;
 	case NCT6683_CUSTOMER_ID_MSI:
 		break;
+	case NCT6683_CUSTOMER_ID_MSI2:
+		break;
 	case NCT6683_CUSTOMER_ID_ASROCK:
 		break;
 	case NCT6683_CUSTOMER_ID_ASROCK2:
-- 
2.40.1

Re: [PATCH] hwmon: (nct6683) Add another customer ID for NCT6687D sensor chip on some MSI boards.

Posted by Guenter Roeck 2 years, 7 months ago

On Wed, May 17, 2023 at 09:50:25AM +0530, Gopal Prasad wrote:
> From: llyyr <llyyr.public@gmail.com>
> 

The above is still wrong. Never mind, I fixed that.

> This value was found on a MSI Z690-A PRO DDR5 with NCT6687D.
> 
> Signed-off-by: Gopal Prasad <llyyr.public@gmail.com>

Applied. In the future, please version your patches and provide
change logs.

Thanks,
Guenter

Re: [PATCH] hwmon: (nct6683) Add another customer ID for NCT6687D sensor chip on some MSI boards.

Posted by llyyr 2 years, 7 months ago

On 5/19/23 18:23, Guenter Roeck wrote:
> On Wed, May 17, 2023 at 09:50:25AM +0530, Gopal Prasad wrote:
>> From: llyyr <llyyr.public@gmail.com>
>>
> 
> The above is still wrong. Never mind, I fixed that.

I wasn't sure about it, but I checked and I'm pretty sure pseudonyms are 
allowed [1]. Is the problem here that my online handle not have a first 
name and a last name part?

* 
https://www.kernel.org/doc/html/v6.3/process/submitting-patches.html#developer-s-certificate-of-origin-1-1

Re: [PATCH] hwmon: (nct6683) Add another customer ID for NCT6687D sensor chip on some MSI boards.

Posted by Guenter Roeck 2 years, 7 months ago

On Fri, May 19, 2023 at 07:16:53PM +0530, llyyr wrote:
> On 5/19/23 18:23, Guenter Roeck wrote:
> > On Wed, May 17, 2023 at 09:50:25AM +0530, Gopal Prasad wrote:
> > > From: llyyr <llyyr.public@gmail.com>
> > > 
> > 
> > The above is still wrong. Never mind, I fixed that.
> 
> I wasn't sure about it, but I checked and I'm pretty sure pseudonyms are
> allowed [1]. Is the problem here that my online handle not have a first name
> and a last name part?
> 
> * https://www.kernel.org/doc/html/v6.3/process/submitting-patches.html#developer-s-certificate-of-origin-1-1
> 

"... using a known identity (sorry, no anonymous contributions.) "
                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Are you making that up ?

Guenter

Re: [PATCH] hwmon: (nct6683) Add another customer ID for NCT6687D sensor chip on some MSI boards.

Posted by llyyr 2 years, 7 months ago

On 5/19/23 19:21, Guenter Roeck wrote:
> On Fri, May 19, 2023 at 07:16:53PM +0530, llyyr wrote:
>> On 5/19/23 18:23, Guenter Roeck wrote:
>>> On Wed, May 17, 2023 at 09:50:25AM +0530, Gopal Prasad wrote:
>>>> From: llyyr <llyyr.public@gmail.com>
>>>>
>>>
>>> The above is still wrong. Never mind, I fixed that.
>>
>> I wasn't sure about it, but I checked and I'm pretty sure pseudonyms are
>> allowed [1]. Is the problem here that my online handle not have a first name
>> and a last name part?
>>
>> * https://www.kernel.org/doc/html/v6.3/process/submitting-patches.html#developer-s-certificate-of-origin-1-1
>>
> 
> "... using a known identity (sorry, no anonymous contributions.)"
>                               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> 
> Are you making that up ?
> 
> Guenter

Please see commit d4563201f33a022fc0353033d9dfeb1606a88330 [1] and DCO 
Guidelines [2]

 > And despite the language, we've always accepted nicknames and
that language was never meant to be any kind of exclusionary wording.


 > A real name does not require a legal name, nor a birth name, nor any 
name that appears on an official ID (e.g. a passport). Your real name is 
the name you convey to people in the community for them to use to 
identify you as you. The key concern is that your identification is 
sufficient enough to contact you if an issue were to arise in the future 
about your contribution.

* 
https://github.com/torvalds/linux/commit/d4563201f33a022fc0353033d9dfeb1606a88330
* https://github.com/cncf/foundation/blob/main/dco-guidelines.md

Re: [PATCH] hwmon: (nct6683) Add another customer ID for NCT6687D sensor chip on some MSI boards.

Posted by llyyr 2 years, 7 months ago

On 5/19/23 19:21, Guenter Roeck wrote:
> On Fri, May 19, 2023 at 07:16:53PM +0530, llyyr wrote:
>> On 5/19/23 18:23, Guenter Roeck wrote:
>>> On Wed, May 17, 2023 at 09:50:25AM +0530, Gopal Prasad wrote:
>>>> From: llyyr <llyyr.public@gmail.com>
>>>>
>>>
>>> The above is still wrong. Never mind, I fixed that.
>>
>> I wasn't sure about it, but I checked and I'm pretty sure pseudonyms are
>> allowed [1]. Is the problem here that my online handle not have a first name
>> and a last name part?
>>
>> * https://www.kernel.org/doc/html/v6.3/process/submitting-patches.html#developer-s-certificate-of-origin-1-1
>>
> 
> "... using a known identity (sorry, no anonymous contributions.)"
>                               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> 
> Are you making that up ?
> 
> Guenter

An online handle is not an anonymous contribution. Pseudonyms were 
explicitly mentioned in a previous version but removed later [1].

Besides, there are plenty of linux contributors commiting under 
pseudonyms like Asahi Lina.

* 
https://www.kernel.org/doc/html/v4.17/process/submitting-patches.html#developer-s-certificate-of-origin-1-1