arm64: dts: qcom: sa8775p: mark the UFS controller as dma-coherent

[PATCH] arm64: dts: qcom: sa8775p: mark the UFS controller as dma-coherent

Posted by Bartosz Golaszewski 2 years, 8 months ago

From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>

The UFS is cache coherent, so mark it as such in the dtsi.

Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
---
 arch/arm64/boot/dts/qcom/sa8775p.dtsi | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm64/boot/dts/qcom/sa8775p.dtsi b/arch/arm64/boot/dts/qcom/sa8775p.dtsi
index c5e2e3256bc4..c0717dac100c 100644
--- a/arch/arm64/boot/dts/qcom/sa8775p.dtsi
+++ b/arch/arm64/boot/dts/qcom/sa8775p.dtsi
@@ -605,6 +605,7 @@ ufs_mem_hc: ufs@1d84000 {
 			power-domains = <&gcc UFS_PHY_GDSC>;
 			required-opps = <&rpmhpd_opp_nom>;
 			iommus = <&apps_smmu 0x100 0x0>;
+			dma-coherent;
 			clocks = <&gcc GCC_UFS_PHY_AXI_CLK>,
 				 <&gcc GCC_AGGRE_UFS_PHY_AXI_CLK>,
 				 <&gcc GCC_UFS_PHY_AHB_CLK>,
-- 
2.39.2

Re: [PATCH] arm64: dts: qcom: sa8775p: mark the UFS controller as dma-coherent

Posted by Bjorn Andersson 2 years, 8 months ago

On Mon, 15 May 2023 14:19:08 +0200, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> 
> The UFS is cache coherent, so mark it as such in the dtsi.
> 
> 

Applied, thanks!

[1/1] arm64: dts: qcom: sa8775p: mark the UFS controller as dma-coherent
      commit: 2b967894f80aac2c7421eb545c32ed995f8d9877

Best regards,
-- 
Bjorn Andersson <andersson@kernel.org>

Re: [PATCH] arm64: dts: qcom: sa8775p: mark the UFS controller as dma-coherent

Posted by Manivannan Sadhasivam 2 years, 8 months ago

On Mon, May 15, 2023 at 02:19:08PM +0200, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> 
> The UFS is cache coherent, so mark it as such in the dtsi.

UFS controller

> 
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>

Suggested-by: Manivannan Sadhasivam <mani@kernel.org>
Reviewed-by: Manivannan Sadhasivam <mani@kernel.org>

- Mani

> ---
>  arch/arm64/boot/dts/qcom/sa8775p.dtsi | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sa8775p.dtsi b/arch/arm64/boot/dts/qcom/sa8775p.dtsi
> index c5e2e3256bc4..c0717dac100c 100644
> --- a/arch/arm64/boot/dts/qcom/sa8775p.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sa8775p.dtsi
> @@ -605,6 +605,7 @@ ufs_mem_hc: ufs@1d84000 {
>  			power-domains = <&gcc UFS_PHY_GDSC>;
>  			required-opps = <&rpmhpd_opp_nom>;
>  			iommus = <&apps_smmu 0x100 0x0>;
> +			dma-coherent;
>  			clocks = <&gcc GCC_UFS_PHY_AXI_CLK>,
>  				 <&gcc GCC_AGGRE_UFS_PHY_AXI_CLK>,
>  				 <&gcc GCC_UFS_PHY_AHB_CLK>,
> -- 
> 2.39.2
> 

-- 
மணிவண்ணன் சதாசிவம்