pinctrl: meson-axg: add missing GPIOA_18 gpio group

[PATCH RESEND] pinctrl: meson-axg: add missing GPIOA_18 gpio group

Posted by Martin Hundebøll 2 years, 9 months ago

Without this, the gpio cannot be explicitly mux'ed to its gpio function.

Fixes: 83c566806a68a ("pinctrl: meson-axg: Add new pinctrl driver for Meson AXG SoC")
Cc: stable@vger.kernel.org
Signed-off-by: Martin Hundebøll <martin@geanix.com>
---
Changes since first mail:
 * Added Cc: stable to commit message
 * Expanded To: and Cc: with full list from get_maintainers.pl

 drivers/pinctrl/meson/pinctrl-meson-axg.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/pinctrl/meson/pinctrl-meson-axg.c b/drivers/pinctrl/meson/pinctrl-meson-axg.c
index 7bfecdfba177..d249a035c2b9 100644
--- a/drivers/pinctrl/meson/pinctrl-meson-axg.c
+++ b/drivers/pinctrl/meson/pinctrl-meson-axg.c
@@ -400,6 +400,7 @@ static struct meson_pmx_group meson_axg_periphs_groups[] = {
 	GPIO_GROUP(GPIOA_15),
 	GPIO_GROUP(GPIOA_16),
 	GPIO_GROUP(GPIOA_17),
+	GPIO_GROUP(GPIOA_18),
 	GPIO_GROUP(GPIOA_19),
 	GPIO_GROUP(GPIOA_20),
 
-- 
2.34.1

Re: [PATCH RESEND] pinctrl: meson-axg: add missing GPIOA_18 gpio group

Posted by Linus Walleij 2 years, 8 months ago

On Fri, May 12, 2023 at 8:49 AM Martin Hundebøll <martin@geanix.com> wrote:

> Without this, the gpio cannot be explicitly mux'ed to its gpio function.
>
> Fixes: 83c566806a68a ("pinctrl: meson-axg: Add new pinctrl driver for Meson AXG SoC")
> Cc: stable@vger.kernel.org
> Signed-off-by: Martin Hundebøll <martin@geanix.com>

Patch applied for fixes.

Yours,
Linus Walleij

Re: [PATCH RESEND] pinctrl: meson-axg: add missing GPIOA_18 gpio group

Posted by Neil Armstrong 2 years, 9 months ago

On 12/05/2023 08:49, Martin Hundebøll wrote:
> Without this, the gpio cannot be explicitly mux'ed to its gpio function.
> 
> Fixes: 83c566806a68a ("pinctrl: meson-axg: Add new pinctrl driver for Meson AXG SoC")
> Cc: stable@vger.kernel.org
> Signed-off-by: Martin Hundebøll <martin@geanix.com>
> ---
> Changes since first mail:
>   * Added Cc: stable to commit message
>   * Expanded To: and Cc: with full list from get_maintainers.pl
> 
>   drivers/pinctrl/meson/pinctrl-meson-axg.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/pinctrl/meson/pinctrl-meson-axg.c b/drivers/pinctrl/meson/pinctrl-meson-axg.c
> index 7bfecdfba177..d249a035c2b9 100644
> --- a/drivers/pinctrl/meson/pinctrl-meson-axg.c
> +++ b/drivers/pinctrl/meson/pinctrl-meson-axg.c
> @@ -400,6 +400,7 @@ static struct meson_pmx_group meson_axg_periphs_groups[] = {
>   	GPIO_GROUP(GPIOA_15),
>   	GPIO_GROUP(GPIOA_16),
>   	GPIO_GROUP(GPIOA_17),
> +	GPIO_GROUP(GPIOA_18),
>   	GPIO_GROUP(GPIOA_19),
>   	GPIO_GROUP(GPIOA_20),
>   

Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>

Re: [PATCH RESEND] pinctrl: meson-axg: add missing GPIOA_18 gpio group

Posted by Dmitry Rokosov 2 years, 9 months ago

On Fri, May 12, 2023 at 08:49:25AM +0200, Martin Hundebøll wrote:
> Without this, the gpio cannot be explicitly mux'ed to its gpio function.
> 
> Fixes: 83c566806a68a ("pinctrl: meson-axg: Add new pinctrl driver for Meson AXG SoC")
> Cc: stable@vger.kernel.org
> Signed-off-by: Martin Hundebøll <martin@geanix.com>

Reviewed-by: Dmitry Rokosov <ddrokosov@sberdevices.ru>

> ---
> Changes since first mail:
>  * Added Cc: stable to commit message
>  * Expanded To: and Cc: with full list from get_maintainers.pl
> 
>  drivers/pinctrl/meson/pinctrl-meson-axg.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/pinctrl/meson/pinctrl-meson-axg.c b/drivers/pinctrl/meson/pinctrl-meson-axg.c
> index 7bfecdfba177..d249a035c2b9 100644
> --- a/drivers/pinctrl/meson/pinctrl-meson-axg.c
> +++ b/drivers/pinctrl/meson/pinctrl-meson-axg.c
> @@ -400,6 +400,7 @@ static struct meson_pmx_group meson_axg_periphs_groups[] = {
>  	GPIO_GROUP(GPIOA_15),
>  	GPIO_GROUP(GPIOA_16),
>  	GPIO_GROUP(GPIOA_17),
> +	GPIO_GROUP(GPIOA_18),
>  	GPIO_GROUP(GPIOA_19),
>  	GPIO_GROUP(GPIOA_20),
>  
> -- 
> 2.34.1
> 
> 
> _______________________________________________
> linux-amlogic mailing list
> linux-amlogic@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-amlogic

-- 
Thank you,
Dmitry