[PATCH blktests v4 04/11] common/xfs: Limit fio size job to fit into xfs fs

Daniel Wagner posted 11 patches 2 years, 7 months ago
[PATCH blktests v4 04/11] common/xfs: Limit fio size job to fit into xfs fs
Posted by Daniel Wagner 2 years, 7 months ago
The usable capacity of the filesystem is less than the raw
partition/device size due to the additional meta/log data.

Ensure that the job size for fio is not exceeding the limits.

Because we have hard coded the path where we mount the filesystem
and don't want to expose this, we just update max size inside
_xfs_run_fio_verify_io(). No need to leak this into the caller.

Signed-off-by: Daniel Wagner <dwagner@suse.de>
---
 common/xfs | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/common/xfs b/common/xfs
index 413c2820ffaf..37ce85878df2 100644
--- a/common/xfs
+++ b/common/xfs
@@ -37,6 +37,9 @@ _xfs_run_fio_verify_io() {
 		sz_mb="${avail_mb}"
 	else
 		sz_mb="$(convert_to_mb "${sz}")"
+		if [[ "${sz_mb}" -gt "${avail_mb}" ]]; then
+			sz_mb="${avail_mb}"
+		fi
 	fi
 
 	_run_fio_verify_io --size="${sz_mb}m" --directory="${mount_dir}/"
-- 
2.40.0
Re: [PATCH blktests v4 04/11] common/xfs: Limit fio size job to fit into xfs fs
Posted by Chaitanya Kulkarni 2 years, 7 months ago
On 5/11/23 07:09, Daniel Wagner wrote:
> The usable capacity of the filesystem is less than the raw
> partition/device size due to the additional meta/log data.
>
> Ensure that the job size for fio is not exceeding the limits.
>
> Because we have hard coded the path where we mount the filesystem
> and don't want to expose this, we just update max size inside
> _xfs_run_fio_verify_io(). No need to leak this into the caller.
>
> Signed-off-by: Daniel Wagner <dwagner@suse.de>
> ---
>   

make sense for the xfs fio verify, looks good.

Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>

-ck