[PATCH] add braces to rt_type == RTN_BROADCAST case

Taichi Nishimura posted 1 patch 2 years, 9 months ago
net/ipv4/ip_output.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
[PATCH] add braces to rt_type == RTN_BROADCAST case
Posted by Taichi Nishimura 2 years, 9 months ago
Add braces to rt->rt_type == RTN_BROADCAST to make it easier
to grasp the if-else-if statement.
I think that it is ok to remove braces of rt_type == RTN_MULTICAST
because IP_UPD_PO_STATS is oneliner.

Signed-off-by: Taichi Nishimura <awkrail01@gmail.com>
---
 net/ipv4/ip_output.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/net/ipv4/ip_output.c b/net/ipv4/ip_output.c
index 61892268e8a6..8b761e1a9e24 100644
--- a/net/ipv4/ip_output.c
+++ b/net/ipv4/ip_output.c
@@ -203,8 +203,9 @@ static int ip_finish_output2(struct net *net, struct sock *sk, struct sk_buff *s
 
 	if (rt->rt_type == RTN_MULTICAST) {
 		IP_UPD_PO_STATS(net, IPSTATS_MIB_OUTMCAST, skb->len);
-	} else if (rt->rt_type == RTN_BROADCAST)
+	} else if (rt->rt_type == RTN_BROADCAST) {
 		IP_UPD_PO_STATS(net, IPSTATS_MIB_OUTBCAST, skb->len);
+	}
 
 	if (unlikely(skb_headroom(skb) < hh_len && dev->header_ops)) {
 		skb = skb_expand_head(skb, hh_len);
-- 
2.39.2
Re: [PATCH] add braces to rt_type == RTN_BROADCAST case
Posted by Jakub Kicinski 2 years, 9 months ago
On Tue,  9 May 2023 10:36:01 +0900 Taichi Nishimura wrote:
> Add braces to rt->rt_type == RTN_BROADCAST to make it easier
> to grasp the if-else-if statement.
> I think that it is ok to remove braces of rt_type == RTN_MULTICAST
> because IP_UPD_PO_STATS is oneliner.

I'm sorry but unfortunately we don't take pure coding style changes
(AKA checkpatch changes) in networking because they make backports
harder for little gain.
-- 
pw-bot: reject