[v1] Add R5F and C7x DSP nodes for AM62a SoC

[PATCH 0/2] Add R5F and C7x DSP nodes for AM62a SoC

Posted by Hari Nagalla 2 years, 7 months ago

This series adds the R5F processor nodes and C7x DSP node for
AM62a SoC.

The first patch adds the nodes to the SoC device tree and the second
patch reserves the memory for remote rpoc IPCs on AM62a-SK.

Hari Nagalla (2):
  arm64: dts: ti: k3-am62a: Add remote proc nodes
  arm64: dts: ti: k3-am62a7-sk: Enable remote proc nodes

 arch/arm64/boot/dts/ti/k3-am62a-main.dtsi   | 11 ++++
 arch/arm64/boot/dts/ti/k3-am62a-mcu.dtsi    | 23 +++++++
 arch/arm64/boot/dts/ti/k3-am62a-wakeup.dtsi | 23 +++++++
 arch/arm64/boot/dts/ti/k3-am62a7-sk.dts     | 69 +++++++++++++++++++++
 4 files changed, 126 insertions(+)

-- 
2.34.1

Re: [PATCH 0/2] Add R5F and C7x DSP nodes for AM62a SoC

Posted by Vignesh Raghavendra 2 years, 6 months ago


On 02/05/23 19:44, Hari Nagalla wrote:
> This series adds the R5F processor nodes and C7x DSP node for
> AM62a SoC.
> 
> The first patch adds the nodes to the SoC device tree and the second
> patch reserves the memory for remote rpoc IPCs on AM62a-SK.
> 
> Hari Nagalla (2):
>   arm64: dts: ti: k3-am62a: Add remote proc nodes
>   arm64: dts: ti: k3-am62a7-sk: Enable remote proc nodes
> 
>  arch/arm64/boot/dts/ti/k3-am62a-main.dtsi   | 11 ++++
>  arch/arm64/boot/dts/ti/k3-am62a-mcu.dtsi    | 23 +++++++
>  arch/arm64/boot/dts/ti/k3-am62a-wakeup.dtsi | 23 +++++++
>  arch/arm64/boot/dts/ti/k3-am62a7-sk.dts     | 69 +++++++++++++++++++++
>  4 files changed, 126 insertions(+)
> 

Please fix dtbs_check issues:

+arch/arm64/boot/dts/ti/k3-am62a7-sk.dts: /bus@f0000/mailbox@29020000/mbox-mcu_r5-0: Character '_' not recommended in node name
+/workdir/arch/arm64/boot/dts/ti/k3-am62a7-sk.dtb: dsp@7e000000: reg: [[0, 2113929216, 0, 1048576]] is too short
+/workdir/arch/arm64/boot/dts/ti/k3-am62a7-sk.dtb: dsp@7e000000: reg-names: ['l2sram'] is too short
+/workdir/arch/arm64/boot/dts/ti/k3-am62a7-sk.dtb: dsp@7e000000: Unevaluated properties are not allowed ('reg', 'reg-names' were unexpected)
+arch/arm64/boot/dts/ti/k3-am62a7-sk.dts: /bus@f0000/mailbox@29020000/mbox-mcu_r5-0: Character '_' not recommended in node name
+/workdir/arch/arm64/boot/dts/ti/k3-am62a7-sk.dtb: mailbox@29020000: 'mbox-mcu_r5-0' does not match any of the regexes: '^mbox-[a-z0-9-]+$', 'pinctrl-[0-9]+'


-- 
Regards
Vignesh

Re: [PATCH 0/2] Add R5F and C7x DSP nodes for AM62a SoC

Posted by Devarsh Thakkar 2 years, 7 months ago

Hi Hari,

Thanks for the series.

On 02/05/23 19:44, Hari Nagalla wrote:
> This series adds the R5F processor nodes and C7x DSP node for
> AM62a SoC.
> 
> The first patch adds the nodes to the SoC device tree and the second
> patch reserves the memory for remote rpoc IPCs on AM62a-SK.
> 
> Hari Nagalla (2):
>    arm64: dts: ti: k3-am62a: Add remote proc nodes
>    arm64: dts: ti: k3-am62a7-sk: Enable remote proc nodes
> 

I think good to preserve the authorship if porting from an existing 
tree. Also in my opinion good to keep split patches if coming from 
different authors and to different files.

Regards
Devarsh

>   arch/arm64/boot/dts/ti/k3-am62a-main.dtsi   | 11 ++++
>   arch/arm64/boot/dts/ti/k3-am62a-mcu.dtsi    | 23 +++++++
>   arch/arm64/boot/dts/ti/k3-am62a-wakeup.dtsi | 23 +++++++
>   arch/arm64/boot/dts/ti/k3-am62a7-sk.dts     | 69 +++++++++++++++++++++
>   4 files changed, 126 insertions(+)
>