reset: starfive: select AUXILIARY_BUS

[PATCH] reset: starfive: select AUXILIARY_BUS

Posted by Philipp Zabel 2 years, 9 months ago

CONFIG_AUXILIARY_BUS is not a user-visible symbol, replace 'depends on'
with 'select'.

Cc: Emil Renner Berthing <kernel@esmil.dk>
Cc: Hal Feng <hal.feng@starfivetech.com>
Suggested-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
 drivers/reset/starfive/Kconfig | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/reset/starfive/Kconfig b/drivers/reset/starfive/Kconfig
index 1fa706a2c3dc..d832339f61bc 100644
--- a/drivers/reset/starfive/Kconfig
+++ b/drivers/reset/starfive/Kconfig
@@ -13,7 +13,8 @@ config RESET_STARFIVE_JH7100
 
 config RESET_STARFIVE_JH7110
 	bool "StarFive JH7110 Reset Driver"
-	depends on AUXILIARY_BUS && CLK_STARFIVE_JH7110_SYS
+	depends on CLK_STARFIVE_JH7110_SYS
+	select AUXILIARY_BUS
 	select RESET_STARFIVE_JH71X0
 	default ARCH_STARFIVE
 	help
-- 
2.39.2

Re: [PATCH] reset: starfive: select AUXILIARY_BUS

Posted by Hal Feng 2 years, 9 months ago

On Tue, 2 May 2023 12:20:50 +0200, Philipp Zabel wrote:
> CONFIG_AUXILIARY_BUS is not a user-visible symbol, replace 'depends on'
> with 'select'.
> 
> Cc: Emil Renner Berthing <kernel@esmil.dk>
> Cc: Hal Feng <hal.feng@starfivetech.com>
> Suggested-by: Arnd Bergmann <arnd@arndb.de>
> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>

Reviewed-by: Hal Feng <hal.feng@starfivetech.com>

> ---
>  drivers/reset/starfive/Kconfig | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/reset/starfive/Kconfig b/drivers/reset/starfive/Kconfig
> index 1fa706a2c3dc..d832339f61bc 100644
> --- a/drivers/reset/starfive/Kconfig
> +++ b/drivers/reset/starfive/Kconfig
> @@ -13,7 +13,8 @@ config RESET_STARFIVE_JH7100
>  
>  config RESET_STARFIVE_JH7110
>  	bool "StarFive JH7110 Reset Driver"
> -	depends on AUXILIARY_BUS && CLK_STARFIVE_JH7110_SYS
> +	depends on CLK_STARFIVE_JH7110_SYS
> +	select AUXILIARY_BUS
>  	select RESET_STARFIVE_JH71X0
>  	default ARCH_STARFIVE
>  	help

Re: [PATCH] reset: starfive: select AUXILIARY_BUS

Posted by Arnd Bergmann 2 years, 9 months ago

On Tue, May 2, 2023, at 12:20, Philipp Zabel wrote:
> CONFIG_AUXILIARY_BUS is not a user-visible symbol, replace 'depends on'
> with 'select'.
>
> Cc: Emil Renner Berthing <kernel@esmil.dk>
> Cc: Hal Feng <hal.feng@starfivetech.com>
> Suggested-by: Arnd Bergmann <arnd@arndb.de>
> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>

Reviewed-by: Arnd Bergmann <arnd@arndb.de>

Re: [PATCH] reset: starfive: select AUXILIARY_BUS

Posted by Emil Renner Berthing 2 years, 9 months ago

On Tue, 2 May 2023 at 12:20, Philipp Zabel <p.zabel@pengutronix.de> wrote:
>
> CONFIG_AUXILIARY_BUS is not a user-visible symbol, replace 'depends on'
> with 'select'.
>
> Cc: Emil Renner Berthing <kernel@esmil.dk>
> Cc: Hal Feng <hal.feng@starfivetech.com>
> Suggested-by: Arnd Bergmann <arnd@arndb.de>
> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>

Makes sense to me. Thanks!
Reviewed-by: <emil.renner.berthing@canonical.com>

> ---
>  drivers/reset/starfive/Kconfig | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/reset/starfive/Kconfig b/drivers/reset/starfive/Kconfig
> index 1fa706a2c3dc..d832339f61bc 100644
> --- a/drivers/reset/starfive/Kconfig
> +++ b/drivers/reset/starfive/Kconfig
> @@ -13,7 +13,8 @@ config RESET_STARFIVE_JH7100
>
>  config RESET_STARFIVE_JH7110
>         bool "StarFive JH7110 Reset Driver"
> -       depends on AUXILIARY_BUS && CLK_STARFIVE_JH7110_SYS
> +       depends on CLK_STARFIVE_JH7110_SYS
> +       select AUXILIARY_BUS
>         select RESET_STARFIVE_JH71X0
>         default ARCH_STARFIVE
>         help
> --
> 2.39.2
>