[v1] pinctrl:sprd: Check if the pinctrl_dev still exists

[PATCH] pinctrl:sprd: Check if the pinctrl_dev still exists

Lizhe posted 1 patch 2 years, 9 months ago

Diff against v1
Download mbox

drivers/pinctrl/sprd/pinctrl-sprd.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)

Expand all Fold all

[PATCH] pinctrl:sprd: Check if the pinctrl_dev still exists

Posted by Lizhe 2 years, 9 months ago

to check if the pinctrl_dev still exists before calling
pinctrl_unregister().

Signed-off-by: Lizhe <sensor1010@163.com>
---
 drivers/pinctrl/sprd/pinctrl-sprd.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/pinctrl/sprd/pinctrl-sprd.c b/drivers/pinctrl/sprd/pinctrl-sprd.c
index ca9659f4e4b1..52089e34435c 100644
--- a/drivers/pinctrl/sprd/pinctrl-sprd.c
+++ b/drivers/pinctrl/sprd/pinctrl-sprd.c
@@ -1114,8 +1114,10 @@ EXPORT_SYMBOL_GPL(sprd_pinctrl_core_probe);
 int sprd_pinctrl_remove(struct platform_device *pdev)
 {
 	struct sprd_pinctrl *sprd_pctl = platform_get_drvdata(pdev);
+	
+	if (sprd_pctl->pctl)
+		pinctrl_unregister(sprd_pctl->pctl);
 
-	pinctrl_unregister(sprd_pctl->pctl);
 	return 0;
 }
 EXPORT_SYMBOL_GPL(sprd_pinctrl_remove);
-- 
2.34.1

Re: [PATCH] pinctrl:sprd: Check if the pinctrl_dev still exists

Posted by andy.shevchenko@gmail.com 2 years, 9 months ago

Sun, Apr 30, 2023 at 10:01:29PM +0800, Lizhe kirjoitti:
> to check if the pinctrl_dev still exists before calling
> pinctrl_unregister().

Sending a duplicate won't give anything new here, the patch itself is bogus.

-- 
With Best Regards,
Andy Shevchenko