[v2] perf tools: Allow config terms with breakpoints

[PATCH V2 0/1] perf tools: Allow config terms with breakpoints

Adrian Hunter posted 1 patch 2 years, 9 months ago

Diff against v1 v3
Download series mbox

There is a newer version of this series

tools/perf/tests/parse-events.c | 157 ++++++++++++++++++++++++++++++++++++++++
tools/perf/util/parse-events.c  |  23 +++++-
tools/perf/util/parse-events.h  |   6 +-
tools/perf/util/parse-events.l  |  23 +++++-
tools/perf/util/parse-events.y  |  42 ++++++-----
5 files changed, 224 insertions(+), 27 deletions(-)

Expand all Fold all

[PATCH V2 0/1] perf tools: Allow config terms with breakpoints

Posted by Adrian Hunter 2 years, 9 months ago

Hi

Here is a patch (V2) to the event parser for breakpoint events.
I am not that familiar with flex / bison, but it seemed to
need trailing context to stop the mem event colon and slash
delimiters from getting mixed up with delimiters for config
terms or event modifiers.  Please look closely at that.


Change in V2:

      Add comments to tools/perf/util/parse-events.l
      Add a test for 2 mem events back to back with config terms


Adrian Hunter (1):
      perf tools: Allow config terms with breakpoints

 tools/perf/tests/parse-events.c | 157 ++++++++++++++++++++++++++++++++++++++++
 tools/perf/util/parse-events.c  |  23 +++++-
 tools/perf/util/parse-events.h  |   6 +-
 tools/perf/util/parse-events.l  |  23 +++++-
 tools/perf/util/parse-events.y  |  42 ++++++-----
 5 files changed, 224 insertions(+), 27 deletions(-)


Regards
Adrian

Re: [PATCH V2 0/1] perf tools: Allow config terms with breakpoints

Posted by Ian Rogers 2 years, 9 months ago

On Fri, Apr 28, 2023 at 5:54 AM Adrian Hunter <adrian.hunter@intel.com> wrote:
>
> Hi
>
> Here is a patch (V2) to the event parser for breakpoint events.
> I am not that familiar with flex / bison, but it seemed to
> need trailing context to stop the mem event colon and slash
> delimiters from getting mixed up with delimiters for config
> terms or event modifiers.  Please look closely at that.
>
>
> Change in V2:
>
>       Add comments to tools/perf/util/parse-events.l
>       Add a test for 2 mem events back to back with config terms

Thanks for the tests/comments!
Reviewed-by: Ian Rogers <irogers@google.com>

Ian

>
> Adrian Hunter (1):
>       perf tools: Allow config terms with breakpoints
>
>  tools/perf/tests/parse-events.c | 157 ++++++++++++++++++++++++++++++++++++++++
>  tools/perf/util/parse-events.c  |  23 +++++-
>  tools/perf/util/parse-events.h  |   6 +-
>  tools/perf/util/parse-events.l  |  23 +++++-
>  tools/perf/util/parse-events.y  |  42 ++++++-----
>  5 files changed, 224 insertions(+), 27 deletions(-)
>
>
> Regards
> Adrian