[PATCH v3] Fix freeze in lm8333 i2c keyboard driver

Tomas Mudrunka posted 1 patch 2 years, 9 months ago
There is a newer version of this series
drivers/input/keyboard/lm8333.c | 2 ++
1 file changed, 2 insertions(+)
[PATCH v3] Fix freeze in lm8333 i2c keyboard driver
Posted by Tomas Mudrunka 2 years, 9 months ago
LM8333 uses gpio interrupt line which is triggered by falling edge.
When button is pressed before driver is loaded,
driver will miss the edge and never respond again.
To fix this we run the interrupt handler after registering IRQ
to clear the interrupt via i2c command.

Signed-off-by: Tomas Mudrunka <tomas.mudrunka@gmail.com>
---
 drivers/input/keyboard/lm8333.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/input/keyboard/lm8333.c b/drivers/input/keyboard/lm8333.c
index 7457c3220..9a810ca00 100644
--- a/drivers/input/keyboard/lm8333.c
+++ b/drivers/input/keyboard/lm8333.c
@@ -184,6 +184,8 @@ static int lm8333_probe(struct i2c_client *client)
 	if (err)
 		goto free_mem;
 
+	lm8333_irq_thread(client->irq, (void *) lm8333);
+
 	err = input_register_device(input);
 	if (err)
 		goto free_irq;
-- 
2.40.0