[v1] Fix scan-build warnings

[PATCH 0/5] Fix scan-build warnings

Dominique Martinet posted 5 patches 2 years, 9 months ago

Diff against v2
Download series mbox

There is a newer version of this series

fs/9p/vfs_dir.c        |  5 +++--
fs/9p/vfs_inode.c      |  6 ------
fs/9p/vfs_inode_dotl.c |  1 -
net/9p/client.c        | 46 ++++++++++++----------------------------------
net/9p/trans_virtio.c  |  8 ++++----
5 files changed, 19 insertions(+), 47 deletions(-)

Expand all Fold all

[PATCH 0/5] Fix scan-build warnings

Posted by Dominique Martinet 2 years, 9 months ago

I ran scan-build very crudly on our source files, and there was at least
one real bug so we might as well run it once in a while, in which case
we probably ought to also fix the less important things hence this
series.
In here the first patch is a real fix and the rest is low priority, the
last one is arguably not an improvement and can be discussed (happy to
just move the 0-initializations around to variable declaration which
would also silence scan-build afaict)

Anyway, it can probably all wait until after this merge, sorry for the
timing.

Signed-off-by: Dominique Martinet <asmadeus@codewreck.org>
---
Dominique Martinet (5):
      9p: fix ignored return value in v9fs_dir_release
      9p: virtio: fix unlikely null pointer deref in handle_rerror
      9p: virtio: make sure 'offs' is initialized in zc_request
      9p: virtio: skip incrementing unused variable
      9p: remove dead stores (variable set again without being read)

 fs/9p/vfs_dir.c        |  5 +++--
 fs/9p/vfs_inode.c      |  6 ------
 fs/9p/vfs_inode_dotl.c |  1 -
 net/9p/client.c        | 46 ++++++++++++----------------------------------
 net/9p/trans_virtio.c  |  8 ++++----
 5 files changed, 19 insertions(+), 47 deletions(-)
---
base-commit: 4eb3117888a923f6b9b1ad2dd093641c49a63ae5
change-id: 20230427-scan-build-d894c16fc945

Best regards,
-- 
Dominique Martinet | Asmadeus