dmaengine: xilinx: enable on RISC-V platform

[PATCH] dmaengine: xilinx: enable on RISC-V platform

Posted by Zong Li 2 years, 7 months ago

Enable the xilinx dmaengine driver on RISC-V platform. We have verified
the CDMA on RISC-V platform, enable this configuration to allow build on
RISC-V.

Signed-off-by: Zong Li <zong.li@sifive.com>
---
 drivers/dma/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/dma/Kconfig b/drivers/dma/Kconfig
index fb7073fc034f..816f619804b9 100644
--- a/drivers/dma/Kconfig
+++ b/drivers/dma/Kconfig
@@ -695,7 +695,7 @@ config XGENE_DMA
 
 config XILINX_DMA
 	tristate "Xilinx AXI DMAS Engine"
-	depends on (ARCH_ZYNQ || MICROBLAZE || ARM64)
+	depends on (ARCH_ZYNQ || MICROBLAZE || ARM64 || RISCV)
 	select DMA_ENGINE
 	help
 	  Enable support for Xilinx AXI VDMA Soft IP.
-- 
2.17.1

RE: [PATCH] dmaengine: xilinx: enable on RISC-V platform

Posted by Pandey, Radhey Shyam 2 years, 7 months ago

> -----Original Message-----
> From: linux-riscv <linux-riscv-bounces@lists.infradead.org> On Behalf Of
> Zong Li
> Sent: Wednesday, April 26, 2023 1:13 PM
> To: vkoul@kernel.org; dmaengine@vger.kernel.org; linux-
> kernel@vger.kernel.org; linux-riscv@lists.infradead.org
> Cc: Zong Li <zong.li@sifive.com>
> Subject: [PATCH] dmaengine: xilinx: enable on RISC-V platform
> 
> Enable the xilinx dmaengine driver on RISC-V platform. We have verified the
> CDMA on RISC-V platform, enable this configuration to allow build on RISC-V.
> 
> Signed-off-by: Zong Li <zong.li@sifive.com>
> ---
>  drivers/dma/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/dma/Kconfig b/drivers/dma/Kconfig index
> fb7073fc034f..816f619804b9 100644
> --- a/drivers/dma/Kconfig
> +++ b/drivers/dma/Kconfig
> @@ -695,7 +695,7 @@ config XGENE_DMA
> 
>  config XILINX_DMA
>  	tristate "Xilinx AXI DMAS Engine"
> -	depends on (ARCH_ZYNQ || MICROBLAZE || ARM64)
> +	depends on (ARCH_ZYNQ || MICROBLAZE || ARM64 || RISCV)

Instead of adding one more dependency I think we can cleanup this 
dependency list. Similar changes done in ethernet subsystem. Please 
have a look at below commits:

e8b6c54f6d57 net: xilinx: temac: Relax Kconfig dependencies
d7eaf962a90b net: axienet: In kconfig remove arch dependency for axi_emac

>  	select DMA_ENGINE
>  	help
>  	  Enable support for Xilinx AXI VDMA Soft IP.
> --
> 2.17.1
> 
> 
> _______________________________________________
> linux-riscv mailing list
> linux-riscv@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-riscv

Re: [PATCH] dmaengine: xilinx: enable on RISC-V platform

Posted by Zong Li 2 years, 7 months ago

On Thu, May 4, 2023 at 10:17 PM Pandey, Radhey Shyam
<radhey.shyam.pandey@amd.com> wrote:
>
> > -----Original Message-----
> > From: linux-riscv <linux-riscv-bounces@lists.infradead.org> On Behalf Of
> > Zong Li
> > Sent: Wednesday, April 26, 2023 1:13 PM
> > To: vkoul@kernel.org; dmaengine@vger.kernel.org; linux-
> > kernel@vger.kernel.org; linux-riscv@lists.infradead.org
> > Cc: Zong Li <zong.li@sifive.com>
> > Subject: [PATCH] dmaengine: xilinx: enable on RISC-V platform
> >
> > Enable the xilinx dmaengine driver on RISC-V platform. We have verified the
> > CDMA on RISC-V platform, enable this configuration to allow build on RISC-V.
> >
> > Signed-off-by: Zong Li <zong.li@sifive.com>
> > ---
> >  drivers/dma/Kconfig | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/dma/Kconfig b/drivers/dma/Kconfig index
> > fb7073fc034f..816f619804b9 100644
> > --- a/drivers/dma/Kconfig
> > +++ b/drivers/dma/Kconfig
> > @@ -695,7 +695,7 @@ config XGENE_DMA
> >
> >  config XILINX_DMA
> >       tristate "Xilinx AXI DMAS Engine"
> > -     depends on (ARCH_ZYNQ || MICROBLAZE || ARM64)
> > +     depends on (ARCH_ZYNQ || MICROBLAZE || ARM64 || RISCV)
>
> Instead of adding one more dependency I think we can cleanup this
> dependency list. Similar changes done in ethernet subsystem. Please
> have a look at below commits:
>

Hi Pandey,
Thanks for your tips, let me take a look at it, and give the next version.

> e8b6c54f6d57 net: xilinx: temac: Relax Kconfig dependencies
> d7eaf962a90b net: axienet: In kconfig remove arch dependency for axi_emac
>
> >       select DMA_ENGINE
> >       help
> >         Enable support for Xilinx AXI VDMA Soft IP.
> > --
> > 2.17.1
> >
> >
> > _______________________________________________
> > linux-riscv mailing list
> > linux-riscv@lists.infradead.org
> > http://lists.infradead.org/mailman/listinfo/linux-riscv

Re: [PATCH] dmaengine: xilinx: enable on RISC-V platform

Posted by Palmer Dabbelt 2 years, 7 months ago

On Wed, 26 Apr 2023 00:42:48 PDT (-0700), zong.li@sifive.com wrote:
> Enable the xilinx dmaengine driver on RISC-V platform. We have verified
> the CDMA on RISC-V platform, enable this configuration to allow build on
> RISC-V.
>
> Signed-off-by: Zong Li <zong.li@sifive.com>
> ---
>  drivers/dma/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/dma/Kconfig b/drivers/dma/Kconfig
> index fb7073fc034f..816f619804b9 100644
> --- a/drivers/dma/Kconfig
> +++ b/drivers/dma/Kconfig
> @@ -695,7 +695,7 @@ config XGENE_DMA
>
>  config XILINX_DMA
>  	tristate "Xilinx AXI DMAS Engine"
> -	depends on (ARCH_ZYNQ || MICROBLAZE || ARM64)
> +	depends on (ARCH_ZYNQ || MICROBLAZE || ARM64 || RISCV)
>  	select DMA_ENGINE
>  	help
>  	  Enable support for Xilinx AXI VDMA Soft IP.

Acked-by: Palmer Dabbelt <palmer@rivosinc.com>

Re: [PATCH] dmaengine: xilinx: enable on RISC-V platform

Posted by Zong Li 2 years, 7 months ago

On Wed, Apr 26, 2023 at 10:28 PM Palmer Dabbelt <palmer@dabbelt.com> wrote:
>
> On Wed, 26 Apr 2023 00:42:48 PDT (-0700), zong.li@sifive.com wrote:
> > Enable the xilinx dmaengine driver on RISC-V platform. We have verified
> > the CDMA on RISC-V platform, enable this configuration to allow build on
> > RISC-V.
> >
> > Signed-off-by: Zong Li <zong.li@sifive.com>
> > ---
> >  drivers/dma/Kconfig | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/dma/Kconfig b/drivers/dma/Kconfig
> > index fb7073fc034f..816f619804b9 100644
> > --- a/drivers/dma/Kconfig
> > +++ b/drivers/dma/Kconfig
> > @@ -695,7 +695,7 @@ config XGENE_DMA
> >
> >  config XILINX_DMA
> >       tristate "Xilinx AXI DMAS Engine"
> > -     depends on (ARCH_ZYNQ || MICROBLAZE || ARM64)
> > +     depends on (ARCH_ZYNQ || MICROBLAZE || ARM64 || RISCV)
> >       select DMA_ENGINE
> >       help
> >         Enable support for Xilinx AXI VDMA Soft IP.
>
> Acked-by: Palmer Dabbelt <palmer@rivosinc.com>

Hi Palmer,
Thanks for your review.

Hi Vinod,
Could I know if this patch also meets your expectations? If it does,
would you please consider accepting it?
Thanks.