tools lib symbol: Use -D_FORTIFY_SOURCE=2 for non-debug builds

[PATCH] tools lib symbol: Use -D_FORTIFY_SOURCE=2 for non-debug builds

Posted by Uwe Kleine-König 2 years, 9 months ago

Commit 160be157eaba ("tool lib symbol: Add Makefile/Build") failed to
define _FORTIFY_SOURCE to 2, probabaly this was cut&pasted from other
Makefiles with the same problem.

Fixes: 160be157eaba ("tool lib symbol: Add Makefile/Build")
Signed-off-by: Uwe Kleine-König <ukleinek@debian.org>
---
 tools/lib/symbol/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/lib/symbol/Makefile b/tools/lib/symbol/Makefile
index 13d43c6f92b4..4a08cc4e19f2 100644
--- a/tools/lib/symbol/Makefile
+++ b/tools/lib/symbol/Makefile
@@ -39,7 +39,7 @@ endif
 endif
 
 ifeq ($(DEBUG),0)
-  CFLAGS += -D_FORTIFY_SOURCE
+  CFLAGS += -D_FORTIFY_SOURCE=2
 endif
 
 # Treat warnings as errors unless directed not to
-- 
2.39.2

Re: [PATCH] tools lib symbol: Use -D_FORTIFY_SOURCE=2 for non-debug builds

Posted by Ian Rogers 2 years, 9 months ago

On Mon, Apr 24, 2023 at 3:28 AM Uwe Kleine-König <ukleinek@debian.org> wrote:
>
> Commit 160be157eaba ("tool lib symbol: Add Makefile/Build") failed to
> define _FORTIFY_SOURCE to 2, probabaly this was cut&pasted from other
> Makefiles with the same problem.
>
> Fixes: 160be157eaba ("tool lib symbol: Add Makefile/Build")
> Signed-off-by: Uwe Kleine-König <ukleinek@debian.org>

Acked-by: Ian Rogers <irogers@google.com>

Same problem here I think:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/tools/lib/api/Makefile#n42

Thanks,
Ian

> ---
>  tools/lib/symbol/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/lib/symbol/Makefile b/tools/lib/symbol/Makefile
> index 13d43c6f92b4..4a08cc4e19f2 100644
> --- a/tools/lib/symbol/Makefile
> +++ b/tools/lib/symbol/Makefile
> @@ -39,7 +39,7 @@ endif
>  endif
>
>  ifeq ($(DEBUG),0)
> -  CFLAGS += -D_FORTIFY_SOURCE
> +  CFLAGS += -D_FORTIFY_SOURCE=2
>  endif
>
>  # Treat warnings as errors unless directed not to
> --
> 2.39.2
>

Re: [PATCH] tools lib symbol: Use -D_FORTIFY_SOURCE=2 for non-debug builds

Posted by Uwe Kleine-König 2 years, 9 months ago

On 4/29/23 23:05, Ian Rogers wrote:
> On Mon, Apr 24, 2023 at 3:28 AM Uwe Kleine-König <ukleinek@debian.org> wrote:
>>
>> Commit 160be157eaba ("tool lib symbol: Add Makefile/Build") failed to
>> define _FORTIFY_SOURCE to 2, probabaly this was cut&pasted from other
>> Makefiles with the same problem.
>>
>> Fixes: 160be157eaba ("tool lib symbol: Add Makefile/Build")
>> Signed-off-by: Uwe Kleine-König <ukleinek@debian.org>
> 
> Acked-by: Ian Rogers <irogers@google.com>

Thanks

> Same problem here I think:
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/tools/lib/api/Makefile#n42

Indeed, and similar patch here:

	https://lore.kernel.org/all/20230424102049.58338-1-ukleinek@debian.org/

Best regards
Uwe

Re: [PATCH] tools lib symbol: Use -D_FORTIFY_SOURCE=2 for non-debug builds

Posted by Diederik de Haas 1 year, 10 months ago

On Sunday, 30 April 2023 11:11:26 CEST Uwe Kleine-König wrote:
> On 4/29/23 23:05, Ian Rogers wrote:
> > On Apr 24, 2023 at 3:28 AM Uwe Kleine-König <ukleinek@debian.org> wrote:
> >> Commit 160be157eaba ("tool lib symbol: Add Makefile/Build") failed to
> >> define _FORTIFY_SOURCE to 2, probabaly this was cut&pasted from other
> >> Makefiles with the same problem.
> >> 
> >> Fixes: 160be157eaba ("tool lib symbol: Add Makefile/Build")
> >> Signed-off-by: Uwe Kleine-König <ukleinek@debian.org>
> > 
> > Acked-by: Ian Rogers <irogers@google.com>
> 
> Thanks
> 
> > Same problem here I think:
> > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/to
> > ols/lib/api/Makefile#n42
> Indeed, and similar patch here:
> 
> https://lore.kernel.org/all/20230424102049.58338-1-ukleinek@debian.org/

I noticed this (and the other linked) patch haven't been merged yet.
What's needed to move this forward?