ARM: dts: s5pv210: remove empty camera pinctrl configuration

[PATCH] ARM: dts: s5pv210: remove empty camera pinctrl configuration

Posted by Krzysztof Kozlowski 2 years, 7 months ago

The camera's pinctrl configuration is simply empty and not effective.
Remove it to fix dtbs_check warnings like:

  s5pv210-torbreck.dtb: camera@fa600000: pinctrl-0: True is not of type 'array'

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 arch/arm/boot/dts/s5pv210.dtsi | 2 --
 1 file changed, 2 deletions(-)

diff --git a/arch/arm/boot/dts/s5pv210.dtsi b/arch/arm/boot/dts/s5pv210.dtsi
index d9436bbf77c8..faa3682ab5dd 100644
--- a/arch/arm/boot/dts/s5pv210.dtsi
+++ b/arch/arm/boot/dts/s5pv210.dtsi
@@ -549,8 +549,6 @@ i2c1: i2c@fab00000 {
 
 		camera: camera@fa600000 {
 			compatible = "samsung,fimc";
-			pinctrl-names = "default";
-			pinctrl-0 = <>;
 			clocks = <&clocks SCLK_CAM0>, <&clocks SCLK_CAM1>;
 			clock-names = "sclk_cam0", "sclk_cam1";
 			#address-cells = <1>;
-- 
2.34.1

Re: [PATCH] ARM: dts: s5pv210: remove empty camera pinctrl configuration

Posted by Krzysztof Kozlowski 2 years, 7 months ago

On Fri, 21 Apr 2023 21:02:02 +0200, Krzysztof Kozlowski wrote:
> The camera's pinctrl configuration is simply empty and not effective.
> Remove it to fix dtbs_check warnings like:
> 
>   s5pv210-torbreck.dtb: camera@fa600000: pinctrl-0: True is not of type 'array'
> 
> 

Applied, thanks!

[1/1] ARM: dts: s5pv210: remove empty camera pinctrl configuration
      https://git.kernel.org/krzk/linux/c/b8039b4e40094e81351221275ed61ee7643cdb91

Best regards,
-- 
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

RE: [PATCH] ARM: dts: s5pv210: remove empty camera pinctrl configuration

Posted by Alim Akhtar 2 years, 7 months ago


> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Sent: Saturday, April 22, 2023 12:32 AM
> To: Rob Herring <robh+dt@kernel.org>; Krzysztof Kozlowski
> <krzysztof.kozlowski+dt@linaro.org>; Alim Akhtar
> <alim.akhtar@samsung.com>; devicetree@vger.kernel.org; linux-arm-
> kernel@lists.infradead.org; linux-samsung-soc@vger.kernel.org; linux-
> kernel@vger.kernel.org
> Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Subject: [PATCH] ARM: dts: s5pv210: remove empty camera pinctrl
> configuration
> 
> The camera's pinctrl configuration is simply empty and not effective.
> Remove it to fix dtbs_check warnings like:
> 
>   s5pv210-torbreck.dtb: camera@fa600000: pinctrl-0: True is not of type
> 'array'
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---

Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com>

>  arch/arm/boot/dts/s5pv210.dtsi | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/s5pv210.dtsi
> b/arch/arm/boot/dts/s5pv210.dtsi index d9436bbf77c8..faa3682ab5dd
> 100644
> --- a/arch/arm/boot/dts/s5pv210.dtsi
> +++ b/arch/arm/boot/dts/s5pv210.dtsi
> @@ -549,8 +549,6 @@ i2c1: i2c@fab00000 {
> 
>  		camera: camera@fa600000 {
>  			compatible = "samsung,fimc";
> -			pinctrl-names = "default";
> -			pinctrl-0 = <>;
>  			clocks = <&clocks SCLK_CAM0>, <&clocks
> SCLK_CAM1>;
>  			clock-names = "sclk_cam0", "sclk_cam1";
>  			#address-cells = <1>;
> --
> 2.34.1