[v3] Enable rk3588 timer support

[PATCH v3 0/3] Enable rk3588 timer support

Posted by Cristian Ciocaltea 2 years, 8 months ago

This patchset enables Rockchip RK3588/RK3588S SoC timer support.
While here, it also handles a minor DT binding issue related to RK3288.

Changes in v3:
 - Updated commit description in patch 1, per Krzysztof's review
 - Added Acked-by tag from Krzysztof in patch 2
 - v2: https://lore.kernel.org/lkml/20230418120624.284551-1-cristian.ciocaltea@collabora.com/

Changes in v2:
 - Added Reviewed-by tag from Heiko in patches 1 & 2
 - Update patch 3 according to Johan's review
 - v1: https://lore.kernel.org/lkml/20230418095344.274025-1-cristian.ciocaltea@collabora.com/

Cristian Ciocaltea (3):
  dt-bindings: timer: rockchip: Drop superfluous rk3288 compatible
  dt-bindings: timer: rockchip: Add rk3588 compatible
  arm64: dts: rockchip: Add rk3588 timer

 .../devicetree/bindings/timer/rockchip,rk-timer.yaml      | 2 +-
 arch/arm64/boot/dts/rockchip/rk3588s.dtsi                 | 8 ++++++++
 2 files changed, 9 insertions(+), 1 deletion(-)

-- 
2.40.0

Re: [PATCH v3 0/3] Enable rk3588 timer support

Posted by Vincent Legoll 2 years, 7 months ago

Hello,

On Wed, Apr 19, 2023 at 6:13 PM Cristian Ciocaltea
<cristian.ciocaltea@collabora.com> wrote:
> This patchset enables Rockchip RK3588/RK3588S SoC timer support.
> While here, it also handles a minor DT binding issue related to RK3288.

I tested this on a QuartzPro64 dev board, I applied your series top of my tree:
Collabora's rk3588 + some DT patches to add support for the qp64 board.

Here is the output from the commands you told me to try:

bash-5.1# grep rk_timer /sys/bus/clockevents/devices/*/current_device
/sys/bus/clockevents/devices/broadcast/current_device:rk_timer

bash-5.1# grep -B3 -A14 'Device: rk_timer' /proc/timer_list

Tick Device: mode:     1
Broadcast device
Clock Event Device: rk_timer
 max_delta_ns:   178956969070
 min_delta_ns:   1000
 mult:           51539608
 shift:          31
 mode:           3
 next_event:     150944000000 nsecs
 set_next_event: rk_timer_set_next_event
 shutdown:       rk_timer_shutdown
 periodic:       rk_timer_set_periodic
 event_handler:  tick_handle_oneshot_broadcast

 retries:        0

tick_broadcast_mask: ff

bash-5.1# head -1 /proc/interrupts ; grep rk_timer /proc/interrupts;
sleep 10; grep rk_timer /proc/interrupts
           CPU0       CPU1       CPU2       CPU3       CPU4       CPU5
      CPU6       CPU7
 25:        742        210         52         49       2197       1640
      1089       2341     GICv3 321 Level     rk_timer
 25:        754        222         52         49       2252       1727
      1146       2404     GICv3 321 Level     rk_timer

So it looks like this is working.

Thanks for your work.

You can add my:

Tested-by: Vincent Legoll <vincent.legoll@gmail.com>

Regards

-- 
Vincent Legoll

Re: [PATCH v3 0/3] Enable rk3588 timer support

Posted by Cristian Ciocaltea 2 years, 7 months ago

On 4/22/23 16:17, Vincent Legoll wrote:
> Hello,
> 
> On Wed, Apr 19, 2023 at 6:13 PM Cristian Ciocaltea
> <cristian.ciocaltea@collabora.com> wrote:
>> This patchset enables Rockchip RK3588/RK3588S SoC timer support.
>> While here, it also handles a minor DT binding issue related to RK3288.
> 
> I tested this on a QuartzPro64 dev board, I applied your series top of my tree:
> Collabora's rk3588 + some DT patches to add support for the qp64 board.
> 
> Here is the output from the commands you told me to try:
> 
> bash-5.1# grep rk_timer /sys/bus/clockevents/devices/*/current_device
> /sys/bus/clockevents/devices/broadcast/current_device:rk_timer
> 
> bash-5.1# grep -B3 -A14 'Device: rk_timer' /proc/timer_list
> 
> Tick Device: mode:     1
> Broadcast device
> Clock Event Device: rk_timer
>  max_delta_ns:   178956969070
>  min_delta_ns:   1000
>  mult:           51539608
>  shift:          31
>  mode:           3
>  next_event:     150944000000 nsecs
>  set_next_event: rk_timer_set_next_event
>  shutdown:       rk_timer_shutdown
>  periodic:       rk_timer_set_periodic
>  event_handler:  tick_handle_oneshot_broadcast
> 
>  retries:        0
> 
> tick_broadcast_mask: ff
> 
> bash-5.1# head -1 /proc/interrupts ; grep rk_timer /proc/interrupts;
> sleep 10; grep rk_timer /proc/interrupts
>            CPU0       CPU1       CPU2       CPU3       CPU4       CPU5
>       CPU6       CPU7
>  25:        742        210         52         49       2197       1640
>       1089       2341     GICv3 321 Level     rk_timer
>  25:        754        222         52         49       2252       1727
>       1146       2404     GICv3 321 Level     rk_timer
> 
> So it looks like this is working.
> 
> Thanks for your work.
> 
> You can add my:
> 
> Tested-by: Vincent Legoll <vincent.legoll@gmail.com>

Thanks for taking the time to test this!

Regards,
Cristian

Re: [PATCH v3 0/3] Enable rk3588 timer support

Posted by Vincent Legoll 2 years, 7 months ago

Hi,

On Sat, Apr 22, 2023 at 3:15 PM Cristian Ciocaltea
<cristian.ciocaltea@collabora.com> wrote:
> Thanks for taking the time to test this!

You did the work, I try to help...

BTW, I'll test the PWM fan patch (ported to QP64 board) iff I can find
a fan with the same connector...

Regards

-- 
Vincent Legoll

Re: (subset) [PATCH v3 0/3] Enable rk3588 timer support

Posted by Heiko Stuebner 2 years, 7 months ago

On Wed, 19 Apr 2023 21:13:06 +0300, Cristian Ciocaltea wrote:
> This patchset enables Rockchip RK3588/RK3588S SoC timer support.
> While here, it also handles a minor DT binding issue related to RK3288.
> 
> Changes in v3:
>  - Updated commit description in patch 1, per Krzysztof's review
>  - Added Acked-by tag from Krzysztof in patch 2
>  - v2: https://lore.kernel.org/lkml/20230418120624.284551-1-cristian.ciocaltea@collabora.com/
> 
> [...]

Applied, thanks!

[3/3] arm64: dts: rockchip: Add rk3588 timer
      commit: 9558529472d72a79ee6cd02da6c4439ec12a63e9
      [will be rebased on top of 6.4-rc1]

Best regards,
-- 
Heiko Stuebner <heiko@sntech.de>