[v2] *** firmware: imx: NXP Edgelock Enclave MUAP Driver ***

[PATCH v2 0/7] *** firmware: imx: NXP Edgelock Enclave MUAP Driver ***

Posted by Pankaj Gupta 2 years, 8 months ago

v2 Changes:

- Fixed Kernel Test Bot issues.
- Removed ".../devicetree/bindings/mailbox/fsl,muap.txt"

v1:

The Messaging Unit module enables two processing elements within the SoC to
communicate and coordinate by passing messages (e.g., data, status and control)
through its interfaces.

The NXP i.MX EdgeLock Enclave Message Unit (ELE-MUAP) is specifically targeted
for use between application core and Edgelocke Enclave. It allows to send
messages to the EL Enclave using a shared mailbox.

Patch-set add the ELE-MU  kernel driver for exchanging messages with i.MX NXP
ELE IP; both from:
- User-Space Applications via character driver.
- Kernel-space, used by kernel management layers like DM-Crypt.

Pankaj Gupta (7):
  doc: device tree binding addition for ele MU
  arm64: dts: imx93-11x11-evk: added ele-mu
  arm64: dts: imx93-11x11-evk: reserved mem-ranges to constrain ele-mu
    dma-range
  arm64: dts: imx8ulp-evk: added ele-mu
  arm64: dts: imx8ulp-evk: reserved mem-ranges to constrain ele-mu
    dma-range
  firmware: imx: add ELE MU driver support
  MAINTAINERS: Added maintainer details


 .../bindings/arm/freescale/fsl,ele_mu.yaml    |  139 ++
 MAINTAINERS                                   |    7 +
 arch/arm64/boot/dts/freescale/imx8ulp-evk.dts |   15 +
 arch/arm64/boot/dts/freescale/imx8ulp.dtsi    |   13 +-
 .../boot/dts/freescale/imx93-11x11-evk.dts    |   15 +
 arch/arm64/boot/dts/freescale/imx93.dtsi      |   11 +-
 drivers/firmware/imx/Kconfig                  |   11 +
 drivers/firmware/imx/Makefile                 |    2 +
 drivers/firmware/imx/ele_base_msg.c           |  378 +++++
 drivers/firmware/imx/ele_mu.c                 | 1285 +++++++++++++++++
 drivers/firmware/imx/ele_mu.h                 |  174 +++
 include/linux/firmware/imx/ele_base_msg.h     |   67 +
 include/linux/firmware/imx/ele_mu_ioctl.h     |   52 +
 13 files changed, 2167 insertions(+), 2 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/arm/freescale/fsl,ele_mu.yaml
 create mode 100644 drivers/firmware/imx/ele_base_msg.c
 create mode 100644 drivers/firmware/imx/ele_mu.c
 create mode 100644 drivers/firmware/imx/ele_mu.h
 create mode 100644 include/linux/firmware/imx/ele_base_msg.h
 create mode 100644 include/linux/firmware/imx/ele_mu_ioctl.h

-- 
2.34.1

Re: [PATCH v2 0/7] *** firmware: imx: NXP Edgelock Enclave MUAP Driver ***

Posted by Daniel Baluta 2 years, 7 months ago

On Wed, Apr 19, 2023 at 3:45 PM Pankaj Gupta <pankaj.gupta@nxp.com> wrote:
>
> v2 Changes:
>
> - Fixed Kernel Test Bot issues.
> - Removed ".../devicetree/bindings/mailbox/fsl,muap.txt"
>
> v1:
>
> The Messaging Unit module enables two processing elements within the SoC to
> communicate and coordinate by passing messages (e.g., data, status and control)
> through its interfaces.
>
> The NXP i.MX EdgeLock Enclave Message Unit (ELE-MUAP) is specifically targeted
> for use between application core and Edgelocke Enclave. It allows to send
> messages to the EL Enclave using a shared mailbox.
>
> Patch-set add the ELE-MU  kernel driver for exchanging messages with i.MX NXP
> ELE IP; both from:
> - User-Space Applications via character driver.
> - Kernel-space, used by kernel management layers like DM-Crypt.


What's wrong with existing NXP MU driver?

RE: [EXT] Re: [PATCH v2 0/7] *** firmware: imx: NXP Edgelock Enclave MUAP Driver ***

Posted by Pankaj Gupta 2 years, 5 months ago

Hi Daniel,

As discussed already on your query,  answering to this, for everybody:

There is no existing NXP MU driver, that is up-streamed.
ele-mu driver is using(dependent on) the underline IMX_MBOX, driver you might be referring to.

Thanks.

Regards
Pankaj

> -----Original Message-----
> From: Daniel Baluta <daniel.baluta@gmail.com>
> Sent: Monday, April 24, 2023 7:38 PM
> To: Pankaj Gupta <pankaj.gupta@nxp.com>
> Cc: shawnguo@kernel.org; s.hauer@pengutronix.de;
> kernel@pengutronix.de; festevam@gmail.com; dl-linux-imx <linux-
> imx@nxp.com>; robh+dt@kernel.org; krzysztof.kozlowski+dt@linaro.org;
> linux-kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org;
> devicetree@vger.kernel.org; Gaurav Jain <gaurav.jain@nxp.com>; Sahil
> Malhotra <sahil.malhotra@nxp.com>; Aisheng Dong
> <aisheng.dong@nxp.com>; Varun Sethi <V.Sethi@nxp.com>
> Subject: [EXT] Re: [PATCH v2 0/7] *** firmware: imx: NXP Edgelock Enclave
> MUAP Driver ***
> 
> Caution: EXT Email
> 
> On Wed, Apr 19, 2023 at 3:45 PM Pankaj Gupta <pankaj.gupta@nxp.com>
> wrote:
> >
> > v2 Changes:
> >
> > - Fixed Kernel Test Bot issues.
> > - Removed ".../devicetree/bindings/mailbox/fsl,muap.txt"
> >
> > v1:
> >
> > The Messaging Unit module enables two processing elements within the
> > SoC to communicate and coordinate by passing messages (e.g., data,
> > status and control) through its interfaces.
> >
> > The NXP i.MX EdgeLock Enclave Message Unit (ELE-MUAP) is specifically
> > targeted for use between application core and Edgelocke Enclave. It
> > allows to send messages to the EL Enclave using a shared mailbox.
> >
> > Patch-set add the ELE-MU  kernel driver for exchanging messages with
> > i.MX NXP ELE IP; both from:
> > - User-Space Applications via character driver.
> > - Kernel-space, used by kernel management layers like DM-Crypt.
> 
> 
> What's wrong with existing NXP MU driver?

Re: [PATCH v2 0/7] *** firmware: imx: NXP Edgelock Enclave MUAP Driver ***

Posted by Krzysztof Kozlowski 2 years, 8 months ago

On 19/04/2023 19:55, Pankaj Gupta wrote:
> v2 Changes:
> 
> - Fixed Kernel Test Bot issues.
> - Removed ".../devicetree/bindings/mailbox/fsl,muap.txt"

Drop some weird *** from subject. There is no reason to make it extra,
extra bold font.

Best regards,
Krzysztof