Drivers: hv: vmbus: Remove unnecessary (void*) conversions

[PATCH] Drivers: hv: vmbus: Remove unnecessary (void*) conversions

Posted by Suhui 2 years, 8 months ago

No need cast (void*) to (struct hv_ring_buffer *).

Signed-off-by: Suhui <suhui@nfschina.com>
---
 drivers/hv/ring_buffer.c | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

diff --git a/drivers/hv/ring_buffer.c b/drivers/hv/ring_buffer.c
index c6692fd5ab15..5471321169e9 100644
--- a/drivers/hv/ring_buffer.c
+++ b/drivers/hv/ring_buffer.c
@@ -209,9 +209,8 @@ int hv_ringbuffer_init(struct hv_ring_buffer_info *ring_info,
 		for (i = 0; i < 2 * (page_cnt - 1); i++)
 			pfns_wraparound[i + 1] = pfn + i % (page_cnt - 1) + 1;
 
-		ring_info->ring_buffer = (struct hv_ring_buffer *)
-			vmap_pfn(pfns_wraparound, page_cnt * 2 - 1,
-				 PAGE_KERNEL);
+		ring_info->ring_buffer = vmap_pfn(pfns_wraparound, page_cnt * 2 - 1,
+						  PAGE_KERNEL);
 		kfree(pfns_wraparound);
 
 		if (!ring_info->ring_buffer)
@@ -231,9 +230,8 @@ int hv_ringbuffer_init(struct hv_ring_buffer_info *ring_info,
 			pages_wraparound[i + 1] =
 				&pages[i % (page_cnt - 1) + 1];
 
-		ring_info->ring_buffer = (struct hv_ring_buffer *)
-			vmap(pages_wraparound, page_cnt * 2 - 1, VM_MAP,
-				PAGE_KERNEL);
+		ring_info->ring_buffer = vmap(pages_wraparound, page_cnt * 2 - 1, VM_MAP,
+					      PAGE_KERNEL);
 
 		kfree(pages_wraparound);
 		if (!ring_info->ring_buffer)
-- 
2.34.1

Re: [PATCH] Drivers: hv: vmbus: Remove unnecessary (void*) conversions

Posted by Wei Liu 2 years, 8 months ago

On Wed, Apr 19, 2023 at 04:03:31PM +0800, Suhui wrote:
> No need cast (void*) to (struct hv_ring_buffer *).
> 
> Signed-off-by: Suhui <suhui@nfschina.com>

Unfortunately due to recent changes this patch no longer applies to
hyperv-next.

> ---
>  drivers/hv/ring_buffer.c | 10 ++++------
>  1 file changed, 4 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/hv/ring_buffer.c b/drivers/hv/ring_buffer.c
> index c6692fd5ab15..5471321169e9 100644
> --- a/drivers/hv/ring_buffer.c
> +++ b/drivers/hv/ring_buffer.c
> @@ -209,9 +209,8 @@ int hv_ringbuffer_init(struct hv_ring_buffer_info *ring_info,
>  		for (i = 0; i < 2 * (page_cnt - 1); i++)
>  			pfns_wraparound[i + 1] = pfn + i % (page_cnt - 1) + 1;
>  
> -		ring_info->ring_buffer = (struct hv_ring_buffer *)
> -			vmap_pfn(pfns_wraparound, page_cnt * 2 - 1,
> -				 PAGE_KERNEL);
> +		ring_info->ring_buffer = vmap_pfn(pfns_wraparound, page_cnt * 2 - 1,
> +						  PAGE_KERNEL);
>  		kfree(pfns_wraparound);
>  
>  		if (!ring_info->ring_buffer)
> @@ -231,9 +230,8 @@ int hv_ringbuffer_init(struct hv_ring_buffer_info *ring_info,
>  			pages_wraparound[i + 1] =
>  				&pages[i % (page_cnt - 1) + 1];
>  
> -		ring_info->ring_buffer = (struct hv_ring_buffer *)
> -			vmap(pages_wraparound, page_cnt * 2 - 1, VM_MAP,
> -				PAGE_KERNEL);
> +		ring_info->ring_buffer = vmap(pages_wraparound, page_cnt * 2 - 1, VM_MAP,
> +					      PAGE_KERNEL);
>  
>  		kfree(pages_wraparound);
>  		if (!ring_info->ring_buffer)
> -- 
> 2.34.1
>