dt-bindings: power: reset: qcom-pon: Only allow reboot-mode pre-pmk8350

[PATCH] dt-bindings: power: reset: qcom-pon: Only allow reboot-mode pre-pmk8350

Posted by Konrad Dybcio 2 years, 8 months ago

As pointed out by Shazad [1], PMICs using a separate HLOS+PBS scheme
(so PMK8350 and newer) are expected to pass reboot mode data through SDAM,
as the reboot mode registers are absent in the HLOS reg space.

Limit the reboot-mode.yaml inclusion to PMICs without a separate PBS
region.

[1] https://lore.kernel.org/linux-arm-msm/12f13183-c381-25f7-459e-62e0c2b19498@quicinc.com/

Fixes: 03fccdc76dce ("dt-bindings: power: reset: qcom-pon: Add new compatible "qcom,pmk8350-pon"")
Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
---
 Documentation/devicetree/bindings/power/reset/qcom,pon.yaml | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/power/reset/qcom,pon.yaml b/Documentation/devicetree/bindings/power/reset/qcom,pon.yaml
index d96170eecbd2..0b1eca734d3b 100644
--- a/Documentation/devicetree/bindings/power/reset/qcom,pon.yaml
+++ b/Documentation/devicetree/bindings/power/reset/qcom,pon.yaml
@@ -56,7 +56,6 @@ required:
 unevaluatedProperties: false
 
 allOf:
-  - $ref: reboot-mode.yaml#
   - if:
       properties:
         compatible:
@@ -66,6 +65,9 @@ allOf:
               - qcom,pms405-pon
               - qcom,pm8998-pon
     then:
+      allOf:
+        - $ref: reboot-mode.yaml#
+
       properties:
         reg:
           maxItems: 1

---
base-commit: 67d5d9f013d6c3829383c08162939cabff14fccc
change-id: 20230419-topic-pmic_pon_bindings-ffdd6c088f8e

Best regards,
-- 
Konrad Dybcio <konrad.dybcio@linaro.org>

Re: [PATCH] dt-bindings: power: reset: qcom-pon: Only allow reboot-mode pre-pmk8350

Posted by Rob Herring 2 years, 7 months ago

On Wed, 19 Apr 2023 12:41:06 +0200, Konrad Dybcio wrote:
> As pointed out by Shazad [1], PMICs using a separate HLOS+PBS scheme
> (so PMK8350 and newer) are expected to pass reboot mode data through SDAM,
> as the reboot mode registers are absent in the HLOS reg space.
> 
> Limit the reboot-mode.yaml inclusion to PMICs without a separate PBS
> region.
> 
> [1] https://lore.kernel.org/linux-arm-msm/12f13183-c381-25f7-459e-62e0c2b19498@quicinc.com/
> 
> Fixes: 03fccdc76dce ("dt-bindings: power: reset: qcom-pon: Add new compatible "qcom,pmk8350-pon"")
> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
> ---
>  Documentation/devicetree/bindings/power/reset/qcom,pon.yaml | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 

Acked-by: Rob Herring <robh@kernel.org>

Re: [PATCH] dt-bindings: power: reset: qcom-pon: Only allow reboot-mode pre-pmk8350

Posted by Sebastian Reichel 2 years, 7 months ago

Hi,

On Fri, Apr 21, 2023 at 02:07:11PM -0500, Rob Herring wrote:
> On Wed, 19 Apr 2023 12:41:06 +0200, Konrad Dybcio wrote:
> > As pointed out by Shazad [1], PMICs using a separate HLOS+PBS scheme
> > (so PMK8350 and newer) are expected to pass reboot mode data through SDAM,
> > as the reboot mode registers are absent in the HLOS reg space.
> > 
> > Limit the reboot-mode.yaml inclusion to PMICs without a separate PBS
> > region.
> > 
> > [1] https://lore.kernel.org/linux-arm-msm/12f13183-c381-25f7-459e-62e0c2b19498@quicinc.com/
> > 
> > Fixes: 03fccdc76dce ("dt-bindings: power: reset: qcom-pon: Add new compatible "qcom,pmk8350-pon"")
> > Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
> > ---
> >  Documentation/devicetree/bindings/power/reset/qcom,pon.yaml | 4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> Acked-by: Rob Herring <robh@kernel.org>

Thanks, queued.

-- Sebastian