[PATCH 1/3] rust: alloc: clarify what is the upstream version

Miguel Ojeda posted 3 patches 2 years, 8 months ago
[PATCH 1/3] rust: alloc: clarify what is the upstream version
Posted by Miguel Ojeda 2 years, 8 months ago
It may be unclear for readers which upstream Rust version these files
are based on. They may be unaware that they are intended to match the
minimum (and only, so far) supported version of Rust in the kernel.

Thus clarify it.

Signed-off-by: Miguel Ojeda <ojeda@kernel.org>
---
 rust/alloc/README.md | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/rust/alloc/README.md b/rust/alloc/README.md
index c89c753720b5..eb6f22e94ebf 100644
--- a/rust/alloc/README.md
+++ b/rust/alloc/README.md
@@ -10,6 +10,9 @@ upstream. In general, only additions should be performed (e.g. new
 methods). Eventually, changes should make it into upstream so that,
 at some point, this fork can be dropped from the kernel tree.
 
+The Rust upstream version on top of which these files are based matches
+the output of `scripts/min-tool-version.sh rustc`.
+
 
 ## Rationale
 
-- 
2.40.0
Re: [PATCH 1/3] rust: alloc: clarify what is the upstream version
Posted by Björn Roy Baron 2 years, 7 months ago
On Tuesday, April 18th, 2023 at 23:43, Miguel Ojeda <ojeda@kernel.org> wrote:

> It may be unclear for readers which upstream Rust version these files
> are based on. They may be unaware that they are intended to match the
> minimum (and only, so far) supported version of Rust in the kernel.
> 
> Thus clarify it.
> 
> Signed-off-by: Miguel Ojeda ojeda@kernel.org

Reviewed-by: Björn Roy Baron <bjorn3_gh@protonmail.com>

> 
> ---
>  rust/alloc/README.md | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/rust/alloc/README.md b/rust/alloc/README.md
> index c89c753720b5..eb6f22e94ebf 100644
> --- a/rust/alloc/README.md
> +++ b/rust/alloc/README.md
> @@ -10,6 +10,9 @@ upstream. In general, only additions should be performed (e.g. new
>  methods). Eventually, changes should make it into upstream so that,
>  at some point, this fork can be dropped from the kernel tree.
> 
> +The Rust upstream version on top of which these files are based matches
> +the output of `scripts/min-tool-version.sh rustc`.
> +
> 
>  ## Rationale
> 
> --
> 2.40.0
Re: [PATCH 1/3] rust: alloc: clarify what is the upstream version
Posted by Gary Guo 2 years, 8 months ago
On Tue, 18 Apr 2023 23:43:45 +0200
Miguel Ojeda <ojeda@kernel.org> wrote:

> It may be unclear for readers which upstream Rust version these files
> are based on. They may be unaware that they are intended to match the
> minimum (and only, so far) supported version of Rust in the kernel.
> 
> Thus clarify it.
> 
> Signed-off-by: Miguel Ojeda <ojeda@kernel.org>

Reviewed-by: Gary Guo <gary@garyguo.net>

> ---
>  rust/alloc/README.md | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/rust/alloc/README.md b/rust/alloc/README.md
> index c89c753720b5..eb6f22e94ebf 100644
> --- a/rust/alloc/README.md
> +++ b/rust/alloc/README.md
> @@ -10,6 +10,9 @@ upstream. In general, only additions should be performed (e.g. new
>  methods). Eventually, changes should make it into upstream so that,
>  at some point, this fork can be dropped from the kernel tree.
>  
> +The Rust upstream version on top of which these files are based matches
> +the output of `scripts/min-tool-version.sh rustc`.
> +
>  
>  ## Rationale
>
Re: [PATCH 1/3] rust: alloc: clarify what is the upstream version
Posted by Benno Lossin 2 years, 8 months ago
On 18.04.23 23:43, Miguel Ojeda wrote:
> It may be unclear for readers which upstream Rust version these files
> are based on. They may be unaware that they are intended to match the
> minimum (and only, so far) supported version of Rust in the kernel.
> 
> Thus clarify it.
> 
> Signed-off-by: Miguel Ojeda <ojeda@kernel.org>

Reviewed-by: Benno Lossin <benno.lossin@proton.me>

> ---
>   rust/alloc/README.md | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/rust/alloc/README.md b/rust/alloc/README.md
> index c89c753720b5..eb6f22e94ebf 100644
> --- a/rust/alloc/README.md
> +++ b/rust/alloc/README.md
> @@ -10,6 +10,9 @@ upstream. In general, only additions should be performed (e.g. new
>   methods). Eventually, changes should make it into upstream so that,
>   at some point, this fork can be dropped from the kernel tree.
> 
> +The Rust upstream version on top of which these files are based matches
> +the output of `scripts/min-tool-version.sh rustc`.
> +
> 
>   ## Rationale
> 
> --
> 2.40.0
>
Re: [PATCH 1/3] rust: alloc: clarify what is the upstream version
Posted by Martin Rodriguez Reboredo 2 years, 8 months ago
On 4/18/23 18:43, Miguel Ojeda wrote:
> It may be unclear for readers which upstream Rust version these files
> are based on. They may be unaware that they are intended to match the
> minimum (and only, so far) supported version of Rust in the kernel.
> 
> Thus clarify it.
> 
> Signed-off-by: Miguel Ojeda <ojeda@kernel.org>
> ---
>  rust/alloc/README.md | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/rust/alloc/README.md b/rust/alloc/README.md
> index c89c753720b5..eb6f22e94ebf 100644
> --- a/rust/alloc/README.md
> +++ b/rust/alloc/README.md
> @@ -10,6 +10,9 @@ upstream. In general, only additions should be performed (e.g. new
>  methods). Eventually, changes should make it into upstream so that,
>  at some point, this fork can be dropped from the kernel tree.
>  
> +The Rust upstream version on top of which these files are based matches
> +the output of `scripts/min-tool-version.sh rustc`.
> +
>  
>  ## Rationale
>  

Reviewed-by: Martin Rodriguez Reboredo <yakoyoku@gmail.com>