[PATCH 1/7] PCI: meson: Add 'Amlogic' to Kconfig prompt

Bjorn Helgaas posted 7 patches 2 years, 8 months ago
[PATCH 1/7] PCI: meson: Add 'Amlogic' to Kconfig prompt
Posted by Bjorn Helgaas 2 years, 8 months ago
From: Bjorn Helgaas <bhelgaas@google.com>

Add the "Amlogic" vendor name to the CONFIG_PCI_MESON Kconfig prompt to
match other PCIe drivers.  Capitalize "Meson" to match other Meson Kconfig
prompts.

Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Cc: Yue Wang <yue.wang@Amlogic.com>
---
 drivers/pci/controller/dwc/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pci/controller/dwc/Kconfig b/drivers/pci/controller/dwc/Kconfig
index d29551261e80..617fcc7563ae 100644
--- a/drivers/pci/controller/dwc/Kconfig
+++ b/drivers/pci/controller/dwc/Kconfig
@@ -321,7 +321,7 @@ config PCIE_HISI_STB
 	  Say Y here if you want PCIe controller support on HiSilicon STB SoCs
 
 config PCI_MESON
-	tristate "MESON PCIe controller"
+	tristate "Amlogic Meson PCIe controller"
 	default m if ARCH_MESON
 	depends on PCI_MSI
 	select PCIE_DW_HOST
-- 
2.25.1
Re: [PATCH 1/7] PCI: meson: Add 'Amlogic' to Kconfig prompt
Posted by Florian Fainelli 2 years, 8 months ago
On 4/18/23 10:43, Bjorn Helgaas wrote:
> From: Bjorn Helgaas <bhelgaas@google.com>
> 
> Add the "Amlogic" vendor name to the CONFIG_PCI_MESON Kconfig prompt to
> match other PCIe drivers.  Capitalize "Meson" to match other Meson Kconfig
> prompts.

Did you mean, do not capitalize "Meson" or did you intend to preserve 
the previous hunk that had "Meson" capitalized?
-- 
Florian
Re: [PATCH 1/7] PCI: meson: Add 'Amlogic' to Kconfig prompt
Posted by Bjorn Helgaas 2 years, 8 months ago
On Tue, Apr 18, 2023 at 11:10:39AM -0700, Florian Fainelli wrote:
> On 4/18/23 10:43, Bjorn Helgaas wrote:
> > From: Bjorn Helgaas <bhelgaas@google.com>
> > 
> > Add the "Amlogic" vendor name to the CONFIG_PCI_MESON Kconfig prompt to
> > match other PCIe drivers.  Capitalize "Meson" to match other Meson Kconfig
> > prompts.
> 
> Did you mean, do not capitalize "Meson" or did you intend to preserve the
> previous hunk that had "Meson" capitalized?

I made it match other Meson prompts:

  arch/arm/mach-meson/Kconfig-    bool "Amlogic Meson6 (8726MX) SoCs support"
  drivers/char/hw_random/Kconfig- tristate "Amlogic Meson Random Number Generator support"
  drivers/clk/meson/Kconfig-      bool "Meson8 SoC Clock controller support"
  drivers/gpu/drm/meson/Kconfig-  tristate "DRM Support for Amlogic Meson Display Controller"
  drivers/i2c/busses/Kconfig-     tristate "Amlogic Meson I2C controller"
  drivers/iio/adc/Kconfig-        tristate "Amlogic Meson SAR ADC driver"
  drivers/media/cec/platform/Kconfig-     tristate "Amlogic Meson AO CEC driver"

So I guess could have described as "style Meson with initial cap only
instead of all caps" or something.

Bjorn
Re: [PATCH 1/7] PCI: meson: Add 'Amlogic' to Kconfig prompt
Posted by Florian Fainelli 2 years, 8 months ago
On 4/18/23 11:40, Bjorn Helgaas wrote:
> On Tue, Apr 18, 2023 at 11:10:39AM -0700, Florian Fainelli wrote:
>> On 4/18/23 10:43, Bjorn Helgaas wrote:
>>> From: Bjorn Helgaas <bhelgaas@google.com>
>>>
>>> Add the "Amlogic" vendor name to the CONFIG_PCI_MESON Kconfig prompt to
>>> match other PCIe drivers.  Capitalize "Meson" to match other Meson Kconfig
>>> prompts.
>>
>> Did you mean, do not capitalize "Meson" or did you intend to preserve the
>> previous hunk that had "Meson" capitalized?
> 
> I made it match other Meson prompts:
> 
>    arch/arm/mach-meson/Kconfig-    bool "Amlogic Meson6 (8726MX) SoCs support"
>    drivers/char/hw_random/Kconfig- tristate "Amlogic Meson Random Number Generator support"
>    drivers/clk/meson/Kconfig-      bool "Meson8 SoC Clock controller support"
>    drivers/gpu/drm/meson/Kconfig-  tristate "DRM Support for Amlogic Meson Display Controller"
>    drivers/i2c/busses/Kconfig-     tristate "Amlogic Meson I2C controller"
>    drivers/iio/adc/Kconfig-        tristate "Amlogic Meson SAR ADC driver"
>    drivers/media/cec/platform/Kconfig-     tristate "Amlogic Meson AO CEC driver"
> 
> So I guess could have described as "style Meson with initial cap only
> instead of all caps" or something.

This is fine, I was just reading it wrong, as meaning all capital 
letters. Thanks.
-- 
Florian