[PATCH] dt-bindings: net: ethernet: Fix JSON pointer references

Rob Herring posted 1 patch 2 years, 8 months ago
Documentation/devicetree/bindings/net/ethernet-controller.yaml | 2 +-
Documentation/devicetree/bindings/net/ethernet-switch.yaml     | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
[PATCH] dt-bindings: net: ethernet: Fix JSON pointer references
Posted by Rob Herring 2 years, 8 months ago
A JSON pointer reference (the part after the "#") must start with a "/".
Conversely, references to the entire document must not have a trailing "/"
and should be just a "#". The existing jsonschema package allows these,
but coming changes make allowed "$ref" URIs stricter and throw errors on
these references.

Signed-off-by: Rob Herring <robh@kernel.org>
---
 Documentation/devicetree/bindings/net/ethernet-controller.yaml | 2 +-
 Documentation/devicetree/bindings/net/ethernet-switch.yaml     | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/net/ethernet-controller.yaml b/Documentation/devicetree/bindings/net/ethernet-controller.yaml
index 00be387984ac..b7ac69dafbe9 100644
--- a/Documentation/devicetree/bindings/net/ethernet-controller.yaml
+++ b/Documentation/devicetree/bindings/net/ethernet-controller.yaml
@@ -205,7 +205,7 @@ properties:
               duplex is assumed.
 
           pause:
-            $ref: /schemas/types.yaml#definitions/flag
+            $ref: /schemas/types.yaml#/definitions/flag
             description:
               Indicates that pause should be enabled.
 
diff --git a/Documentation/devicetree/bindings/net/ethernet-switch.yaml b/Documentation/devicetree/bindings/net/ethernet-switch.yaml
index a04f8ef744aa..3a9bac7b1b98 100644
--- a/Documentation/devicetree/bindings/net/ethernet-switch.yaml
+++ b/Documentation/devicetree/bindings/net/ethernet-switch.yaml
@@ -51,7 +51,7 @@ additionalProperties: true
 $defs:
   base:
     description: An ethernet switch without any extra port properties
-    $ref: '#/'
+    $ref: '#'
 
     patternProperties:
       "^(ethernet-)?port@[0-9]+$":
-- 
2.39.2
Re: [PATCH] dt-bindings: net: ethernet: Fix JSON pointer references
Posted by patchwork-bot+netdevbpf@kernel.org 2 years, 8 months ago
Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Tue, 18 Apr 2023 10:06:27 -0500 you wrote:
> A JSON pointer reference (the part after the "#") must start with a "/".
> Conversely, references to the entire document must not have a trailing "/"
> and should be just a "#". The existing jsonschema package allows these,
> but coming changes make allowed "$ref" URIs stricter and throw errors on
> these references.
> 
> Signed-off-by: Rob Herring <robh@kernel.org>
> 
> [...]

Here is the summary with links:
  - dt-bindings: net: ethernet: Fix JSON pointer references
    https://git.kernel.org/netdev/net-next/c/84ce730f82df

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html