[PATCH blktests] nvme-rc: Cleanup fcloop resources in reverse order

Daniel Wagner posted 1 patch 2 years, 8 months ago
tests/nvme/rc | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
[PATCH blktests] nvme-rc: Cleanup fcloop resources in reverse order
Posted by Daniel Wagner 2 years, 8 months ago
We need to free the resources in the opposite order as we allocate them.
The deleting the rport first will also free the other resources. When
we try to release lport and tport they are already gone.

Signed-off-by: Daniel Wagner <dwagner@suse.de>
---
 tests/nvme/rc | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tests/nvme/rc b/tests/nvme/rc
index b44239446dcf..ec0cc2d8d8cc 100644
--- a/tests/nvme/rc
+++ b/tests/nvme/rc
@@ -204,10 +204,10 @@ _cleanup_fcloop() {
 	local remote_wwnn="${3:-$def_remote_wwnn}"
 	local remote_wwpn="${4:-$def_remote_wwpn}"
 
-	_nvme_fcloop_del_rport "${local_wwnn}" "${local_wwpn}" \
-			       "${remote_wwnn}" "${remote_wwpn}"
 	_nvme_fcloop_del_tport "${remote_wwnn}" "${remote_wwpn}"
 	_nvme_fcloop_del_lport "${local_wwnn}" "${local_wwpn}"
+	_nvme_fcloop_del_rport "${local_wwnn}" "${local_wwpn}" \
+			       "${remote_wwnn}" "${remote_wwpn}"
 }
 
 _cleanup_nvmet() {
-- 
2.40.0
Re: [PATCH blktests] nvme-rc: Cleanup fcloop resources in reverse order
Posted by Daniel Wagner 2 years, 8 months ago
On Tue, Apr 18, 2023 at 02:32:52PM +0200, Daniel Wagner wrote:
> We need to free the resources in the opposite order as we allocate them.
> The deleting the rport first will also free the other resources. When
> we try to release lport and tport they are already gone.

I found some more ordering issues with fcloop resources.