[v1] net: amd: Fix link leak when verifying config failed

[PATCH] net: amd: Fix link leak when verifying config failed

Posted by Gencen Gan 2 years, 8 months ago

From: Gecen Gan <gangecen@hust.edu.cn>

After failing to verify configuration, it returns directly without 
releasing link, which may cause memory leak.

Signed-off-by: Gecen Gan <gangecen@hust.edu.cn>
---
 drivers/net/ethernet/amd/nmclan_cs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/amd/nmclan_cs.c b/drivers/net/ethernet/amd/nmclan_cs.c
index 823a329a921f..0dd391c84c13 100644
--- a/drivers/net/ethernet/amd/nmclan_cs.c
+++ b/drivers/net/ethernet/amd/nmclan_cs.c
@@ -651,7 +651,7 @@ static int nmclan_config(struct pcmcia_device *link)
  } else {
      pr_notice("mace id not found: %x %x should be 0x40 0x?9\n",
 	  sig[0], sig[1]);
-     return -ENODEV;
+     goto failed;
    }
  }

-- 
2.34.1

Re: [PATCH] net: amd: Fix link leak when verifying config failed

Posted by Jakub Kicinski 2 years, 8 months ago

On Mon, 17 Apr 2023 22:47:50 +0800 Gencen Gan wrote:
> From: Gecen Gan <gangecen@hust.edu.cn>
> 
> After failing to verify configuration, it returns directly without 
> releasing link, which may cause memory leak.
> 
> Signed-off-by: Gecen Gan <gangecen@hust.edu.cn>
> ---
>  drivers/net/ethernet/amd/nmclan_cs.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/amd/nmclan_cs.c b/drivers/net/ethernet/amd/nmclan_cs.c
> index 823a329a921f..0dd391c84c13 100644
> --- a/drivers/net/ethernet/amd/nmclan_cs.c
> +++ b/drivers/net/ethernet/amd/nmclan_cs.c
> @@ -651,7 +651,7 @@ static int nmclan_config(struct pcmcia_device *link)
>   } else {
>       pr_notice("mace id not found: %x %x should be 0x40 0x?9\n",
>  	  sig[0], sig[1]);
> -     return -ENODEV;
> +     goto failed;
>     }
>   }

The patch looks whitespace-damaged, it doesn't apply cleanly.
AFAICT there is one space missing in the indentation.
Probably your email server is doing something funny to it.

--
pw-bot: cr