From: Kamlesh Gurudasani <kamlesh@ti.com>

With latest firmware update, we can no longer control power of SA3UL from
main domain.

Remove power-domains property from the crypto node.

Signed-off-by: Kamlesh Gurudasani <kamlesh@ti.com>
---
 arch/arm64/boot/dts/ti/k3-am62-main.dtsi | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/arm64/boot/dts/ti/k3-am62-main.dtsi b/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
index b3e4857bbbe4..18a6e9ffaf58 100644
--- a/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
@@ -174,7 +174,6 @@ k3_reset: reset-controller {
 	crypto: crypto@40900000 {
 		compatible = "ti,am62-sa3ul";
 		reg = <0x00 0x40900000 0x00 0x1200>;
-		power-domains = <&k3_pds 70 TI_SCI_PD_SHARED>;
 		#address-cells = <2>;
 		#size-cells = <2>;
 		ranges = <0x00 0x40900000 0x00 0x40900000 0x00 0x30000>;
-- 
2.34.1

On 19:03-20230417, kamlesh@ti.com wrote:
> From: Kamlesh Gurudasani <kamlesh@ti.com>
> 
> With latest firmware update, we can no longer control power of SA3UL from
> main domain.

How is this backward compatible?

> 
> Remove power-domains property from the crypto node.
> 
> Signed-off-by: Kamlesh Gurudasani <kamlesh@ti.com>
> ---
>  arch/arm64/boot/dts/ti/k3-am62-main.dtsi | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/ti/k3-am62-main.dtsi b/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
> index b3e4857bbbe4..18a6e9ffaf58 100644
> --- a/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
> @@ -174,7 +174,6 @@ k3_reset: reset-controller {
>  	crypto: crypto@40900000 {
>  		compatible = "ti,am62-sa3ul";
>  		reg = <0x00 0x40900000 0x00 0x1200>;
> -		power-domains = <&k3_pds 70 TI_SCI_PD_SHARED>;
>  		#address-cells = <2>;
>  		#size-cells = <2>;
>  		ranges = <0x00 0x40900000 0x00 0x40900000 0x00 0x30000>;
> -- 
> 2.34.1
> 

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D

On Mon, Apr 17, 2023 at 08:42:41AM -0500, Nishanth Menon wrote:
> On 19:03-20230417, kamlesh@ti.com wrote:
> > From: Kamlesh Gurudasani <kamlesh@ti.com>
> > 
> > With latest firmware update, we can no longer control power of SA3UL from
> > main domain.
> 
> How is this backward compatible?

I just stumbled across this commit since I had an issue with crypto@40900000
not being probed on Verdin AM62.

Not sure how this is supposed to work about backward/forward
compatibility, however this is needed for having it working with the
latest firmware.

And if there is a proper way that take care of this, it should be
backported IMO.

Francesco

On 25/05/23 8:14 pm, Francesco Dolcini wrote:
> On Mon, Apr 17, 2023 at 08:42:41AM -0500, Nishanth Menon wrote:
>> On 19:03-20230417, kamlesh@ti.com wrote:
>>> From: Kamlesh Gurudasani <kamlesh@ti.com>
>>>
>>> With latest firmware update, we can no longer control power of SA3UL from
>>> main domain.
>>
>> How is this backward compatible?
> 
> I just stumbled across this commit since I had an issue with crypto@40900000
> not being probed on Verdin AM62.
> 
> Not sure how this is supposed to work about backward/forward
> compatibility, however this is needed for having it working with the
> latest firmware.
> 

From what I understand, newer firmware seems to hate SA3UL PD control
requests. But older firmwares just ignored the call as the SA3UL PD is
on by default. So as such, this DT patch alone wont break
forward/backward compatibility.

It looks like newer firmware is broken wrt older kernel which is
unfortunate.

Kamlesh: can you resubmit this patch with appropriate "Fixes" tag so
that it gets backported to stable kernels?

> And if there is a proper way that take care of this, it should be
> backported IMO.
> 
> Francesco
>