[v1] ACPI: video: Add backlight=native DMI quirk for Lenovo Ideapad Z470

[PATCH] ACPI: video: Add backlight=native DMI quirk for Lenovo Ideapad Z470

Posted by Jiri Slaby (SUSE) 2 years, 8 months ago

From: Hans de Goede <hdegoede@redhat.com>

The Lenovo Ideapad Z470 predates Windows 8, so it defaults to using
acpi_video for backlight control. But this is not functional on this
model.

Add a DMI quirk to use the native backlight interface which works.

Link: https://bugzilla.suse.com/show_bug.cgi?id=1208724
Signed-off-by: Jiri Slaby (SUSE) <jirislaby@kernel.org>
Cc: Hans de Goede <hdegoede@redhat.com>
Cc: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
---
 drivers/acpi/video_detect.c | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/drivers/acpi/video_detect.c b/drivers/acpi/video_detect.c
index 69ef2d9710c2..af5cea005f54 100644
--- a/drivers/acpi/video_detect.c
+++ b/drivers/acpi/video_detect.c
@@ -459,6 +459,15 @@ static const struct dmi_system_id video_detect_dmi_table[] = {
 		DMI_MATCH(DMI_BOARD_NAME, "Lenovo IdeaPad S405"),
 		},
 	},
+	{
+	 /* https://bugzilla.suse.com/show_bug.cgi?id=1208724 */
+	 .callback = video_detect_force_native,
+	 /* Lenovo Ideapad Z470 */
+	 .matches = {
+		DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
+		DMI_MATCH(DMI_PRODUCT_VERSION, "IdeaPad Z470"),
+		},
+	},
 	{
 	 /* https://bugzilla.redhat.com/show_bug.cgi?id=1187004 */
 	 .callback = video_detect_force_native,
-- 
2.40.0

Re: [PATCH] ACPI: video: Add backlight=native DMI quirk for Lenovo Ideapad Z470

Posted by Rafael J. Wysocki 2 years, 8 months ago

On Mon, Apr 17, 2023 at 12:48 PM Jiri Slaby (SUSE) <jirislaby@kernel.org> wrote:
>
> From: Hans de Goede <hdegoede@redhat.com>
>
> The Lenovo Ideapad Z470 predates Windows 8, so it defaults to using
> acpi_video for backlight control. But this is not functional on this
> model.
>
> Add a DMI quirk to use the native backlight interface which works.
>
> Link: https://bugzilla.suse.com/show_bug.cgi?id=1208724
> Signed-off-by: Jiri Slaby (SUSE) <jirislaby@kernel.org>
> Cc: Hans de Goede <hdegoede@redhat.com>
> Cc: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

Hans, can you please give your S-o-b for this one?

> ---
>  drivers/acpi/video_detect.c | 9 +++++++++
>  1 file changed, 9 insertions(+)
>
> diff --git a/drivers/acpi/video_detect.c b/drivers/acpi/video_detect.c
> index 69ef2d9710c2..af5cea005f54 100644
> --- a/drivers/acpi/video_detect.c
> +++ b/drivers/acpi/video_detect.c
> @@ -459,6 +459,15 @@ static const struct dmi_system_id video_detect_dmi_table[] = {
>                 DMI_MATCH(DMI_BOARD_NAME, "Lenovo IdeaPad S405"),
>                 },
>         },
> +       {
> +        /* https://bugzilla.suse.com/show_bug.cgi?id=1208724 */
> +        .callback = video_detect_force_native,
> +        /* Lenovo Ideapad Z470 */
> +        .matches = {
> +               DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
> +               DMI_MATCH(DMI_PRODUCT_VERSION, "IdeaPad Z470"),
> +               },
> +       },
>         {
>          /* https://bugzilla.redhat.com/show_bug.cgi?id=1187004 */
>          .callback = video_detect_force_native,
> --
> 2.40.0
>

Re: [PATCH] ACPI: video: Add backlight=native DMI quirk for Lenovo Ideapad Z470

Posted by Hans de Goede 2 years, 8 months ago

Hi,

On 4/17/23 13:40, Rafael J. Wysocki wrote:
> On Mon, Apr 17, 2023 at 12:48 PM Jiri Slaby (SUSE) <jirislaby@kernel.org> wrote:
>>
>> From: Hans de Goede <hdegoede@redhat.com>
>>
>> The Lenovo Ideapad Z470 predates Windows 8, so it defaults to using
>> acpi_video for backlight control. But this is not functional on this
>> model.
>>
>> Add a DMI quirk to use the native backlight interface which works.
>>
>> Link: https://bugzilla.suse.com/show_bug.cgi?id=1208724
>> Signed-off-by: Jiri Slaby (SUSE) <jirislaby@kernel.org>
>> Cc: Hans de Goede <hdegoede@redhat.com>
>> Cc: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> 
> Hans, can you please give your S-o-b for this one?

Hmm, I do not believe that I wrote this patch
(also see the suse bugzilla link in the comment it adds) ?

I guess it started as a copy of my "ACPI: video: Add
backlight=native DMI quirk for Acer Aspire 3830TG" patch
and that is why I was kept as the author ?

Anyways I'm fine with me being the author, or with Jiri
being the author. Pick a tag depending on the answer:

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Reviewed-by: Hans de Goede <hdegoede@redhat.com>

Regards,

Hans






> 
>> ---
>>  drivers/acpi/video_detect.c | 9 +++++++++
>>  1 file changed, 9 insertions(+)
>>
>> diff --git a/drivers/acpi/video_detect.c b/drivers/acpi/video_detect.c
>> index 69ef2d9710c2..af5cea005f54 100644
>> --- a/drivers/acpi/video_detect.c
>> +++ b/drivers/acpi/video_detect.c
>> @@ -459,6 +459,15 @@ static const struct dmi_system_id video_detect_dmi_table[] = {
>>                 DMI_MATCH(DMI_BOARD_NAME, "Lenovo IdeaPad S405"),
>>                 },
>>         },
>> +       {
>> +        /* https://bugzilla.suse.com/show_bug.cgi?id=1208724 */
>> +        .callback = video_detect_force_native,
>> +        /* Lenovo Ideapad Z470 */
>> +        .matches = {
>> +               DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
>> +               DMI_MATCH(DMI_PRODUCT_VERSION, "IdeaPad Z470"),
>> +               },
>> +       },
>>         {
>>          /* https://bugzilla.redhat.com/show_bug.cgi?id=1187004 */
>>          .callback = video_detect_force_native,
>> --
>> 2.40.0
>>
>

Re: [PATCH] ACPI: video: Add backlight=native DMI quirk for Lenovo Ideapad Z470

Posted by Jiri Slaby 2 years, 8 months ago

On 17. 04. 23, 15:09, Hans de Goede wrote:
> Hi,
> 
> On 4/17/23 13:40, Rafael J. Wysocki wrote:
>> On Mon, Apr 17, 2023 at 12:48 PM Jiri Slaby (SUSE) <jirislaby@kernel.org> wrote:
>>>
>>> From: Hans de Goede <hdegoede@redhat.com>
>>>
>>> The Lenovo Ideapad Z470 predates Windows 8, so it defaults to using
>>> acpi_video for backlight control. But this is not functional on this
>>> model.
>>>
>>> Add a DMI quirk to use the native backlight interface which works.
>>>
>>> Link: https://bugzilla.suse.com/show_bug.cgi?id=1208724
>>> Signed-off-by: Jiri Slaby (SUSE) <jirislaby@kernel.org>
>>> Cc: Hans de Goede <hdegoede@redhat.com>
>>> Cc: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
>>
>> Hans, can you please give your S-o-b for this one?
> 
> Hmm, I do not believe that I wrote this patch
> (also see the suse bugzilla link in the comment it adds) ?
> 
> I guess it started as a copy of my "ACPI: video: Add
> backlight=native DMI quirk for Acer Aspire 3830TG" patch
> and that is why I was kept as the author ?
> 
> Anyways I'm fine with me being the author, or with Jiri
> being the author. Pick a tag depending on the answer:

Huh, sorry. I forgot to --reset-author. Let me fix this mess up.

Thanks.

> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> Reviewed-by: Hans de Goede <hdegoede@redhat.com>
> 
> Regards,
> 
> Hans
> 
> 
> 
> 
> 
> 
>>
>>> ---
>>>   drivers/acpi/video_detect.c | 9 +++++++++
>>>   1 file changed, 9 insertions(+)
>>>
>>> diff --git a/drivers/acpi/video_detect.c b/drivers/acpi/video_detect.c
>>> index 69ef2d9710c2..af5cea005f54 100644
>>> --- a/drivers/acpi/video_detect.c
>>> +++ b/drivers/acpi/video_detect.c
>>> @@ -459,6 +459,15 @@ static const struct dmi_system_id video_detect_dmi_table[] = {
>>>                  DMI_MATCH(DMI_BOARD_NAME, "Lenovo IdeaPad S405"),
>>>                  },
>>>          },
>>> +       {
>>> +        /* https://bugzilla.suse.com/show_bug.cgi?id=1208724 */
>>> +        .callback = video_detect_force_native,
>>> +        /* Lenovo Ideapad Z470 */
>>> +        .matches = {
>>> +               DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
>>> +               DMI_MATCH(DMI_PRODUCT_VERSION, "IdeaPad Z470"),
>>> +               },
>>> +       },
>>>          {
>>>           /* https://bugzilla.redhat.com/show_bug.cgi?id=1187004 */
>>>           .callback = video_detect_force_native,
>>> --
>>> 2.40.0
>>>
>>
> 

-- 
js