[PATCH 0/9] Add Chameleon v3 ASoC audio

Paweł Anikiel posted 9 patches 2 years, 8 months ago
There is a newer version of this series
.../devicetree/bindings/sound/adi,ssm2602.txt |   4 +
.../bindings/sound/google,chv3-audio.yaml     |  49 +++
.../bindings/sound/google,chv3-i2s.yaml       |  42 +++
.../bindings/sound/ite,it68051.yaml           |  23 ++
.../boot/dts/socfpga_arria10_chameleonv3.dts  |  30 ++
sound/soc/Kconfig                             |   1 +
sound/soc/Makefile                            |   1 +
sound/soc/chameleonv3/Kconfig                 |   7 +
sound/soc/chameleonv3/Makefile                |   2 +
sound/soc/chameleonv3/chv3-audio.c            | 111 ++++++
sound/soc/chameleonv3/chv3-i2s.c              | 347 ++++++++++++++++++
sound/soc/chameleonv3/chv3-it68051.c          |  41 +++
sound/soc/codecs/ssm2602.c                    |  37 +-
13 files changed, 692 insertions(+), 3 deletions(-)
create mode 100644 Documentation/devicetree/bindings/sound/google,chv3-audio.yaml
create mode 100644 Documentation/devicetree/bindings/sound/google,chv3-i2s.yaml
create mode 100644 Documentation/devicetree/bindings/sound/ite,it68051.yaml
create mode 100644 sound/soc/chameleonv3/Kconfig
create mode 100644 sound/soc/chameleonv3/Makefile
create mode 100644 sound/soc/chameleonv3/chv3-audio.c
create mode 100644 sound/soc/chameleonv3/chv3-i2s.c
create mode 100644 sound/soc/chameleonv3/chv3-it68051.c
[PATCH 0/9] Add Chameleon v3 ASoC audio
Posted by Paweł Anikiel 2 years, 8 months ago
The Google Chameleon v3 is a device made for testing audio and video
paths of other devices. This patchset adds support for ASoC audio on
this device. It has two audio sources: HDMI audio from the it68051 chip
(RX only), and analog audio from the ssm2603 chip (RX and TX).

The patchset adds the ASoC platform and machine drivers, as well as some
changes to the existing ssm2602 codec driver.

Paweł Anikiel (9):
  ASoC: Add Chameleon v3 audio
  dt-bindings: ASoC: Add chv3-i2s
  dt-bindings: ASoC: Add chv3-audio
  dt-bindings: ASoC: Add it68051
  ASoC: ssm2602: Add workaround for playback with external MCLK
  ASoC: ssm2602: Add support for CLKDIV2
  ASoC: ssm2602: Add mute gpio
  dt-bindings: ASoC: Add mute-gpio to ssm2602
  ARM: dts: chameleonv3: Add ssm2603 mute gpio

 .../devicetree/bindings/sound/adi,ssm2602.txt |   4 +
 .../bindings/sound/google,chv3-audio.yaml     |  49 +++
 .../bindings/sound/google,chv3-i2s.yaml       |  42 +++
 .../bindings/sound/ite,it68051.yaml           |  23 ++
 .../boot/dts/socfpga_arria10_chameleonv3.dts  |  30 ++
 sound/soc/Kconfig                             |   1 +
 sound/soc/Makefile                            |   1 +
 sound/soc/chameleonv3/Kconfig                 |   7 +
 sound/soc/chameleonv3/Makefile                |   2 +
 sound/soc/chameleonv3/chv3-audio.c            | 111 ++++++
 sound/soc/chameleonv3/chv3-i2s.c              | 347 ++++++++++++++++++
 sound/soc/chameleonv3/chv3-it68051.c          |  41 +++
 sound/soc/codecs/ssm2602.c                    |  37 +-
 13 files changed, 692 insertions(+), 3 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/sound/google,chv3-audio.yaml
 create mode 100644 Documentation/devicetree/bindings/sound/google,chv3-i2s.yaml
 create mode 100644 Documentation/devicetree/bindings/sound/ite,it68051.yaml
 create mode 100644 sound/soc/chameleonv3/Kconfig
 create mode 100644 sound/soc/chameleonv3/Makefile
 create mode 100644 sound/soc/chameleonv3/chv3-audio.c
 create mode 100644 sound/soc/chameleonv3/chv3-i2s.c
 create mode 100644 sound/soc/chameleonv3/chv3-it68051.c

-- 
2.40.0.634.g4ca3ef3211-goog

Re: [PATCH 0/9] Add Chameleon v3 ASoC audio
Posted by Mark Brown 2 years, 8 months ago
On Fri, Apr 14, 2023 at 04:01:54PM +0200, Paweł Anikiel wrote:

>  sound/soc/Makefile                            |   1 +
>  sound/soc/chameleonv3/Kconfig                 |   7 +
>  sound/soc/chameleonv3/Makefile                |   2 +
>  sound/soc/chameleonv3/chv3-audio.c            | 111 ++++++
>  sound/soc/chameleonv3/chv3-i2s.c              | 347 ++++++++++++++++++
>  sound/soc/chameleonv3/chv3-it68051.c          |  41 +++

Please at least make a directory for Google as a vendor, we don't want
people adding directories for each individual product.  That said
generally we add machine drivers in the directory for the relevant SoC
family, is there any reason that pattern isn't followed here?
Re: [PATCH 0/9] Add Chameleon v3 ASoC audio
Posted by Paweł Anikiel 2 years, 7 months ago
On Fri, Apr 14, 2023 at 6:47 PM Mark Brown <broonie@kernel.org> wrote:
>
> On Fri, Apr 14, 2023 at 04:01:54PM +0200, Paweł Anikiel wrote:
>
> >  sound/soc/Makefile                            |   1 +
> >  sound/soc/chameleonv3/Kconfig                 |   7 +
> >  sound/soc/chameleonv3/Makefile                |   2 +
> >  sound/soc/chameleonv3/chv3-audio.c            | 111 ++++++
> >  sound/soc/chameleonv3/chv3-i2s.c              | 347 ++++++++++++++++++
> >  sound/soc/chameleonv3/chv3-it68051.c          |  41 +++
>
> Please at least make a directory for Google as a vendor, we don't want
> people adding directories for each individual product. That said
> generally we add machine drivers in the directory for the relevant SoC
> family, is there any reason that pattern isn't followed here?

The board is based around an Intel Arria 10 SoC FPGA. The ring buffer
device and all the routing is implemented inside the FPGA. Is it ok to
put the machine driver in the product directory in this case?. As for
the directory path, would sound/soc/google/chameleonv3/* be ok?

Regards,
Paweł
Re: [PATCH 0/9] Add Chameleon v3 ASoC audio
Posted by Mark Brown 2 years, 7 months ago
On Tue, Apr 25, 2023 at 05:58:59PM +0200, Paweł Anikiel wrote:

> > Please at least make a directory for Google as a vendor, we don't want
> > people adding directories for each individual product. That said
> > generally we add machine drivers in the directory for the relevant SoC
> > family, is there any reason that pattern isn't followed here?

> The board is based around an Intel Arria 10 SoC FPGA. The ring buffer
> device and all the routing is implemented inside the FPGA. Is it ok to
> put the machine driver in the product directory in this case?. As for
> the directory path, would sound/soc/google/chameleonv3/* be ok?

Does the individual product really need a directory - nobody's going to
reuse the IP on the FPGA for anything?
Re: (subset) [PATCH 0/9] Add Chameleon v3 ASoC audio
Posted by Mark Brown 2 years, 8 months ago
On Fri, 14 Apr 2023 16:01:54 +0200, Paweł Anikiel wrote:
> The Google Chameleon v3 is a device made for testing audio and video
> paths of other devices. This patchset adds support for ASoC audio on
> this device. It has two audio sources: HDMI audio from the it68051 chip
> (RX only), and analog audio from the ssm2603 chip (RX and TX).
> 
> The patchset adds the ASoC platform and machine drivers, as well as some
> changes to the existing ssm2602 codec driver.
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[6/9] ASoC: ssm2602: Add support for CLKDIV2
      commit: 8076c586bbc1c62e075e58f41dafdd8b5022b24d

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark