[PATCH v2 0/5] arm64: dts: ti: k3-j7200-som-p0: Add TP6594 family PMICs

Esteban Blanc posted 5 patches 2 years, 8 months ago
arch/arm64/boot/dts/ti/k3-am62a7-sk.dts      |  95 +++++++++
arch/arm64/boot/dts/ti/k3-j7200-som-p0.dtsi  | 175 +++++++++++++++
arch/arm64/boot/dts/ti/k3-j721e-som-p0.dtsi  | 171 +++++++++++++++
arch/arm64/boot/dts/ti/k3-j721s2-som-p0.dtsi | 213 +++++++++++++++++++
arch/arm64/boot/dts/ti/k3-j784s4-evm.dts     | 116 ++++++++++
5 files changed, 770 insertions(+)
[PATCH v2 0/5] arm64: dts: ti: k3-j7200-som-p0: Add TP6594 family PMICs
Posted by Esteban Blanc 2 years, 8 months ago
TPS6594 is a Power Management IC which provides regulators and others
features like GPIOs, RTC, watchdog, ESMs (Error Signal Monitor), and
PFSM (Pre-configurable Finite State Machine). The SoC and the PMIC can
communicate through the I2C or SPI interfaces.
TPS6594 is the super-set device while TPS6593 and LP8764 are derivatives.

This should be applied on top of other patch series:
- https://lore.kernel.org/all/20230406075622.8990-1-jpanis@baylibre.com/
  For core MFD driver
- https://lore.kernel.org/lkml/20230414101217.1342891-1-eblanc@baylibre.com/
  For regulator driver

This serie adds device tree nodes for TI TPS6594 PMICs found in the
following boards:
- J721EXSOMXEVM:
  Link: https://www.ti.com/tool/J721EXSOMXEVM
- J721S2XSOMXEVM:
  Link: https://www.ti.com/tool/J721S2XSOMXEVM
- J7200XSOMXEVM:
  Link: https://www.ti.com/tool/J7200XSOMXEVM
- AM62A-SKEVM:
  Link: https://www.ti.com/tool/SK-AM62A-LP
- J784S4XEVM
  Link: https://www.ti.com/tool/J784S4XEVM

Changes since v1:
https://lore.kernel.org/lkml/20230329142948.833800-1-eblanc@baylibre.com/
- Harmonize regulators names across the different boards
- Adjust AVS voltage range
- Remove some outdated comments

Esteban Blanc (2):
  arm64: dts: ti: k3-j7200-som-p0: Add TP6594 family PMICs
  arm64: dts: ti: k3-j721s2-som-p0: Add TP6594 family PMICs

Jerome Neanne (2):
  arm64: dts: ti: k3-j721e-som-p0: Add TP6594 family PMICs
  arm64: dts: ti: k3-j784s4-evm: Add support for TPS6593 PMIC

Julien Panis (1):
  arm64: dts: ti: k3-am62a7-sk: Add support for TPS6593 PMIC

 arch/arm64/boot/dts/ti/k3-am62a7-sk.dts      |  95 +++++++++
 arch/arm64/boot/dts/ti/k3-j7200-som-p0.dtsi  | 175 +++++++++++++++
 arch/arm64/boot/dts/ti/k3-j721e-som-p0.dtsi  | 171 +++++++++++++++
 arch/arm64/boot/dts/ti/k3-j721s2-som-p0.dtsi | 213 +++++++++++++++++++
 arch/arm64/boot/dts/ti/k3-j784s4-evm.dts     | 116 ++++++++++
 5 files changed, 770 insertions(+)

-- 
2.39.2
Re: [PATCH v2 0/5] arm64: dts: ti: k3-j7200-som-p0: Add TP6594 family PMICs
Posted by Krzysztof Kozlowski 2 years, 8 months ago
On 14/04/2023 13:28, Esteban Blanc wrote:
> TPS6594 is a Power Management IC which provides regulators and others
> features like GPIOs, RTC, watchdog, ESMs (Error Signal Monitor), and
> PFSM (Pre-configurable Finite State Machine). The SoC and the PMIC can
> communicate through the I2C or SPI interfaces.
> TPS6594 is the super-set device while TPS6593 and LP8764 are derivatives.
> 
> This should be applied on top of other patch series:
> - https://lore.kernel.org/all/20230406075622.8990-1-jpanis@baylibre.com/
>   For core MFD driver
> - https://lore.kernel.org/lkml/20230414101217.1342891-1-eblanc@baylibre.com/
>   For regulator driver

Why? DTS cannot be merged with drivers, so if you insist on such
dependency then:
1. Your patchset is broken,
2. I actually does not understand why,
3. NAK - don't merge DTS into driver branches.

You probably are misunderstanding branches and dependencies.

Best regards,
Krzysztof
Re: [PATCH v2 0/5] arm64: dts: ti: k3-j7200-som-p0: Add TP6594 family PMICs
Posted by Esteban Blanc 2 years, 8 months ago
On Fri Apr 14, 2023 at 1:36 PM CEST, Krzysztof Kozlowski wrote:
> On 14/04/2023 13:28, Esteban Blanc wrote:
> > TPS6594 is a Power Management IC which provides regulators and others
> > features like GPIOs, RTC, watchdog, ESMs (Error Signal Monitor), and
> > PFSM (Pre-configurable Finite State Machine). The SoC and the PMIC can
> > communicate through the I2C or SPI interfaces.
> > TPS6594 is the super-set device while TPS6593 and LP8764 are derivatives.
> > 
> > This should be applied on top of other patch series:
> > - https://lore.kernel.org/all/20230406075622.8990-1-jpanis@baylibre.com/
> >   For core MFD driver
> > - https://lore.kernel.org/lkml/20230414101217.1342891-1-eblanc@baylibre.com/
> >   For regulator driver
>
> Why? DTS cannot be merged with drivers, so if you insist on such
> dependency then:
> 1. Your patchset is broken,
> 2. I actually does not understand why,
> 3. NAK - don't merge DTS into driver branches.
>
> You probably are misunderstanding branches and dependencies.

There is no dependency indeed. We thought that dt-bindings patch at least had
to be applied before this DT series even if it is not a 'dependency', the other
link was a mistake. I will remove these misleading links in next cover-letter.

Thanks for your time. Best regards,

-- 
Esteban Blanc
BayLibre
Re: [PATCH v2 0/5] arm64: dts: ti: k3-j7200-som-p0: Add TP6594 family PMICs
Posted by Nishanth Menon 2 years, 8 months ago
On 13:28-20230414, Esteban Blanc wrote:
> TPS6594 is a Power Management IC which provides regulators and others
> features like GPIOs, RTC, watchdog, ESMs (Error Signal Monitor), and
> PFSM (Pre-configurable Finite State Machine). The SoC and the PMIC can
> communicate through the I2C or SPI interfaces.
> TPS6594 is the super-set device while TPS6593 and LP8764 are derivatives.
> 
> This should be applied on top of other patch series:
> - https://lore.kernel.org/all/20230406075622.8990-1-jpanis@baylibre.com/
>   For core MFD driver
> - https://lore.kernel.org/lkml/20230414101217.1342891-1-eblanc@baylibre.com/
>   For regulator driver
> 

https://lore.kernel.org/lkml/20230330030046.qr5dnft6klejkxkp@ungreased/

has anything changed?
-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D
Re: [PATCH v2 0/5] arm64: dts: ti: k3-j7200-som-p0: Add TP6594 family PMICs
Posted by Esteban Blanc 2 years, 8 months ago
On Fri Apr 14, 2023 at 8:05 PM CEST, Nishanth Menon wrote:
> On 13:28-20230414, Esteban Blanc wrote:
> > TPS6594 is a Power Management IC which provides regulators and others
> > features like GPIOs, RTC, watchdog, ESMs (Error Signal Monitor), and
> > PFSM (Pre-configurable Finite State Machine). The SoC and the PMIC can
> > communicate through the I2C or SPI interfaces.
> > TPS6594 is the super-set device while TPS6593 and LP8764 are derivatives.
> > 
> > This should be applied on top of other patch series:
> > - https://lore.kernel.org/all/20230406075622.8990-1-jpanis@baylibre.com/
> >   For core MFD driver
> > - https://lore.kernel.org/lkml/20230414101217.1342891-1-eblanc@baylibre.com/
> >   For regulator driver
> > 
>
> https://lore.kernel.org/lkml/20230330030046.qr5dnft6klejkxkp@ungreased/
>
> has anything changed?

Yes:
- Harmonize regulators names across the different boards
- Adjust AVS voltage range
- Remove some outdated comments
- Add PMICs to J784S4 board
- Compatible string modified to match dt-bindings
- Add gpio-controller and gpio-cells properties

I missed a few of theses on the cover letter, sorry about that.

Best regards,

-- 
Esteban Blanc
BayLibre
Re: [PATCH v2 0/5] arm64: dts: ti: k3-j7200-som-p0: Add TP6594 family PMICs
Posted by Nishanth Menon 2 years, 8 months ago
On 12:01-20230417, Esteban Blanc wrote:
> On Fri Apr 14, 2023 at 8:05 PM CEST, Nishanth Menon wrote:
> > On 13:28-20230414, Esteban Blanc wrote:
> > > TPS6594 is a Power Management IC which provides regulators and others
> > > features like GPIOs, RTC, watchdog, ESMs (Error Signal Monitor), and
> > > PFSM (Pre-configurable Finite State Machine). The SoC and the PMIC can
> > > communicate through the I2C or SPI interfaces.
> > > TPS6594 is the super-set device while TPS6593 and LP8764 are derivatives.
> > > 
> > > This should be applied on top of other patch series:
> > > - https://lore.kernel.org/all/20230406075622.8990-1-jpanis@baylibre.com/
> > >   For core MFD driver
> > > - https://lore.kernel.org/lkml/20230414101217.1342891-1-eblanc@baylibre.com/
> > >   For regulator driver
> > > 
> >
> > https://lore.kernel.org/lkml/20230330030046.qr5dnft6klejkxkp@ungreased/
> >
> > has anything changed?
> 
> Yes:
> - Harmonize regulators names across the different boards
> - Adjust AVS voltage range
> - Remove some outdated comments
> - Add PMICs to J784S4 board
> - Compatible string modified to match dt-bindings
> - Add gpio-controller and gpio-cells properties
> 
> I missed a few of theses on the cover letter, sorry about that.

The bindings and drivers need to reach kernel.org master branch first, if
they are in by rc1, then the dts patches can be picked in.

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D