drivers/clk/mediatek/clk-mt8173-apmixedsys.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Use devm_platform_ioremap_resource to take the place of of_iomap for
avoid that we don't called iounmap when return some error or remove
device.
Signed-off-by: Hao Ge <gehao@kylinos.cn>
---
drivers/clk/mediatek/clk-mt8173-apmixedsys.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/clk/mediatek/clk-mt8173-apmixedsys.c b/drivers/clk/mediatek/clk-mt8173-apmixedsys.c
index a56c5845d07a..fe386bf8225d 100644
--- a/drivers/clk/mediatek/clk-mt8173-apmixedsys.c
+++ b/drivers/clk/mediatek/clk-mt8173-apmixedsys.c
@@ -90,7 +90,7 @@ static int clk_mt8173_apmixed_probe(struct platform_device *pdev)
struct clk_hw *hw;
int r;
- base = of_iomap(node, 0);
+ base = devm_platform_ioremap_resource(pdev, 0);
if (!base)
return PTR_ERR(base);
--
2.25.1
No virus found
Checked by Hillstone Network AntiVirus
Quoting Hao Ge (2023-04-13 02:01:28) > diff --git a/drivers/clk/mediatek/clk-mt8173-apmixedsys.c b/drivers/clk/mediatek/clk-mt8173-apmixedsys.c > index a56c5845d07a..fe386bf8225d 100644 > --- a/drivers/clk/mediatek/clk-mt8173-apmixedsys.c > +++ b/drivers/clk/mediatek/clk-mt8173-apmixedsys.c > @@ -90,7 +90,7 @@ static int clk_mt8173_apmixed_probe(struct platform_device *pdev) > struct clk_hw *hw; > int r; > > - base = of_iomap(node, 0); > + base = devm_platform_ioremap_resource(pdev, 0); > if (!base) This needs to be updated. > return PTR_ERR(base); And PTR_ERR(NULL) is 0, which is wrong.
On 4/14/23 02:40, Stephen Boyd wrote: > Quoting Hao Ge (2023-04-13 02:01:28) >> diff --git a/drivers/clk/mediatek/clk-mt8173-apmixedsys.c b/drivers/clk/mediatek/clk-mt8173-apmixedsys.c >> index a56c5845d07a..fe386bf8225d 100644 >> --- a/drivers/clk/mediatek/clk-mt8173-apmixedsys.c >> +++ b/drivers/clk/mediatek/clk-mt8173-apmixedsys.c >> @@ -90,7 +90,7 @@ static int clk_mt8173_apmixed_probe(struct platform_device *pdev) >> struct clk_hw *hw; >> int r; >> >> - base = of_iomap(node, 0); >> + base = devm_platform_ioremap_resource(pdev, 0); >> if (!base) > > This needs to be updated. > >> return PTR_ERR(base); > > And PTR_ERR(NULL) is 0, which is wrong. Thank you for pointing out this point and Sorry for the late reply. I will update the v2 for it. Best regards. Hao
Use devm_platform_ioremap_resource to take the place of of_iomap for
avoid that we don't called iounmap when return some error or remove
device.
Signed-off-by: Hao Ge <gehao@kylinos.cn>
Suggested-by: Stephen Boyd <sboyd@kernel.org>
---
v2: fix error handle condition for devm_platform_ioremap_resource
---
drivers/clk/mediatek/clk-mt8173-apmixedsys.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/clk/mediatek/clk-mt8173-apmixedsys.c b/drivers/clk/mediatek/clk-mt8173-apmixedsys.c
index a56c5845d07a..73c29d1dccc6 100644
--- a/drivers/clk/mediatek/clk-mt8173-apmixedsys.c
+++ b/drivers/clk/mediatek/clk-mt8173-apmixedsys.c
@@ -90,8 +90,8 @@ static int clk_mt8173_apmixed_probe(struct platform_device *pdev)
struct clk_hw *hw;
int r;
- base = of_iomap(node, 0);
- if (!base)
+ base = devm_platform_ioremap_resource(pdev, 0);
+ if (IS_ERR(base))
return PTR_ERR(base);
clk_data = mtk_alloc_clk_data(CLK_APMIXED_NR_CLK);
--
2.25.1
No virus found
Checked by Hillstone Network AntiVirus
© 2016 - 2024 Red Hat, Inc.