Add a compatible string for MediaTek Helio X10 MT6795's display PWM
block: this is the same as MT8173.
Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
---
Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml b/Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml
index 0088bc8e7c54..153e146df7d4 100644
--- a/Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml
+++ b/Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml
@@ -22,7 +22,9 @@ properties:
- mediatek,mt8173-disp-pwm
- mediatek,mt8183-disp-pwm
- items:
- - const: mediatek,mt8167-disp-pwm
+ - enum:
+ - mediatek,mt6795-disp-pwm
+ - mediatek,mt8167-disp-pwm
- const: mediatek,mt8173-disp-pwm
- items:
- enum:
--
2.40.0On 12/04/2023 13:27, AngeloGioacchino Del Regno wrote: > Add a compatible string for MediaTek Helio X10 MT6795's display PWM > block: this is the same as MT8173. > > Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> Applied, thanks! > --- > Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml b/Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml > index 0088bc8e7c54..153e146df7d4 100644 > --- a/Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml > +++ b/Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml > @@ -22,7 +22,9 @@ properties: > - mediatek,mt8173-disp-pwm > - mediatek,mt8183-disp-pwm > - items: > - - const: mediatek,mt8167-disp-pwm > + - enum: > + - mediatek,mt6795-disp-pwm > + - mediatek,mt8167-disp-pwm > - const: mediatek,mt8173-disp-pwm > - items: > - enum:
On 12/04/2023 13:27, AngeloGioacchino Del Regno wrote: > Add a compatible string for MediaTek Helio X10 MT6795's display PWM > block: this is the same as MT8173. > > Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On 12/04/2023 13:27, AngeloGioacchino Del Regno wrote: > Add a compatible string for MediaTek Helio X10 MT6795's display PWM > block: this is the same as MT8173. > > Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> > --- > Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml b/Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml > index 0088bc8e7c54..153e146df7d4 100644 > --- a/Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml > +++ b/Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml > @@ -22,7 +22,9 @@ properties: > - mediatek,mt8173-disp-pwm > - mediatek,mt8183-disp-pwm > - items: > - - const: mediatek,mt8167-disp-pwm > + - enum: > + - mediatek,mt6795-disp-pwm > + - mediatek,mt8167-disp-pwm This does not look correct. You do not add compatible, you replace breaking all mt8167-disp-pwm. At least it looks like this from context. Best regards, Krzysztof
On Fri, Apr 14, 2023 at 10:21:05AM +0200, Krzysztof Kozlowski wrote: > On 12/04/2023 13:27, AngeloGioacchino Del Regno wrote: > > Add a compatible string for MediaTek Helio X10 MT6795's display PWM > > block: this is the same as MT8173. > > > > Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> > > --- > > Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml b/Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml > > index 0088bc8e7c54..153e146df7d4 100644 > > --- a/Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml > > +++ b/Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml > > @@ -22,7 +22,9 @@ properties: > > - mediatek,mt8173-disp-pwm > > - mediatek,mt8183-disp-pwm > > - items: > > - - const: mediatek,mt8167-disp-pwm > > + - enum: > > + - mediatek,mt6795-disp-pwm > > + - mediatek,mt8167-disp-pwm > > This does not look correct. You do not add compatible, you replace > breaking all mt8167-disp-pwm. At least it looks like this from context. I thought the old semantic to be: "mediatek,mt8167-disp-pwm" and the new "mediatek,mt6795-disp-pwm" or "mediatek,mt8167-disp-pwm" . What am I missing? Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | https://www.pengutronix.de/ |
On 14/04/2023 10:30, Uwe Kleine-König wrote: > On Fri, Apr 14, 2023 at 10:21:05AM +0200, Krzysztof Kozlowski wrote: >> On 12/04/2023 13:27, AngeloGioacchino Del Regno wrote: >>> Add a compatible string for MediaTek Helio X10 MT6795's display PWM >>> block: this is the same as MT8173. >>> >>> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> >>> --- >>> Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml | 4 +++- >>> 1 file changed, 3 insertions(+), 1 deletion(-) >>> >>> diff --git a/Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml b/Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml >>> index 0088bc8e7c54..153e146df7d4 100644 >>> --- a/Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml >>> +++ b/Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml >>> @@ -22,7 +22,9 @@ properties: >>> - mediatek,mt8173-disp-pwm >>> - mediatek,mt8183-disp-pwm >>> - items: >>> - - const: mediatek,mt8167-disp-pwm >>> + - enum: >>> + - mediatek,mt6795-disp-pwm >>> + - mediatek,mt8167-disp-pwm >> >> This does not look correct. You do not add compatible, you replace >> breaking all mt8167-disp-pwm. At least it looks like this from context. > > I thought the old semantic to be: > > "mediatek,mt8167-disp-pwm" > > and the new > > "mediatek,mt6795-disp-pwm" or "mediatek,mt8167-disp-pwm" > > . What am I missing? The new is ok for mt6795 but it is not valid for mt8167. Best regards, Krzysztof
Il 14/04/23 10:34, Krzysztof Kozlowski ha scritto:
> On 14/04/2023 10:30, Uwe Kleine-König wrote:
>> On Fri, Apr 14, 2023 at 10:21:05AM +0200, Krzysztof Kozlowski wrote:
>>> On 12/04/2023 13:27, AngeloGioacchino Del Regno wrote:
>>>> Add a compatible string for MediaTek Helio X10 MT6795's display PWM
>>>> block: this is the same as MT8173.
>>>>
>>>> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
>>>> ---
>>>> Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml | 4 +++-
>>>> 1 file changed, 3 insertions(+), 1 deletion(-)
>>>>
>>>> diff --git a/Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml b/Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml
>>>> index 0088bc8e7c54..153e146df7d4 100644
>>>> --- a/Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml
>>>> +++ b/Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml
>>>> @@ -22,7 +22,9 @@ properties:
>>>> - mediatek,mt8173-disp-pwm
>>>> - mediatek,mt8183-disp-pwm
>>>> - items:
>>>> - - const: mediatek,mt8167-disp-pwm
>>>> + - enum:
>>>> + - mediatek,mt6795-disp-pwm
>>>> + - mediatek,mt8167-disp-pwm
>>>
>>> This does not look correct. You do not add compatible, you replace
>>> breaking all mt8167-disp-pwm. At least it looks like this from context.
>>
>> I thought the old semantic to be:
>>
>> "mediatek,mt8167-disp-pwm"
>>
>> and the new
>>
>> "mediatek,mt6795-disp-pwm" or "mediatek,mt8167-disp-pwm"
>>
>> . What am I missing?
>
> The new is ok for mt6795 but it is not valid for mt8167.
>
Sorry, why is it not valid for MT8167?
This is changing the doc from:
OLD:
- items:
- const: mediatek,mt8167-disp-pwm
- const: mediatek,mt8173-disp-pwm
NEW:
- items:
- enum:
- mediatek,mt6795-disp-pwm
- mediatek,mt8167-disp-pwm
- const: mediatek,mt8173-disp-pwm
For me, that's totally valid, as the old semantic was:
compatible = "mediatek,mt8167-disp-pwm", "mediatek,mt8173-disp-pwm";
...and the new semantic is .. the same; this commit only *adds* the
possibility to get a
compatible = "mediatek,mt6795-disp-pwm", "mediatek,mt8173-disp-pwm";
without breaking anything.
Regards,
Angelo
On 14/04/2023 12:25, AngeloGioacchino Del Regno wrote: > Il 14/04/23 10:34, Krzysztof Kozlowski ha scritto: >> On 14/04/2023 10:30, Uwe Kleine-König wrote: >>> On Fri, Apr 14, 2023 at 10:21:05AM +0200, Krzysztof Kozlowski wrote: >>>> On 12/04/2023 13:27, AngeloGioacchino Del Regno wrote: >>>>> Add a compatible string for MediaTek Helio X10 MT6795's display PWM >>>>> block: this is the same as MT8173. >>>>> >>>>> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> >>>>> --- >>>>> Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml | 4 +++- >>>>> 1 file changed, 3 insertions(+), 1 deletion(-) >>>>> >>>>> diff --git a/Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml b/Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml >>>>> index 0088bc8e7c54..153e146df7d4 100644 >>>>> --- a/Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml >>>>> +++ b/Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml >>>>> @@ -22,7 +22,9 @@ properties: >>>>> - mediatek,mt8173-disp-pwm >>>>> - mediatek,mt8183-disp-pwm >>>>> - items: >>>>> - - const: mediatek,mt8167-disp-pwm >>>>> + - enum: >>>>> + - mediatek,mt6795-disp-pwm >>>>> + - mediatek,mt8167-disp-pwm >>>> >>>> This does not look correct. You do not add compatible, you replace >>>> breaking all mt8167-disp-pwm. At least it looks like this from context. >>> >>> I thought the old semantic to be: >>> >>> "mediatek,mt8167-disp-pwm" >>> >>> and the new >>> >>> "mediatek,mt6795-disp-pwm" or "mediatek,mt8167-disp-pwm" >>> >>> . What am I missing? >> >> The new is ok for mt6795 but it is not valid for mt8167. >> > > Sorry, why is it not valid for MT8167? Eh, above example did not help me, because it missed mt8173, but I see now the context I missed. It's already a list of two compatibles, so the patch is fine. Best regards, Krzysztof
Hello, On Wed, Apr 12, 2023 at 01:27:13PM +0200, AngeloGioacchino Del Regno wrote: > Add a compatible string for MediaTek Helio X10 MT6795's display PWM > block: this is the same as MT8173. > > Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> I assume this patch will go in together with the other patches in this series via an ARM tree? (I.e. not via pwm.) Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | https://www.pengutronix.de/ |
On 14/04/2023 07:43, Uwe Kleine-König wrote: > Hello, > > On Wed, Apr 12, 2023 at 01:27:13PM +0200, AngeloGioacchino Del Regno wrote: >> Add a compatible string for MediaTek Helio X10 MT6795's display PWM >> block: this is the same as MT8173. >> >> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> > > Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> > > I assume this patch will go in together with the other patches in this > series via an ARM tree? (I.e. not via pwm.) > That's totally fine, I'll take this patch through my tree once everything is ready. Regards, Matthias
On Wed, 12 Apr 2023 13:27:13 +0200, AngeloGioacchino Del Regno wrote: > Add a compatible string for MediaTek Helio X10 MT6795's display PWM > block: this is the same as MT8173. > > Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> > --- > Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > Running 'make dtbs_check' with the schema in this patch gives the following warnings. Consider if they are expected or the schema is incorrect. These may not be new warnings. Note that it is not yet a requirement to have 0 warnings for dtbs_check. This will change in the future. Full log is available here: https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230412112739.160376-2-angelogioacchino.delregno@collabora.com pwm@1100e000: 'power-domains' does not match any of the regexes: 'pinctrl-[0-9]+' arch/arm64/boot/dts/mediatek/mt8183-evb.dtb arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-burnet.dtb arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-cozmo.dtb arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-damu.dtb arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel14.dtb arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel14-sku2.dtb arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku1.dtb arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku6.dtb arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku7.dtb arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-juniper-sku16.dtb arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-kappa.dtb arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-kenzo.dtb arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-willow-sku0.dtb arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-willow-sku1.dtb arch/arm64/boot/dts/mediatek/mt8183-kukui-kakadu.dtb arch/arm64/boot/dts/mediatek/mt8183-kukui-kakadu-sku22.dtb arch/arm64/boot/dts/mediatek/mt8183-kukui-kodama-sku16.dtb arch/arm64/boot/dts/mediatek/mt8183-kukui-kodama-sku272.dtb arch/arm64/boot/dts/mediatek/mt8183-kukui-kodama-sku288.dtb arch/arm64/boot/dts/mediatek/mt8183-kukui-kodama-sku32.dtb arch/arm64/boot/dts/mediatek/mt8183-kukui-krane-sku0.dtb arch/arm64/boot/dts/mediatek/mt8183-kukui-krane-sku176.dtb arch/arm64/boot/dts/mediatek/mt8183-pumpkin.dtb pwm@1400a000: compatible: 'oneOf' conditional failed, one must be fixed: arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dtb arch/arm/boot/dts/mt7623n-rfb-emmc.dtb pwm@1401e000: compatible: 'oneOf' conditional failed, one must be fixed: arch/arm64/boot/dts/mediatek/mt8173-elm.dtb arch/arm64/boot/dts/mediatek/mt8173-elm-hana.dtb arch/arm64/boot/dts/mediatek/mt8173-elm-hana-rev7.dtb arch/arm64/boot/dts/mediatek/mt8173-evb.dtb pwm@1401f000: compatible: 'oneOf' conditional failed, one must be fixed: arch/arm64/boot/dts/mediatek/mt8173-elm.dtb arch/arm64/boot/dts/mediatek/mt8173-elm-hana.dtb arch/arm64/boot/dts/mediatek/mt8173-elm-hana-rev7.dtb arch/arm64/boot/dts/mediatek/mt8173-evb.dtb
On 12/04/2023 23:03, Rob Herring wrote: > > On Wed, 12 Apr 2023 13:27:13 +0200, AngeloGioacchino Del Regno wrote: >> Add a compatible string for MediaTek Helio X10 MT6795's display PWM >> block: this is the same as MT8173. >> >> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> >> --- >> Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml | 4 +++- >> 1 file changed, 3 insertions(+), 1 deletion(-) >> > > Running 'make dtbs_check' with the schema in this patch gives the > following warnings. Consider if they are expected or the schema is > incorrect. These may not be new warnings. > These are not new warnings. I think we should address them in a different patch. In my opinion it shouldn't block this patch. In the end it only add as compatible here. Regards, Matthias > Note that it is not yet a requirement to have 0 warnings for dtbs_check. > This will change in the future. > > Full log is available here: https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230412112739.160376-2-angelogioacchino.delregno@collabora.com > > > pwm@1100e000: 'power-domains' does not match any of the regexes: 'pinctrl-[0-9]+' > arch/arm64/boot/dts/mediatek/mt8183-evb.dtb > arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-burnet.dtb > arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-cozmo.dtb > arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-damu.dtb > arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel14.dtb > arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel14-sku2.dtb > arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku1.dtb > arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku6.dtb > arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku7.dtb > arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-juniper-sku16.dtb > arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-kappa.dtb > arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-kenzo.dtb > arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-willow-sku0.dtb > arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-willow-sku1.dtb > arch/arm64/boot/dts/mediatek/mt8183-kukui-kakadu.dtb > arch/arm64/boot/dts/mediatek/mt8183-kukui-kakadu-sku22.dtb > arch/arm64/boot/dts/mediatek/mt8183-kukui-kodama-sku16.dtb > arch/arm64/boot/dts/mediatek/mt8183-kukui-kodama-sku272.dtb > arch/arm64/boot/dts/mediatek/mt8183-kukui-kodama-sku288.dtb > arch/arm64/boot/dts/mediatek/mt8183-kukui-kodama-sku32.dtb > arch/arm64/boot/dts/mediatek/mt8183-kukui-krane-sku0.dtb > arch/arm64/boot/dts/mediatek/mt8183-kukui-krane-sku176.dtb > arch/arm64/boot/dts/mediatek/mt8183-pumpkin.dtb > > pwm@1400a000: compatible: 'oneOf' conditional failed, one must be fixed: > arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dtb > arch/arm/boot/dts/mt7623n-rfb-emmc.dtb > > pwm@1401e000: compatible: 'oneOf' conditional failed, one must be fixed: > arch/arm64/boot/dts/mediatek/mt8173-elm.dtb > arch/arm64/boot/dts/mediatek/mt8173-elm-hana.dtb > arch/arm64/boot/dts/mediatek/mt8173-elm-hana-rev7.dtb > arch/arm64/boot/dts/mediatek/mt8173-evb.dtb > > pwm@1401f000: compatible: 'oneOf' conditional failed, one must be fixed: > arch/arm64/boot/dts/mediatek/mt8173-elm.dtb > arch/arm64/boot/dts/mediatek/mt8173-elm-hana.dtb > arch/arm64/boot/dts/mediatek/mt8173-elm-hana-rev7.dtb > arch/arm64/boot/dts/mediatek/mt8173-evb.dtb >
On Thu, Apr 13, 2023 at 10:52:28AM +0200, Matthias Brugger wrote: > > > On 12/04/2023 23:03, Rob Herring wrote: > > > > On Wed, 12 Apr 2023 13:27:13 +0200, AngeloGioacchino Del Regno wrote: > > > Add a compatible string for MediaTek Helio X10 MT6795's display PWM > > > block: this is the same as MT8173. > > > > > > Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> > > > --- > > > Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml | 4 +++- > > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > > > > Running 'make dtbs_check' with the schema in this patch gives the > > following warnings. Consider if they are expected or the schema is > > incorrect. These may not be new warnings. > > > > These are not new warnings. I think we should address them in a different > patch. In my opinion it shouldn't block this patch. In the end it only add > as compatible here. I disagree if it's the schema that needs fixing. From the looks of it, I'd say it's probably at least some schema fixes needed. > > Regards, > Matthias > > > Note that it is not yet a requirement to have 0 warnings for dtbs_check. > > This will change in the future. > > > > Full log is available here: https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230412112739.160376-2-angelogioacchino.delregno@collabora.com > > > > > > pwm@1100e000: 'power-domains' does not match any of the regexes: 'pinctrl-[0-9]+' Are you saying the MT6795 has no power-domains? > > arch/arm64/boot/dts/mediatek/mt8183-evb.dtb > > arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-burnet.dtb > > arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-cozmo.dtb > > arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-damu.dtb > > arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel14.dtb > > arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel14-sku2.dtb > > arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku1.dtb > > arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku6.dtb > > arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku7.dtb > > arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-juniper-sku16.dtb > > arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-kappa.dtb > > arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-kenzo.dtb > > arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-willow-sku0.dtb > > arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-willow-sku1.dtb > > arch/arm64/boot/dts/mediatek/mt8183-kukui-kakadu.dtb > > arch/arm64/boot/dts/mediatek/mt8183-kukui-kakadu-sku22.dtb > > arch/arm64/boot/dts/mediatek/mt8183-kukui-kodama-sku16.dtb > > arch/arm64/boot/dts/mediatek/mt8183-kukui-kodama-sku272.dtb > > arch/arm64/boot/dts/mediatek/mt8183-kukui-kodama-sku288.dtb > > arch/arm64/boot/dts/mediatek/mt8183-kukui-kodama-sku32.dtb > > arch/arm64/boot/dts/mediatek/mt8183-kukui-krane-sku0.dtb > > arch/arm64/boot/dts/mediatek/mt8183-kukui-krane-sku176.dtb > > arch/arm64/boot/dts/mediatek/mt8183-pumpkin.dtb > > > > pwm@1400a000: compatible: 'oneOf' conditional failed, one must be fixed: > > arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dtb > > arch/arm/boot/dts/mt7623n-rfb-emmc.dtb > > > > pwm@1401e000: compatible: 'oneOf' conditional failed, one must be fixed: > > arch/arm64/boot/dts/mediatek/mt8173-elm.dtb > > arch/arm64/boot/dts/mediatek/mt8173-elm-hana.dtb > > arch/arm64/boot/dts/mediatek/mt8173-elm-hana-rev7.dtb > > arch/arm64/boot/dts/mediatek/mt8173-evb.dtb > > > > pwm@1401f000: compatible: 'oneOf' conditional failed, one must be fixed: > > arch/arm64/boot/dts/mediatek/mt8173-elm.dtb > > arch/arm64/boot/dts/mediatek/mt8173-elm-hana.dtb > > arch/arm64/boot/dts/mediatek/mt8173-elm-hana-rev7.dtb > > arch/arm64/boot/dts/mediatek/mt8173-evb.dtb The commit message says the MT6795 is the same as the MT8173. Which is wrong here, the dtb or the schema? Rob
Il 13/04/23 10:52, Matthias Brugger ha scritto: > > > On 12/04/2023 23:03, Rob Herring wrote: >> >> On Wed, 12 Apr 2023 13:27:13 +0200, AngeloGioacchino Del Regno wrote: >>> Add a compatible string for MediaTek Helio X10 MT6795's display PWM >>> block: this is the same as MT8173. >>> >>> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> >>> --- >>> Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml | 4 +++- >>> 1 file changed, 3 insertions(+), 1 deletion(-) >>> >> >> Running 'make dtbs_check' with the schema in this patch gives the >> following warnings. Consider if they are expected or the schema is >> incorrect. These may not be new warnings. >> > > These are not new warnings. I think we should address them in a different patch. In > my opinion it shouldn't block this patch. In the end it only add as compatible here. > I agree. These warnings should not block this patch, as they're totally unrelated to it. Regards, Angelo
On 12/04/2023 13:27, AngeloGioacchino Del Regno wrote: > Add a compatible string for MediaTek Helio X10 MT6795's display PWM > block: this is the same as MT8173. > > Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com> > --- > Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml b/Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml > index 0088bc8e7c54..153e146df7d4 100644 > --- a/Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml > +++ b/Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml > @@ -22,7 +22,9 @@ properties: > - mediatek,mt8173-disp-pwm > - mediatek,mt8183-disp-pwm > - items: > - - const: mediatek,mt8167-disp-pwm > + - enum: > + - mediatek,mt6795-disp-pwm > + - mediatek,mt8167-disp-pwm > - const: mediatek,mt8173-disp-pwm > - items: > - enum:
© 2016 - 2024 Red Hat, Inc.