[v1] Add Dell G15 5525 Ryzen Edition to quirks list for acp6x so that internal DMIC works.

[PATCH] Add Dell G15 5525 Ryzen Edition to quirks list for acp6x so that internal DMIC works.

Posted by Cem Kaya 2 years, 10 months ago

diff --git a/sound/soc/amd/yc/acp6x-mach.c b/sound/soc/amd/yc/acp6x-mach.c
index a428e17f0325..e044d811496e 100644
--- a/sound/soc/amd/yc/acp6x-mach.c
+++ b/sound/soc/amd/yc/acp6x-mach.c
@@ -45,6 +45,13 @@ static struct snd_soc_card acp6x_card = {
 };
 
 static const struct dmi_system_id yc_acp_quirk_table[] = {
+	{
+		.driver_data = &acp6x_card,
+		.matches = {
+			DMI_MATCH(DMI_BOARD_VENDOR, "Dell Inc."),
+			DMI_MATCH(DMI_PRODUCT_NAME, "Dell G15 5525"),
+		}
+	},
 	{
 		.driver_data = &acp6x_card,
 		.matches = {
-- 
2.40.0

RE: [PATCH] Add Dell G15 5525 Ryzen Edition to quirks list for acp6x so that internal DMIC works.

Posted by Limonciello, Mario 2 years, 10 months ago

[Public]

> diff --git a/sound/soc/amd/yc/acp6x-mach.c b/sound/soc/amd/yc/acp6x-
> mach.c
> index a428e17f0325..e044d811496e 100644
> --- a/sound/soc/amd/yc/acp6x-mach.c
> +++ b/sound/soc/amd/yc/acp6x-mach.c
> @@ -45,6 +45,13 @@ static struct snd_soc_card acp6x_card = {
>  };
> 
>  static const struct dmi_system_id yc_acp_quirk_table[] = {
> +	{
> +		.driver_data = &acp6x_card,
> +		.matches = {
> +			DMI_MATCH(DMI_BOARD_VENDOR, "Dell Inc."),
> +			DMI_MATCH(DMI_PRODUCT_NAME, "Dell G15
> 5525"),
> +		}
> +	},
>  	{
>  		.driver_data = &acp6x_card,
>  		.matches = {
> --
> 2.40.0

Hi,

Thanks for sending this up, but you'll need to add a few things:

1) You need to add a commit message explaining the why
2) You're missing a SoB tag (IE Signed-off-by: Foo Bar <foo@bar.com>)
3) As this came from a kernel Bugzilla originally, suggest you to add Link tag:

Link: https://foo.bar.com/url

4) When you resubmit, please change PATCH to "PATCH v2"