[PATCH] tools: memory-model: Rename litmus test to avoid confusion with similar-named test

Joel Fernandes (Google) posted 1 patch 2 years, 10 months ago
...mbonce.litmus => Z6.0+pooncelock+pooncelockmb+pombonce.litmus} | 0
1 file changed, 0 insertions(+), 0 deletions(-)
rename tools/memory-model/litmus-tests/{Z6.0+pooncelock+poonceLock+pombonce.litmus => Z6.0+pooncelock+pooncelockmb+pombonce.litmus} (100%)
[PATCH] tools: memory-model: Rename litmus test to avoid confusion with similar-named test
Posted by Joel Fernandes (Google) 2 years, 10 months ago
In order to differentiate the test
Z6.0+pooncelock+poonceLock+pombonce.litmus from another test that only
differs by a capital L, the following file has been renamed:

renamed: litmus-tests/Z6.0+pooncelock+poonceLock+pombonce.litmus ->
litmus-tests/Z6.0+pooncelock+pooncelockmb+pombonce.litmus

This change should help avoid confusion between the two tests.

Signed-off-by: Joel Fernandes (Google) <joel@joelfernandes.org>
---
 ...mbonce.litmus => Z6.0+pooncelock+pooncelockmb+pombonce.litmus} | 0
 1 file changed, 0 insertions(+), 0 deletions(-)
 rename tools/memory-model/litmus-tests/{Z6.0+pooncelock+poonceLock+pombonce.litmus => Z6.0+pooncelock+pooncelockmb+pombonce.litmus} (100%)

diff --git a/tools/memory-model/litmus-tests/Z6.0+pooncelock+poonceLock+pombonce.litmus b/tools/memory-model/litmus-tests/Z6.0+pooncelock+pooncelockmb+pombonce.litmus
similarity index 100%
rename from tools/memory-model/litmus-tests/Z6.0+pooncelock+poonceLock+pombonce.litmus
rename to tools/memory-model/litmus-tests/Z6.0+pooncelock+pooncelockmb+pombonce.litmus
-- 
2.40.0.577.gac1e443424-goog
Re: [PATCH] tools: memory-model: Rename litmus test to avoid confusion with similar-named test
Posted by Akira Yokosawa 2 years, 10 months ago
Hi Joel,

On Sun,  9 Apr 2023 04:48:22 +0000, Joel Fernandes (Google) wrote:
> In order to differentiate the test
> Z6.0+pooncelock+poonceLock+pombonce.litmus from another test that only
> differs by a capital L, the following file has been renamed:
> 
> renamed: litmus-tests/Z6.0+pooncelock+poonceLock+pombonce.litmus ->
> litmus-tests/Z6.0+pooncelock+pooncelockmb+pombonce.litmus
> 
> This change should help avoid confusion between the two tests.
> 
> Signed-off-by: Joel Fernandes (Google) <joel@joelfernandes.org>
> ---
>  ...mbonce.litmus => Z6.0+pooncelock+pooncelockmb+pombonce.litmus} | 0
>  1 file changed, 0 insertions(+), 0 deletions(-)
>  rename tools/memory-model/litmus-tests/{Z6.0+pooncelock+poonceLock+pombonce.litmus => Z6.0+pooncelock+pooncelockmb+pombonce.litmus} (100%)
> 
> diff --git a/tools/memory-model/litmus-tests/Z6.0+pooncelock+poonceLock+pombonce.litmus b/tools/memory-model/litmus-tests/Z6.0+pooncelock+pooncelockmb+pombonce.litmus
> similarity index 100%
> rename from tools/memory-model/litmus-tests/Z6.0+pooncelock+poonceLock+pombonce.litmus
> rename to tools/memory-model/litmus-tests/Z6.0+pooncelock+pooncelockmb+pombonce.litmus

I must say simply changing the file name is only part of the job.
You need to update comments/docs as well.

There are 4 hits after this patch is applied:

$ find . -type f -exec grep -nH --null -F -e Z6.0+pooncelock+poonceLock \{\} +
./tools/memory-model/Documentation/locking.txt187:	/* See Z6.0+pooncelock+poonceLock+pombonce.litmus. */
./tools/memory-model/Documentation/recipes.txt162:	/* See Z6.0+pooncelock+poonceLock+pombonce.litmus. */
./tools/memory-model/litmus-tests/Z6.0+pooncelock+pooncelockmb+pombonce.litmus1:C Z6.0+pooncelock+poonceLock+pombonce
./tools/memory-model/litmus-tests/README152:Z6.0+pooncelock+poonceLock+pombonce.litmus

        Thanks, Akira