[v1] PCI: xilinx: Drop obsolete dependency on COMPILE_TEST

[PATCH RESEND] PCI: xilinx: Drop obsolete dependency on COMPILE_TEST

Posted by Jean Delvare 2 years, 5 months ago

Since commit 0166dc11be91 ("of: make CONFIG_OF user selectable"), it
is possible to test-build any driver which depends on OF on any
architecture by explicitly selecting OF. Therefore depending on
COMPILE_TEST as an alternative is no longer needed.

Signed-off-by: Jean Delvare <jdelvare@suse.de>
Cc: Lorenzo Pieralisi <lpieralisi@kernel.org>
Cc: Rob Herring <robh@kernel.org>
Cc: "Krzysztof Wilczyński" <kw@linux.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>
---
Resending as the context changed so my original submission no longer
applies cleanly.

 drivers/pci/controller/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- linux-6.0.orig/drivers/pci/controller/Kconfig
+++ linux-6.0/drivers/pci/controller/Kconfig
@@ -98,7 +98,7 @@ config PCI_HOST_GENERIC
 
 config PCIE_XILINX
 	bool "Xilinx AXI PCIe host bridge support"
-	depends on OF || COMPILE_TEST
+	depends on OF
 	depends on PCI_MSI
 	help
 	  Say 'Y' here if you want kernel to support the Xilinx AXI PCIe


-- 
Jean Delvare
SUSE L3 Support

Re: [PATCH RESEND] PCI: xilinx: Drop obsolete dependency on COMPILE_TEST

Posted by Bjorn Helgaas 2 years, 4 months ago

On Fri, Apr 07, 2023 at 07:08:43PM +0200, Jean Delvare wrote:
> Since commit 0166dc11be91 ("of: make CONFIG_OF user selectable"), it
> is possible to test-build any driver which depends on OF on any
> architecture by explicitly selecting OF. Therefore depending on
> COMPILE_TEST as an alternative is no longer needed.
> 
> Signed-off-by: Jean Delvare <jdelvare@suse.de>
> Cc: Lorenzo Pieralisi <lpieralisi@kernel.org>
> Cc: Rob Herring <robh@kernel.org>
> Cc: "Krzysztof Wilczyński" <kw@linux.com>
> Cc: Bjorn Helgaas <bhelgaas@google.com>

Thanks, Jean, applied to pci/controller/kconfig for v6.4.

> ---
> Resending as the context changed so my original submission no longer
> applies cleanly.
> 
>  drivers/pci/controller/Kconfig |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- linux-6.0.orig/drivers/pci/controller/Kconfig
> +++ linux-6.0/drivers/pci/controller/Kconfig
> @@ -98,7 +98,7 @@ config PCI_HOST_GENERIC
>  
>  config PCIE_XILINX
>  	bool "Xilinx AXI PCIe host bridge support"
> -	depends on OF || COMPILE_TEST
> +	depends on OF
>  	depends on PCI_MSI
>  	help
>  	  Say 'Y' here if you want kernel to support the Xilinx AXI PCIe
> 
> 
> -- 
> Jean Delvare
> SUSE L3 Support