scripts/gdb: timerlist fixes

[PATCH RESEND 0/3] scripts/gdb: timerlist fixes

Posted by Florian Fainelli 2 years, 10 months ago

Hi Andrew,

Since you have been collecting my patches touching scripts/gdb,
(re)sending those fixes from Amjad that restore a functional
"lx-timerlist" scripts.

Thanks!

Amjad Ouled-Ameur (3):
  scripts/gdb: timerlist: use range instead of xrange
  scripts/gdb: timerlist: fix rb_node access
  scripts/gdb: timerlist: convert int chunks to str

 scripts/gdb/linux/timerlist.py | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

-- 
2.34.1

Re: [PATCH RESEND 0/3] scripts/gdb: timerlist fixes

Posted by Andrew Morton 2 years, 10 months ago

On Thu,  6 Apr 2023 15:12:14 -0700 Florian Fainelli <f.fainelli@gmail.com> wrote:

> Since you have been collecting my patches touching scripts/gdb,
> (re)sending those fixes from Amjad that restore a functional
> "lx-timerlist" scripts.

The first two issues appear to have already been fixed:

https://lore.kernel.org/all/TYCP286MB21463BD277330B26DDC18903C6819@TYCP286MB2146.JPNP286.PROD.OUTLOOK.COM/T/#u
https://lore.kernel.org/all/TYCP286MB2146EE1180A4D5176CBA8AB2C6819@TYCP286MB2146.JPNP286.PROD.OUTLOOK.COM/T/#u
https://lore.kernel.org/all/TYCP286MB214640FF0E7F04AC3926A39EC6819@TYCP286MB2146.JPNP286.PROD.OUTLOOK.COM/T/#u

Thanks, I'll queue up the third patch.

(And I'm going to have to redo the above three patches and rebase,
because I now see hotmail's Message-ID's fooled my Link: extraction
script, grr)

While I'm there, I'm wondering if the xrange patch should be backported
to -stable kernels.  We want gdb to work well with Python3 on older
kernels, yes?

Also, I added your Signed-off-by: to "scripts/gdb: timerlist: convert
int chunks to str", since you were on the patch delivery path.

Re: [PATCH RESEND 0/3] scripts/gdb: timerlist fixes

Posted by Florian Fainelli 2 years, 10 months ago


On 4/6/2023 4:18 PM, Andrew Morton wrote:
> On Thu,  6 Apr 2023 15:12:14 -0700 Florian Fainelli <f.fainelli@gmail.com> wrote:
> 
>> Since you have been collecting my patches touching scripts/gdb,
>> (re)sending those fixes from Amjad that restore a functional
>> "lx-timerlist" scripts.
> 
> The first two issues appear to have already been fixed:
> 
> https://lore.kernel.org/all/TYCP286MB21463BD277330B26DDC18903C6819@TYCP286MB2146.JPNP286.PROD.OUTLOOK.COM/T/#u
> https://lore.kernel.org/all/TYCP286MB2146EE1180A4D5176CBA8AB2C6819@TYCP286MB2146.JPNP286.PROD.OUTLOOK.COM/T/#u
> https://lore.kernel.org/all/TYCP286MB214640FF0E7F04AC3926A39EC6819@TYCP286MB2146.JPNP286.PROD.OUTLOOK.COM/T/#u

Oh yes, indeed there was a prior submission by Peng.

> 
> Thanks, I'll queue up the third patch.
> 
> (And I'm going to have to redo the above three patches and rebase,
> because I now see hotmail's Message-ID's fooled my Link: extraction
> script, grr)
> 
> 
> While I'm there, I'm wondering if the xrange patch should be backported
> to -stable kernels.  We want gdb to work well with Python3 on older
> kernels, yes?

I would say so, yes.

> 
> 
> Also, I added your Signed-off-by: to "scripts/gdb: timerlist: convert
> int chunks to str", since you were on the patch delivery path.
> 

Thanks!
-- 
Florian