sched/psi: set varaiable psi_cgroups_enabled storage-class-specifier to static

[PATCH] sched/psi: set varaiable psi_cgroups_enabled storage-class-specifier to static

Posted by Tom Rix 2 years, 10 months ago

smatch reports
kernel/sched/psi.c:143:1: warning: symbol
  'psi_cgroups_enabled' was not declared. Should it be static?

This variable is only used in one file so should be static.

Signed-off-by: Tom Rix <trix@redhat.com>
---
 kernel/sched/psi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/sched/psi.c b/kernel/sched/psi.c
index 02e011cabe91..c8a556eb9f8a 100644
--- a/kernel/sched/psi.c
+++ b/kernel/sched/psi.c
@@ -140,7 +140,7 @@
 static int psi_bug __read_mostly;
 
 DEFINE_STATIC_KEY_FALSE(psi_disabled);
-DEFINE_STATIC_KEY_TRUE(psi_cgroups_enabled);
+static DEFINE_STATIC_KEY_TRUE(psi_cgroups_enabled);
 
 #ifdef CONFIG_PSI_DEFAULT_DISABLED
 static bool psi_enable;
-- 
2.27.0

Re: [PATCH] sched/psi: set varaiable psi_cgroups_enabled storage-class-specifier to static

Posted by Johannes Weiner 2 years, 10 months ago

On Wed, Apr 05, 2023 at 12:36:02PM -0400, Tom Rix wrote:
> smatch reports
> kernel/sched/psi.c:143:1: warning: symbol
>   'psi_cgroups_enabled' was not declared. Should it be static?
> 
> This variable is only used in one file so should be static.
> 
> Signed-off-by: Tom Rix <trix@redhat.com>

Acked-by: Johannes Weiner <hannes@cmpxchg.org>

Re: [PATCH] sched/psi: set varaiable psi_cgroups_enabled storage-class-specifier to static

Posted by Suren Baghdasaryan 2 years, 10 months ago

On Wed, Apr 5, 2023 at 9:46 AM Johannes Weiner <hannes@cmpxchg.org> wrote:
>
> On Wed, Apr 05, 2023 at 12:36:02PM -0400, Tom Rix wrote:
> > smatch reports
> > kernel/sched/psi.c:143:1: warning: symbol
> >   'psi_cgroups_enabled' was not declared. Should it be static?
> >
> > This variable is only used in one file so should be static.
> >
> > Signed-off-by: Tom Rix <trix@redhat.com>
>
> Acked-by: Johannes Weiner <hannes@cmpxchg.org>

Acked-by: Suren Baghdasaryan <surenb@google.com>