[PATCHv1 0/3] generic-ohci/ehci: add RK3588 support

Sebastian Reichel posted 3 patches 2 years, 10 months ago
There is a newer version of this series
.../devicetree/bindings/usb/generic-ehci.yaml  |  1 +
.../devicetree/bindings/usb/generic-ohci.yaml  | 18 ++++++++++++++++--
drivers/usb/host/ohci-platform.c               |  2 +-
3 files changed, 18 insertions(+), 3 deletions(-)
[PATCHv1 0/3] generic-ohci/ehci: add RK3588 support
Posted by Sebastian Reichel 2 years, 10 months ago
Hi,

This increases the max. allowed clocks for generic-ohci from 3 to 4.
On RK3588 a total of 4 clocks is required to access the OHCI registers.
EHCI already supports 4 clocks.

Changes since PATCHv1:
 * https://lore.kernel.org/all/20230331163148.5863-1-sebastian.reichel@collabora.com/
 * Add Alan's Acked-by to the driver patch increasing the clock count
 * Update bindings, adding rockchip,rk3588-ohci and rockchip,rk3588-ehci compatibles

-- Sebastian

Sebastian Reichel (3):
  dt-bindings: usb: Add RK3588 OHCI
  dt-bindings: usb: Add RK3588 EHCI
  usb: host: ohci-platform: increase max clock number to 4

 .../devicetree/bindings/usb/generic-ehci.yaml  |  1 +
 .../devicetree/bindings/usb/generic-ohci.yaml  | 18 ++++++++++++++++--
 drivers/usb/host/ohci-platform.c               |  2 +-
 3 files changed, 18 insertions(+), 3 deletions(-)

-- 
2.39.2
Re: [PATCHv1 0/3] generic-ohci/ehci: add RK3588 support
Posted by Greg Kroah-Hartman 2 years, 10 months ago
On Tue, Apr 04, 2023 at 04:53:47PM +0200, Sebastian Reichel wrote:
> Hi,
> 
> This increases the max. allowed clocks for generic-ohci from 3 to 4.
> On RK3588 a total of 4 clocks is required to access the OHCI registers.
> EHCI already supports 4 clocks.
> 
> Changes since PATCHv1:
>  * https://lore.kernel.org/all/20230331163148.5863-1-sebastian.reichel@collabora.com/
>  * Add Alan's Acked-by to the driver patch increasing the clock count
>  * Update bindings, adding rockchip,rk3588-ohci and rockchip,rk3588-ehci compatibles

This is "v1" according to the subject line, right?

confused,

greg k-h
Re: [PATCHv1 0/3] generic-ohci/ehci: add RK3588 support
Posted by Sebastian Reichel 2 years, 10 months ago
Hi Greg,

On Wed, Apr 05, 2023 at 04:49:37PM +0200, Greg Kroah-Hartman wrote:
> On Tue, Apr 04, 2023 at 04:53:47PM +0200, Sebastian Reichel wrote:
> > Hi,
> > 
> > This increases the max. allowed clocks for generic-ohci from 3 to 4.
> > On RK3588 a total of 4 clocks is required to access the OHCI registers.
> > EHCI already supports 4 clocks.
> > 
> > Changes since PATCHv1:
> >  * https://lore.kernel.org/all/20230331163148.5863-1-sebastian.reichel@collabora.com/
> >  * Add Alan's Acked-by to the driver patch increasing the clock count
> >  * Update bindings, adding rockchip,rk3588-ohci and rockchip,rk3588-ehci compatibles
> 
> This is "v1" according to the subject line, right?

Well the previous version was also about adding RK3588 support.
I did not see anything RK3588 specific and thus used "increase
allowed clocks" as subject for the cover letter. Rob's review
effectively asked for RK3588 specific compatibles to be added,
so this is a v2 of the series with that change included.

Since increasing the maximum number of clocks is no longer the
dominant content of the series I changed the cover letter's
subject. Sorry that this confused you.

Greetings,

-- Sebastian