net: alteon: remove unused len variable

[PATCH] net: alteon: remove unused len variable

Posted by Tom Rix 2 years, 10 months ago

clang with W=1 reports
drivers/net/ethernet/alteon/acenic.c:2438:10: error: variable
  'len' set but not used [-Werror,-Wunused-but-set-variable]
                int i, len = 0;
                       ^
This variable is not used so remove it.

Signed-off-by: Tom Rix <trix@redhat.com>
---
 drivers/net/ethernet/alteon/acenic.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/alteon/acenic.c b/drivers/net/ethernet/alteon/acenic.c
index d7762da8b2c0..eafef84fe3be 100644
--- a/drivers/net/ethernet/alteon/acenic.c
+++ b/drivers/net/ethernet/alteon/acenic.c
@@ -2435,7 +2435,7 @@ static netdev_tx_t ace_start_xmit(struct sk_buff *skb,
 	} else {
 		dma_addr_t mapping;
 		u32 vlan_tag = 0;
-		int i, len = 0;
+		int i;
 
 		mapping = ace_map_tx_skb(ap, skb, NULL, idx);
 		flagsize = (skb_headlen(skb) << 16);
@@ -2454,7 +2454,6 @@ static netdev_tx_t ace_start_xmit(struct sk_buff *skb,
 			const skb_frag_t *frag = &skb_shinfo(skb)->frags[i];
 			struct tx_ring_info *info;
 
-			len += skb_frag_size(frag);
 			info = ap->skb->tx_skbuff + idx;
 			desc = ap->tx_ring + idx;
 
-- 
2.27.0

Re: [PATCH] net: alteon: remove unused len variable

Posted by Jes Sorensen 2 years, 10 months ago

On 3/31/23 16:55, Tom Rix wrote:
> clang with W=1 reports
> drivers/net/ethernet/alteon/acenic.c:2438:10: error: variable
>    'len' set but not used [-Werror,-Wunused-but-set-variable]
>                  int i, len = 0;
>                         ^
> This variable is not used so remove it.
> 
> Signed-off-by: Tom Rix <trix@redhat.com>

Signed-off-by: Jes Sorensen <jes@trained-monkey.org>


> ---
>   drivers/net/ethernet/alteon/acenic.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/net/ethernet/alteon/acenic.c b/drivers/net/ethernet/alteon/acenic.c
> index d7762da8b2c0..eafef84fe3be 100644
> --- a/drivers/net/ethernet/alteon/acenic.c
> +++ b/drivers/net/ethernet/alteon/acenic.c
> @@ -2435,7 +2435,7 @@ static netdev_tx_t ace_start_xmit(struct sk_buff *skb,
>   	} else {
>   		dma_addr_t mapping;
>   		u32 vlan_tag = 0;
> -		int i, len = 0;
> +		int i;
>   
>   		mapping = ace_map_tx_skb(ap, skb, NULL, idx);
>   		flagsize = (skb_headlen(skb) << 16);
> @@ -2454,7 +2454,6 @@ static netdev_tx_t ace_start_xmit(struct sk_buff *skb,
>   			const skb_frag_t *frag = &skb_shinfo(skb)->frags[i];
>   			struct tx_ring_info *info;
>   
> -			len += skb_frag_size(frag);
>   			info = ap->skb->tx_skbuff + idx;
>   			desc = ap->tx_ring + idx;
>

Re: [PATCH] net: alteon: remove unused len variable

Posted by patchwork-bot+netdevbpf@kernel.org 2 years, 10 months ago

Hello:

This patch was applied to netdev/net-next.git (main)
by David S. Miller <davem@davemloft.net>:

On Fri, 31 Mar 2023 16:55:45 -0400 you wrote:
> clang with W=1 reports
> drivers/net/ethernet/alteon/acenic.c:2438:10: error: variable
>   'len' set but not used [-Werror,-Wunused-but-set-variable]
>                 int i, len = 0;
>                        ^
> This variable is not used so remove it.
> 
> [...]

Here is the summary with links:
  - net: alteon: remove unused len variable
    https://git.kernel.org/netdev/net-next/c/51aaa68222d6

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Re: [PATCH] net: alteon: remove unused len variable

Posted by Simon Horman 2 years, 10 months ago

On Fri, Mar 31, 2023 at 04:55:45PM -0400, Tom Rix wrote:
> clang with W=1 reports
> drivers/net/ethernet/alteon/acenic.c:2438:10: error: variable
>   'len' set but not used [-Werror,-Wunused-but-set-variable]
>                 int i, len = 0;
>                        ^
> This variable is not used so remove it.
> 
> Signed-off-by: Tom Rix <trix@redhat.com>

Reviewed-by: Simon Horman <simon.horman@corigine.com>