[PATCHv1 1/2] dt-bindings: usb: generic-ohci: increase allowed clocks

Sebastian Reichel posted 2 patches 2 years, 10 months ago
[PATCHv1 1/2] dt-bindings: usb: generic-ohci: increase allowed clocks
Posted by Sebastian Reichel 2 years, 10 months ago
Increase number of allowed clocks to 4, which is the number
required on Rockchip RK3588.

Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
---
 Documentation/devicetree/bindings/usb/generic-ohci.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/usb/generic-ohci.yaml b/Documentation/devicetree/bindings/usb/generic-ohci.yaml
index a9ba7257b884..c0880d0664f1 100644
--- a/Documentation/devicetree/bindings/usb/generic-ohci.yaml
+++ b/Documentation/devicetree/bindings/usb/generic-ohci.yaml
@@ -69,7 +69,7 @@ properties:
 
   clocks:
     minItems: 1
-    maxItems: 3
+    maxItems: 4
     description: |
       In case the Renesas R-Car Gen3 SoCs:
         - if a host only channel: first clock should be host.
-- 
2.39.2
Re: [PATCHv1 1/2] dt-bindings: usb: generic-ohci: increase allowed clocks
Posted by Rob Herring 2 years, 10 months ago
On Fri, Mar 31, 2023 at 06:31:47PM +0200, Sebastian Reichel wrote:
> Increase number of allowed clocks to 4, which is the number
> required on Rockchip RK3588.

It was 3 because that's what crept in until we made a schema. Additions 
should really have a specific compatible and a conditional schema 
limiting that 4 clocks to that compatible.

> 
> Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
> ---
>  Documentation/devicetree/bindings/usb/generic-ohci.yaml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/usb/generic-ohci.yaml b/Documentation/devicetree/bindings/usb/generic-ohci.yaml
> index a9ba7257b884..c0880d0664f1 100644
> --- a/Documentation/devicetree/bindings/usb/generic-ohci.yaml
> +++ b/Documentation/devicetree/bindings/usb/generic-ohci.yaml
> @@ -69,7 +69,7 @@ properties:
>  
>    clocks:
>      minItems: 1
> -    maxItems: 3
> +    maxItems: 4
>      description: |
>        In case the Renesas R-Car Gen3 SoCs:
>          - if a host only channel: first clock should be host.
> -- 
> 2.39.2
>