1. Patchew
  2. linux
  3. [PATCH v1 0/3] Add TDM audio on StarFive JH7110
  4. View patch

[PATCH v1 1/3] dt-bindings: sound: Add TDM for StarFive JH7110

Walker Chen posted 3 patches 2 years, 10 months ago
There is a newer version of this series
[PATCH v1 1/3] dt-bindings: sound: Add TDM for StarFive JH7110
Posted by Walker Chen 2 years, 10 months ago 
Add bindings to describe the TDM driver for the StarFive JH7110 SoC.

Signed-off-by: Walker Chen <walker.chen@starfivetech.com>
---
 .../bindings/sound/starfive,jh7110-tdm.yaml   | 95 +++++++++++++++++++
 1 file changed, 95 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/sound/starfive,jh7110-tdm.yaml

diff --git a/Documentation/devicetree/bindings/sound/starfive,jh7110-tdm.yaml b/Documentation/devicetree/bindings/sound/starfive,jh7110-tdm.yaml
new file mode 100644
index 000000000000..d65b9ed781ef
--- /dev/null
+++ b/Documentation/devicetree/bindings/sound/starfive,jh7110-tdm.yaml
@@ -0,0 +1,95 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/sound/starfive,jh7110-tdm.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: StarFive JH7110 TDM Controller
+
+description: |
+  The TDM Controller is a Time Division Multiplexed audio interface
+  integrated in StarFive JH7110 SoC, allowing up to 8 channels of
+  audio over a serial interface. The TDM controller can operate both
+  in master and slave mode.
+
+maintainers:
+  - Walker Chen <walker.chen@starfivetech.com>
+
+properties:
+  compatible:
+    enum:
+      - starfive,jh7110-tdm
+
+  reg:
+    maxItems: 1
+
+  clocks:
+    items:
+      - description: TDM AHB Clock
+      - description: TDM APB Clock
+      - description: TDM Internal Clock
+      - description: TDM Clock
+      - description: Inner MCLK
+      - description: TDM External Clock
+
+  clock-names:
+    items:
+      - const: tdm_ahb
+      - const: tdm_apb
+      - const: tdm_internal
+      - const: tdm
+      - const: mclk_inner
+      - const: tdm_ext
+
+  resets:
+    items:
+      - description: tdm ahb reset line
+      - description: tdm apb reset line
+      - description: tdm core reset line
+
+  dmas:
+    items:
+      - description: RX DMA Channel
+      - description: TX DMA Channel
+
+  dma-names:
+    items:
+      - const: rx
+      - const: tx
+
+  "#sound-dai-cells":
+    const: 0
+
+required:
+  - compatible
+  - reg
+  - clocks
+  - clock-names
+  - resets
+  - dmas
+  - dma-names
+  - "#sound-dai-cells"
+
+additionalProperties: false
+
+examples:
+  - |
+    tdm: tdm@10090000 {
+        compatible = "starfive,jh7110-tdm";
+        reg = <0x10090000 0x1000>;
+        clocks = <&syscrg 184>,
+                 <&syscrg 185>,
+                 <&syscrg 186>,
+                 <&syscrg 187>,
+                 <&syscrg 17>,
+                 <&tdm_ext>;
+        clock-names = "tdm_ahb", "tdm_apb",
+                      "tdm_internal", "tdm",
+                      "mclk_inner", "tdm_ext";
+        resets = <&syscrg 105>,
+                 <&syscrg 107>,
+                 <&syscrg 106>;
+        dmas = <&dma 20>, <&dma 21>;
+        dma-names = "rx","tx";
+        #sound-dai-cells = <0>;
+    };
-- 
2.17.1
Re: [PATCH v1 1/3] dt-bindings: sound: Add TDM for StarFive JH7110
Posted by Krzysztof Kozlowski 2 years, 10 months ago 
On 29/03/2023 17:33, Walker Chen wrote:
> Add bindings to describe the TDM driver for the StarFive JH7110 SoC.
> 
> Signed-off-by: Walker Chen <walker.chen@starfivetech.com>
> ---
>  .../bindings/sound/starfive,jh7110-tdm.yaml   | 95 +++++++++++++++++++
>  1 file changed, 95 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/sound/starfive,jh7110-tdm.yaml
> 
> diff --git a/Documentation/devicetree/bindings/sound/starfive,jh7110-tdm.yaml b/Documentation/devicetree/bindings/sound/starfive,jh7110-tdm.yaml
> new file mode 100644
> index 000000000000..d65b9ed781ef
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/sound/starfive,jh7110-tdm.yaml
> @@ -0,0 +1,95 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/sound/starfive,jh7110-tdm.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: StarFive JH7110 TDM Controller
> +
> +description: |
> +  The TDM Controller is a Time Division Multiplexed audio interface
> +  integrated in StarFive JH7110 SoC, allowing up to 8 channels of
> +  audio over a serial interface. The TDM controller can operate both
> +  in master and slave mode.
> +
> +maintainers:
> +  - Walker Chen <walker.chen@starfivetech.com>
> +

Missing allOf: with $ref to dai-common.

> +properties:
> +  compatible:
> +    enum:
> +      - starfive,jh7110-tdm
> +
> +  reg:
> +    maxItems: 1

(...)

> +required:
> +  - compatible
> +  - reg
> +  - clocks
> +  - clock-names
> +  - resets
> +  - dmas
> +  - dma-names
> +  - "#sound-dai-cells"
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    tdm: tdm@10090000 {

Drop tdm label, not used.

Best regards,
Krzysztof
Re: [PATCH v1 1/3] dt-bindings: sound: Add TDM for StarFive JH7110
Posted by Walker Chen 2 years, 10 months ago 

On 2023/3/30 15:39, Krzysztof Kozlowski wrote:
> On 29/03/2023 17:33, Walker Chen wrote:
>> Add bindings to describe the TDM driver for the StarFive JH7110 SoC.
>> 
>> Signed-off-by: Walker Chen <walker.chen@starfivetech.com>
>> ---
>>  .../bindings/sound/starfive,jh7110-tdm.yaml   | 95 +++++++++++++++++++
>>  1 file changed, 95 insertions(+)
>>  create mode 100644 Documentation/devicetree/bindings/sound/starfive,jh7110-tdm.yaml
>> 
>> diff --git a/Documentation/devicetree/bindings/sound/starfive,jh7110-tdm.yaml b/Documentation/devicetree/bindings/sound/starfive,jh7110-tdm.yaml
>> new file mode 100644
>> index 000000000000..d65b9ed781ef
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/sound/starfive,jh7110-tdm.yaml
>> @@ -0,0 +1,95 @@
>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/sound/starfive,jh7110-tdm.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: StarFive JH7110 TDM Controller
>> +
>> +description: |
>> +  The TDM Controller is a Time Division Multiplexed audio interface
>> +  integrated in StarFive JH7110 SoC, allowing up to 8 channels of
>> +  audio over a serial interface. The TDM controller can operate both
>> +  in master and slave mode.
>> +
>> +maintainers:
>> +  - Walker Chen <walker.chen@starfivetech.com>
>> +
> 
> Missing allOf: with $ref to dai-common.

Indeed missing allOf, thank you for kind reminding.

> 
>> +properties:
>> +  compatible:
>> +    enum:
>> +      - starfive,jh7110-tdm
>> +
>> +  reg:
>> +    maxItems: 1
> 
> (...)
> 
>> +required:
>> +  - compatible
>> +  - reg
>> +  - clocks
>> +  - clock-names
>> +  - resets
>> +  - dmas
>> +  - dma-names
>> +  - "#sound-dai-cells"
>> +
>> +additionalProperties: false
>> +
>> +examples:
>> +  - |
>> +    tdm: tdm@10090000 {
> 
> Drop tdm label, not used.

Ok, will drop it.

Best regards,
Walker

Patchew 2.1-devel-b67e4c2

© 2016 - 2026 Red Hat, Inc.