[PATCH net-next v2] smsc911x: remove superfluous variable init

Wolfram Sang posted 1 patch 2 years, 10 months ago
drivers/net/ethernet/smsc/smsc911x.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH net-next v2] smsc911x: remove superfluous variable init
Posted by Wolfram Sang 2 years, 10 months ago
phydev is assigned a value right away, no need to initialize it.

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
---

Changes since v1:
* rebased to net-next as of today
* added Geert's tag (thanks!)

 drivers/net/ethernet/smsc/smsc911x.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/smsc/smsc911x.c b/drivers/net/ethernet/smsc/smsc911x.c
index 39446d4e94b6..c653ea792dd1 100644
--- a/drivers/net/ethernet/smsc/smsc911x.c
+++ b/drivers/net/ethernet/smsc/smsc911x.c
@@ -1016,7 +1016,7 @@ static void smsc911x_phy_adjust_link(struct net_device *dev)
 static int smsc911x_mii_probe(struct net_device *dev)
 {
 	struct smsc911x_data *pdata = netdev_priv(dev);
-	struct phy_device *phydev = NULL;
+	struct phy_device *phydev;
 	int ret;
 
 	/* find the first phy */
-- 
2.30.2
Re: [PATCH net-next v2] smsc911x: remove superfluous variable init
Posted by patchwork-bot+netdevbpf@kernel.org 2 years, 10 months ago
Hello:

This patch was applied to netdev/net-next.git (main)
by Paolo Abeni <pabeni@redhat.com>:

On Wed, 29 Mar 2023 08:44:14 +0200 you wrote:
> phydev is assigned a value right away, no need to initialize it.
> 
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> 
> Changes since v1:
> * rebased to net-next as of today
> * added Geert's tag (thanks!)
> 
> [...]

Here is the summary with links:
  - [net-next,v2] smsc911x: remove superfluous variable init
    https://git.kernel.org/netdev/net-next/c/da617cd8d906

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html