[v3] ext4: fix quotas leak in __ext4_fill_super()

[PATCH v3 0/2] ext4: fix quotas leak in __ext4_fill_super()

Posted by Baokun Li 2 years, 10 months ago

V1->V2:
	Add judgment for CONFIG_QUOTA to avoid warning
	"label 'failed_mount9' defined but not used".
	(Reported-by: kernel test robot <lkp@intel.com>)
V2->V3:
	By adding __maybe_unused to silence possible compilation
	complain in patch one, instead of adding the judgment.
	(Suggested by Jan Kara).

Baokun Li (2):
  ext4: turning quotas off if mount failed after enable quotas
  ext4: refactoring to use the unified helper ext4_quotas_off()

 fs/ext4/super.c | 30 ++++++++++--------------------
 1 file changed, 10 insertions(+), 20 deletions(-)

-- 
2.31.1

Re: [PATCH v3 0/2] ext4: fix quotas leak in __ext4_fill_super()

Posted by Theodore Ts'o 2 years, 7 months ago

On Mon, 27 Mar 2023 22:16:28 +0800, Baokun Li wrote:
> V1->V2:
> 	Add judgment for CONFIG_QUOTA to avoid warning
> 	"label 'failed_mount9' defined but not used".
> 	(Reported-by: kernel test robot <lkp@intel.com>)
> V2->V3:
> 	By adding __maybe_unused to silence possible compilation
> 	complain in patch one, instead of adding the judgment.
> 	(Suggested by Jan Kara).
> 
> [...]

Applied, thanks!

[1/2] ext4: turning quotas off if mount failed after enable quotas
      commit: e39a0c8d9cc298c5a4afdeb416441091ae3f1fcb
[2/2] ext4: refactoring to use the unified helper ext4_quotas_off()
      commit: 63ec000b35a3c6cbb42b2e545c7c18f3d36159d6

Best regards,
-- 
Theodore Ts'o <tytso@mit.edu>

Re: [PATCH v3 0/2] ext4: fix quotas leak in __ext4_fill_super()

Posted by Baokun Li 2 years, 8 months ago

A gentle ping.

On 2023/3/27 22:16, Baokun Li wrote:
> V1->V2:
> 	Add judgment for CONFIG_QUOTA to avoid warning
> 	"label 'failed_mount9' defined but not used".
> 	(Reported-by: kernel test robot <lkp@intel.com>)
> V2->V3:
> 	By adding __maybe_unused to silence possible compilation
> 	complain in patch one, instead of adding the judgment.
> 	(Suggested by Jan Kara).
>
> Baokun Li (2):
>    ext4: turning quotas off if mount failed after enable quotas
>    ext4: refactoring to use the unified helper ext4_quotas_off()
>
>   fs/ext4/super.c | 30 ++++++++++--------------------
>   1 file changed, 10 insertions(+), 20 deletions(-)
>