[v2] Cleanup Mediatek pinctrl device tree binding

[PATCH v2 0/2] Cleanup Mediatek pinctrl device tree binding

Posted by Alexandre Mergnat 2 years, 10 months ago

Deprecate properties which shall not exist, leaked upstream from downstream
kernels, there's no reason to use them. Here the deprecated properties and
the generic properties which will replace them:

- mediatek,drive-strength-adv => drive-strength-microamp
- mediatek,pull-up-adv        => bias-pull-up
- mediatek,pull-down-adv      => bias-pull-down

Thanks AngeloGioacchino Del Regno to reported it. [1]

[1]: https://lore.kernel.org/all/6e08d78f-ef4c-b228-f7d2-d63767ea87b8@collabora.com/

Signed-off-by: Alexandre Mergnat <amergnat@baylibre.com>
---
Changes in v2:
- Change the bias-pull enum values to match with other Mediatek SoC.
  That allows to use MTK generic define and be compliant with the MTK
  common pinctrl driver.
- Link to v1: https://lore.kernel.org/r/20230327-cleanup-pinctrl-binding-v1-0-b695e32e4f2e@baylibre.com

---
Alexandre Mergnat (2):
      dt-bindings: pinctrl: mediatek: deprecate custom drive strength property
      dt-bindings: pinctrl: mediatek: deprecate custom bias pull properties for mt8365

 .../bindings/pinctrl/mediatek,mt8183-pinctrl.yaml  |  8 +++--
 .../bindings/pinctrl/mediatek,mt8365-pinctrl.yaml  | 38 +++++++++++++++++++---
 2 files changed, 39 insertions(+), 7 deletions(-)
---
base-commit: fe15c26ee26efa11741a7b632e9f23b01aca4cc6
change-id: 20230327-cleanup-pinctrl-binding-8064a8f8bf68

Best regards,
-- 
Alexandre Mergnat <amergnat@baylibre.com>

Re: [PATCH v2 0/2] Cleanup Mediatek pinctrl device tree binding

Posted by Linus Walleij 2 years, 10 months ago

On Fri, Mar 31, 2023 at 7:39 PM Alexandre Mergnat <amergnat@baylibre.com> wrote:

> Deprecate properties which shall not exist, leaked upstream from downstream
> kernels, there's no reason to use them. Here the deprecated properties and
> the generic properties which will replace them:
>
> - mediatek,drive-strength-adv => drive-strength-microamp
> - mediatek,pull-up-adv        => bias-pull-up
> - mediatek,pull-down-adv      => bias-pull-down
>
> Thanks AngeloGioacchino Del Regno to reported it. [1]
>
> [1]: https://lore.kernel.org/all/6e08d78f-ef4c-b228-f7d2-d63767ea87b8@collabora.com/
>
> Signed-off-by: Alexandre Mergnat <amergnat@baylibre.com>
> ---
> Changes in v2:
> - Change the bias-pull enum values to match with other Mediatek SoC.
>   That allows to use MTK generic define and be compliant with the MTK
>   common pinctrl driver.
> - Link to v1: https://lore.kernel.org/r/20230327-cleanup-pinctrl-binding-v1-0-b695e32e4f2e@baylibre.com

These patches does not apply to my devel branch:
https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-pinctrl.git/log/?h=devel

Can you please rebase and resend?

If you have several conflicting patches that need to be applied to the
pinctrl tree, then collect them all in a series so I can apply them all
at once. Thanks!

Yours,
Linus Walleij

Re: [PATCH v2 0/2] Cleanup Mediatek pinctrl device tree binding

Posted by Alexandre Mergnat 2 years, 10 months ago

Hi Linus,

On 04/04/2023 15:56, Linus Walleij wrote:
> On Fri, Mar 31, 2023 at 7:39 PM Alexandre Mergnat <amergnat@baylibre.com> wrote:
>
>> Deprecate properties which shall not exist, leaked upstream from downstream
>> kernels, there's no reason to use them. Here the deprecated properties and
>> the generic properties which will replace them:
>>
>> - mediatek,drive-strength-adv => drive-strength-microamp
>> - mediatek,pull-up-adv        => bias-pull-up
>> - mediatek,pull-down-adv      => bias-pull-down
>>
>> Thanks AngeloGioacchino Del Regno to reported it. [1]
>>
>> [1]: https://lore.kernel.org/all/6e08d78f-ef4c-b228-f7d2-d63767ea87b8@collabora.com/
>>
>> Signed-off-by: Alexandre Mergnat <amergnat@baylibre.com>
>> ---
>> Changes in v2:
>> - Change the bias-pull enum values to match with other Mediatek SoC.
>>    That allows to use MTK generic define and be compliant with the MTK
>>    common pinctrl driver.
>> - Link to v1: https://lore.kernel.org/r/20230327-cleanup-pinctrl-binding-v1-0-b695e32e4f2e@baylibre.com
> These patches does not apply to my devel branch:
> https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-pinctrl.git/log/?h=devel
>
> Can you please rebase and resend?
>
> If you have several conflicting patches that need to be applied to the
> pinctrl tree, then collect them all in a series so I can apply them all
> at once. Thanks!

It's done here: 
https://lore.kernel.org/all/20230327-cleanup-pinctrl-binding-v3-0-6f56d5c7a8de@baylibre.com/

I also added the patch which modify the pinctrl from the other serie:
https://lore.kernel.org/all/CACRpkdYSpMD-V0QNGwtiKCA4KAedYfmFpvdCHWhjST9uTricTg@mail.gmail.com/


Regards,
Alex