nvme-pci: mark Lexar NM760 as IGNORE_DEV_SUBNQN

[PATCH] nvme-pci: mark Lexar NM760 as IGNORE_DEV_SUBNQN

Posted by Juraj Pecigos 1 year ago

A system with more than one of these SSDs will only have one usable.
The kernel fails to detect more than one nvme device due to duplicate
cntlids.

before:
[    9.395229] nvme 0000:01:00.0: platform quirk: setting simple suspend
[    9.395262] nvme nvme0: pci function 0000:01:00.0
[    9.395282] nvme 0000:03:00.0: platform quirk: setting simple suspend
[    9.395305] nvme nvme1: pci function 0000:03:00.0
[    9.409873] nvme nvme0: Duplicate cntlid 1 with nvme1, subsys nqn.2022-07.com.siliconmotion:nvm-subsystem-sn-                    , rejecting
[    9.409982] nvme nvme0: Removing after probe failure status: -22
[    9.427487] nvme nvme1: allocated 64 MiB host memory buffer.
[    9.445088] nvme nvme1: 16/0/0 default/read/poll queues
[    9.449898] nvme nvme1: Ignoring bogus Namespace Identifiers

after:
[    1.161890] nvme 0000:01:00.0: platform quirk: setting simple suspend
[    1.162660] nvme nvme0: pci function 0000:01:00.0
[    1.162684] nvme 0000:03:00.0: platform quirk: setting simple suspend
[    1.162707] nvme nvme1: pci function 0000:03:00.0
[    1.191354] nvme nvme0: allocated 64 MiB host memory buffer.
[    1.193378] nvme nvme1: allocated 64 MiB host memory buffer.
[    1.211044] nvme nvme1: 16/0/0 default/read/poll queues
[    1.211080] nvme nvme0: 16/0/0 default/read/poll queues
[    1.216145] nvme nvme0: Ignoring bogus Namespace Identifiers
[    1.216261] nvme nvme1: Ignoring bogus Namespace Identifiers

Adding the NVME_QUIRK_IGNORE_DEV_SUBNQN quirk to resolves the issue.

Signed-off-by: Juraj Pecigos <kernel@juraj.dev>
---
 drivers/nvme/host/pci.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
index b615906263f3..282d808400c5 100644
--- a/drivers/nvme/host/pci.c
+++ b/drivers/nvme/host/pci.c
@@ -3441,7 +3441,8 @@ static const struct pci_device_id nvme_id_table[] = {
 	{ PCI_DEVICE(0x1d97, 0x1d97), /* Lexar NM620 */
 		.driver_data = NVME_QUIRK_BOGUS_NID, },
 	{ PCI_DEVICE(0x1d97, 0x2269), /* Lexar NM760 */
-		.driver_data = NVME_QUIRK_BOGUS_NID, },
+		.driver_data = NVME_QUIRK_BOGUS_NID |
+				NVME_QUIRK_IGNORE_DEV_SUBNQN, },
 	{ PCI_DEVICE(PCI_VENDOR_ID_AMAZON, 0x0061),
 		.driver_data = NVME_QUIRK_DMA_ADDRESS_BITS_48, },
 	{ PCI_DEVICE(PCI_VENDOR_ID_AMAZON, 0x0065),
-- 
2.40.0

Re: [PATCH] nvme-pci: mark Lexar NM760 as IGNORE_DEV_SUBNQN

Posted by Chaitanya Kulkarni 1 year ago

On 3/26/23 02:29, Juraj Pecigos wrote:
> A system with more than one of these SSDs will only have one usable.
> The kernel fails to detect more than one nvme device due to duplicate
> cntlids.
>
> before:
> [    9.395229] nvme 0000:01:00.0: platform quirk: setting simple suspend
> [    9.395262] nvme nvme0: pci function 0000:01:00.0
> [    9.395282] nvme 0000:03:00.0: platform quirk: setting simple suspend
> [    9.395305] nvme nvme1: pci function 0000:03:00.0
> [    9.409873] nvme nvme0: Duplicate cntlid 1 with nvme1, subsys nqn.2022-07.com.siliconmotion:nvm-subsystem-sn-                    , rejecting
> [    9.409982] nvme nvme0: Removing after probe failure status: -22
> [    9.427487] nvme nvme1: allocated 64 MiB host memory buffer.
> [    9.445088] nvme nvme1: 16/0/0 default/read/poll queues
> [    9.449898] nvme nvme1: Ignoring bogus Namespace Identifiers
>
> after:
> [    1.161890] nvme 0000:01:00.0: platform quirk: setting simple suspend
> [    1.162660] nvme nvme0: pci function 0000:01:00.0
> [    1.162684] nvme 0000:03:00.0: platform quirk: setting simple suspend
> [    1.162707] nvme nvme1: pci function 0000:03:00.0
> [    1.191354] nvme nvme0: allocated 64 MiB host memory buffer.
> [    1.193378] nvme nvme1: allocated 64 MiB host memory buffer.
> [    1.211044] nvme nvme1: 16/0/0 default/read/poll queues
> [    1.211080] nvme nvme0: 16/0/0 default/read/poll queues
> [    1.216145] nvme nvme0: Ignoring bogus Namespace Identifiers
> [    1.216261] nvme nvme1: Ignoring bogus Namespace Identifiers
>
> Adding the NVME_QUIRK_IGNORE_DEV_SUBNQN quirk to resolves the issue.
>
> Signed-off-by: Juraj Pecigos <kernel@juraj.dev>
> ---
>

Just looking at the log in the commit message seems like
this is solving your problem, looks good.

Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>

-ck