[PATCH 1/4] dt-bindings: Add doc for FriendlyARM NanoPi R2C

Tianling Shen posted 4 patches 2 years, 10 months ago
There is a newer version of this series
[PATCH 1/4] dt-bindings: Add doc for FriendlyARM NanoPi R2C
Posted by Tianling Shen 2 years, 10 months ago
Add devicetree binding documentation for the FriendlyARM NanoPi R2C.

Signed-off-by: Tianling Shen <cnsztl@gmail.com>
---
 Documentation/devicetree/bindings/arm/rockchip.yaml | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml
index 6f4270f2bd9e..01df9a5a0cf5 100644
--- a/Documentation/devicetree/bindings/arm/rockchip.yaml
+++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
@@ -185,9 +185,11 @@ properties:
           - const: firefly,rk3566-roc-pc
           - const: rockchip,rk3566
 
-      - description: FriendlyElec NanoPi R2S
+      - description: FriendlyElec NanoPi R2C/S
         items:
-          - const: friendlyarm,nanopi-r2s
+          - enum:
+              - friendlyarm,nanopi-r2c
+              - friendlyarm,nanopi-r2s
           - const: rockchip,rk3328
 
       - description: FriendlyElec NanoPi4 series boards
-- 
2.40.0
Re: [PATCH 1/4] dt-bindings: Add doc for FriendlyARM NanoPi R2C
Posted by Vincent Legoll 2 years, 10 months ago
Hello,

On Thu, Mar 23, 2023 at 1:38 PM Tianling Shen <cnsztl@gmail.com> wrote:
> -      - description: FriendlyElec NanoPi R2S
> +      - description: FriendlyElec NanoPi R2C/S

Maybe do like for the following one:

>        - description: FriendlyElec NanoPi4 series boards

- description: FriendlyElec NanoPi R2 series boards

Regards

-- 
Vincent Legoll
Re: [PATCH 1/4] dt-bindings: Add doc for FriendlyARM NanoPi R2C
Posted by Tianling Shen 2 years, 10 months ago
Hi Vincent,

On Thu, Mar 23, 2023 at 8:44 PM Vincent Legoll <vincent.legoll@gmail.com> wrote:
>
> Hello,
>
> On Thu, Mar 23, 2023 at 1:38 PM Tianling Shen <cnsztl@gmail.com> wrote:
> > -      - description: FriendlyElec NanoPi R2S
> > +      - description: FriendlyElec NanoPi R2C/S
>
> Maybe do like for the following one:
>
> >        - description: FriendlyElec NanoPi4 series boards
>
> - description: FriendlyElec NanoPi R2 series boards

Sounds good! I will apply your suggestion in v2.

Thanks,
Tianling.

>
> Regards
>
> --
> Vincent Legoll