fs/jbd2/journal.c | 6 ++---- include/linux/string.h | 2 +- lib/kobject.c | 3 +-- lib/string_helpers.c | 12 ++++++++---- 4 files changed, 12 insertions(+), 11 deletions(-)
It's more convenient to have strreplace() to return the pointer to the string itself. This will help users to make their code better. The patch 1 kills the only user of the returned value of strreplace(), Patch 2 converts the return value of strreplace(). And patch 3 shows how it may be useful. That said, the series can be routed via fs tree, with or without the last patch. In v2: - removed not anymore used variable (LKP) - added tag (Jan) - fixed wording (Kees) - actually return the pointer to the string itself Andy Shevchenko (3): jbd2: Avoid printing outside the boundary of the buffer lib/string_helpers: Change returned value of the strreplace() kobject: Use return value of strreplace() fs/jbd2/journal.c | 6 ++---- include/linux/string.h | 2 +- lib/kobject.c | 3 +-- lib/string_helpers.c | 12 ++++++++---- 4 files changed, 12 insertions(+), 11 deletions(-) -- 2.40.0.1.gaa8946217a0b
On Thu, Mar 23, 2023 at 02:37:01PM +0200, Andy Shevchenko wrote: > It's more convenient to have strreplace() to return the pointer to > the string itself. This will help users to make their code better. > > The patch 1 kills the only user of the returned value of strreplace(), > Patch 2 converts the return value of strreplace(). And patch 3 shows > how it may be useful. That said, the series can be routed via fs tree, > with or without the last patch. Since there are no comments, who can apply this (patches 1 and 2)? Greg, are you fine with the kobject change? > In v2: > - removed not anymore used variable (LKP) > - added tag (Jan) > - fixed wording (Kees) > - actually return the pointer to the string itself > > Andy Shevchenko (3): > jbd2: Avoid printing outside the boundary of the buffer > lib/string_helpers: Change returned value of the strreplace() > kobject: Use return value of strreplace() > > fs/jbd2/journal.c | 6 ++---- > include/linux/string.h | 2 +- > lib/kobject.c | 3 +-- > lib/string_helpers.c | 12 ++++++++---- > 4 files changed, 12 insertions(+), 11 deletions(-) -- With Best Regards, Andy Shevchenko
On Wed, Apr 05, 2023 at 04:34:31PM +0300, Andy Shevchenko wrote: > On Thu, Mar 23, 2023 at 02:37:01PM +0200, Andy Shevchenko wrote: > > It's more convenient to have strreplace() to return the pointer to > > the string itself. This will help users to make their code better. > > > > The patch 1 kills the only user of the returned value of strreplace(), > > Patch 2 converts the return value of strreplace(). And patch 3 shows > > how it may be useful. That said, the series can be routed via fs tree, > > with or without the last patch. > > Since there are no comments, who can apply this (patches 1 and 2)? > Greg, are you fine with the kobject change? Sure, want me to take them all through my driver-core tree? thanks, greg k-h
On Wed, Apr 05, 2023 at 04:24:42PM +0200, Greg Kroah-Hartman wrote: > On Wed, Apr 05, 2023 at 04:34:31PM +0300, Andy Shevchenko wrote: > > On Thu, Mar 23, 2023 at 02:37:01PM +0200, Andy Shevchenko wrote: > > > It's more convenient to have strreplace() to return the pointer to > > > the string itself. This will help users to make their code better. > > > > > > The patch 1 kills the only user of the returned value of strreplace(), > > > Patch 2 converts the return value of strreplace(). And patch 3 shows > > > how it may be useful. That said, the series can be routed via fs tree, > > > with or without the last patch. > > > > Since there are no comments, who can apply this (patches 1 and 2)? > > Greg, are you fine with the kobject change? > > Sure, want me to take them all through my driver-core tree? Fine by me! Dunno about others. Kees? -- With Best Regards, Andy Shevchenko
On April 5, 2023 7:38:40 AM PDT, Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote: >On Wed, Apr 05, 2023 at 04:24:42PM +0200, Greg Kroah-Hartman wrote: >> On Wed, Apr 05, 2023 at 04:34:31PM +0300, Andy Shevchenko wrote: >> > On Thu, Mar 23, 2023 at 02:37:01PM +0200, Andy Shevchenko wrote: >> > > It's more convenient to have strreplace() to return the pointer to >> > > the string itself. This will help users to make their code better. >> > > >> > > The patch 1 kills the only user of the returned value of strreplace(), >> > > Patch 2 converts the return value of strreplace(). And patch 3 shows >> > > how it may be useful. That said, the series can be routed via fs tree, >> > > with or without the last patch. >> > >> > Since there are no comments, who can apply this (patches 1 and 2)? >> > Greg, are you fine with the kobject change? >> >> Sure, want me to take them all through my driver-core tree? > >Fine by me! Dunno about others. Kees? Yeah, that's cool by me. :) -- Kees Cook
On Wed, Apr 05, 2023 at 07:58:40PM -0700, Kees Cook wrote: > On April 5, 2023 7:38:40 AM PDT, Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote: > >On Wed, Apr 05, 2023 at 04:24:42PM +0200, Greg Kroah-Hartman wrote: > >> On Wed, Apr 05, 2023 at 04:34:31PM +0300, Andy Shevchenko wrote: > >> > On Thu, Mar 23, 2023 at 02:37:01PM +0200, Andy Shevchenko wrote: > >> > > It's more convenient to have strreplace() to return the pointer to > >> > > the string itself. This will help users to make their code better. > >> > > > >> > > The patch 1 kills the only user of the returned value of strreplace(), > >> > > Patch 2 converts the return value of strreplace(). And patch 3 shows > >> > > how it may be useful. That said, the series can be routed via fs tree, > >> > > with or without the last patch. > >> > > >> > Since there are no comments, who can apply this (patches 1 and 2)? > >> > Greg, are you fine with the kobject change? > >> > >> Sure, want me to take them all through my driver-core tree? > > > >Fine by me! Dunno about others. Kees? > > Yeah, that's cool by me. :) Greg, does this slip through the cracks? -- With Best Regards, Andy Shevchenko
On Mon, Jun 05, 2023 at 05:04:43PM +0300, Andy Shevchenko wrote: > On Wed, Apr 05, 2023 at 07:58:40PM -0700, Kees Cook wrote: > > On April 5, 2023 7:38:40 AM PDT, Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote: > > >On Wed, Apr 05, 2023 at 04:24:42PM +0200, Greg Kroah-Hartman wrote: > > >> On Wed, Apr 05, 2023 at 04:34:31PM +0300, Andy Shevchenko wrote: > > >> > On Thu, Mar 23, 2023 at 02:37:01PM +0200, Andy Shevchenko wrote: > > >> > > It's more convenient to have strreplace() to return the pointer to > > >> > > the string itself. This will help users to make their code better. > > >> > > > > >> > > The patch 1 kills the only user of the returned value of strreplace(), > > >> > > Patch 2 converts the return value of strreplace(). And patch 3 shows > > >> > > how it may be useful. That said, the series can be routed via fs tree, > > >> > > with or without the last patch. > > >> > > > >> > Since there are no comments, who can apply this (patches 1 and 2)? > > >> > Greg, are you fine with the kobject change? > > >> > > >> Sure, want me to take them all through my driver-core tree? > > > > > >Fine by me! Dunno about others. Kees? > > > > Yeah, that's cool by me. :) > > Greg, does this slip through the cracks? It did. Can someone resend this? thanks, greg k-h
On Mon, Jun 05, 2023 at 06:57:48PM +0200, Greg Kroah-Hartman wrote: > On Mon, Jun 05, 2023 at 05:04:43PM +0300, Andy Shevchenko wrote: > > On Wed, Apr 05, 2023 at 07:58:40PM -0700, Kees Cook wrote: > > > On April 5, 2023 7:38:40 AM PDT, Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote: > > > >On Wed, Apr 05, 2023 at 04:24:42PM +0200, Greg Kroah-Hartman wrote: > > > >> On Wed, Apr 05, 2023 at 04:34:31PM +0300, Andy Shevchenko wrote: > > > >> > On Thu, Mar 23, 2023 at 02:37:01PM +0200, Andy Shevchenko wrote: > > > >> > > It's more convenient to have strreplace() to return the pointer to > > > >> > > the string itself. This will help users to make their code better. > > > >> > > > > > >> > > The patch 1 kills the only user of the returned value of strreplace(), > > > >> > > Patch 2 converts the return value of strreplace(). And patch 3 shows > > > >> > > how it may be useful. That said, the series can be routed via fs tree, > > > >> > > with or without the last patch. > > > >> > > > > >> > Since there are no comments, who can apply this (patches 1 and 2)? > > > >> > Greg, are you fine with the kobject change? > > > >> > > > >> Sure, want me to take them all through my driver-core tree? > > > > > > > >Fine by me! Dunno about others. Kees? > > > > > > Yeah, that's cool by me. :) > > > > Greg, does this slip through the cracks? > > It did. Can someone resend this? Done as v3. 20230605170553.7835-1-andriy.shevchenko@linux.intel.com -- With Best Regards, Andy Shevchenko
© 2016 - 2026 Red Hat, Inc.