[v1] usb: dwc3: host: remove dead code in dwc3_host_get_irq()

[PATCH] usb: dwc3: host: remove dead code in dwc3_host_get_irq()

Mingxuan Xiang posted 1 patch 2 years, 10 months ago

Diff against v2 v3
Download mbox

There is a newer version of this series

drivers/usb/dwc3/host.c | 3 ---
1 file changed, 3 deletions(-)

Expand all Fold all

[PATCH] usb: dwc3: host: remove dead code in dwc3_host_get_irq()

Posted by Mingxuan Xiang 2 years, 10 months ago

platform_get_irq() no longer returns 0, so there is no
need to check whether the return value is 0.

Signed-off-by: Mingxuan Xiang <mx_xiang@hust.edu.cn>
---
 drivers/usb/dwc3/host.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/usb/dwc3/host.c b/drivers/usb/dwc3/host.c
index f6f13e7f1ba1..aa19c27344e6 100644
--- a/drivers/usb/dwc3/host.c
+++ b/drivers/usb/dwc3/host.c
@@ -57,9 +57,6 @@ static int dwc3_host_get_irq(struct dwc3 *dwc)
 		goto out;
 	}
 
-	if (!irq)
-		irq = -EINVAL;
-
 out:
 	return irq;
 }
-- 
2.39.2

Re: [PATCH] usb: dwc3: host: remove dead code in dwc3_host_get_irq()

Posted by Sergei Shtylyov 2 years, 10 months ago

On 3/23/23 8:42 AM, Mingxuan Xiang wrote:

> platform_get_irq() no longer returns 0, so there is no
> need to check whether the return value is 0.
> 
> Signed-off-by: Mingxuan Xiang <mx_xiang@hust.edu.cn>
> ---
>  drivers/usb/dwc3/host.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/usb/dwc3/host.c b/drivers/usb/dwc3/host.c
> index f6f13e7f1ba1..aa19c27344e6 100644
> --- a/drivers/usb/dwc3/host.c
> +++ b/drivers/usb/dwc3/host.c
> @@ -57,9 +57,6 @@ static int dwc3_host_get_irq(struct dwc3 *dwc)
>  		goto out;

   Shouldn't *goto* be dropped now?

>  	}
>  
> -	if (!irq)
> -		irq = -EINVAL;
> -
>  out:
>  	return irq;
>  }

MBR, Sergey