rcu-tasks: Make pr_info() output more clearly in cblist_init_generic()

[PATCH] rcu-tasks: Make pr_info() output more clearly in cblist_init_generic()

Posted by Zqiang 2 years, 10 months ago

This commit use rtp->name instead of __func__, and output the value
of rcu_task_cb_adjust in pr_info(), reduced pr_info() calls.

Signed-off-by: Zqiang <qiang1.zhang@intel.com>
---
 kernel/rcu/tasks.h | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/kernel/rcu/tasks.h b/kernel/rcu/tasks.h
index 397309da3446..0cf958db4e44 100644
--- a/kernel/rcu/tasks.h
+++ b/kernel/rcu/tasks.h
@@ -270,10 +270,8 @@ static void cblist_init_generic(struct rcu_tasks *rtp)
 	}
 	raw_spin_unlock_irqrestore(&rtp->cbs_gbl_lock, flags);
 
-	if (rcu_task_cb_adjust)
-		pr_info("%s: Setting adjustable number of callback queues.\n", __func__);
-
-	pr_info("%s: Setting shift to %d and lim to %d.\n", __func__, data_race(rtp->percpu_enqueue_shift), data_race(rtp->percpu_enqueue_lim));
+	pr_info("%s: Setting shift to %d and lim to %d rcu_task_cb_adjust=%d.\n", rtp->name,
+			data_race(rtp->percpu_enqueue_shift), data_race(rtp->percpu_enqueue_lim), rcu_task_cb_adjust);
 }
 
 // IRQ-work handler that does deferred wakeup for call_rcu_tasks_generic().
-- 
2.25.1

Re: [PATCH] rcu-tasks: Make pr_info() output more clearly in cblist_init_generic()

Posted by Paul E. McKenney 2 years, 10 months ago

On Thu, Mar 23, 2023 at 12:00:11PM +0800, Zqiang wrote:
> This commit use rtp->name instead of __func__, and output the value
> of rcu_task_cb_adjust in pr_info(), reduced pr_info() calls.
> 
> Signed-off-by: Zqiang <qiang1.zhang@intel.com>

Queued, thank you!

							Thanx, Paul

> ---
>  kernel/rcu/tasks.h | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/kernel/rcu/tasks.h b/kernel/rcu/tasks.h
> index 397309da3446..0cf958db4e44 100644
> --- a/kernel/rcu/tasks.h
> +++ b/kernel/rcu/tasks.h
> @@ -270,10 +270,8 @@ static void cblist_init_generic(struct rcu_tasks *rtp)
>  	}
>  	raw_spin_unlock_irqrestore(&rtp->cbs_gbl_lock, flags);
>  
> -	if (rcu_task_cb_adjust)
> -		pr_info("%s: Setting adjustable number of callback queues.\n", __func__);
> -
> -	pr_info("%s: Setting shift to %d and lim to %d.\n", __func__, data_race(rtp->percpu_enqueue_shift), data_race(rtp->percpu_enqueue_lim));
> +	pr_info("%s: Setting shift to %d and lim to %d rcu_task_cb_adjust=%d.\n", rtp->name,
> +			data_race(rtp->percpu_enqueue_shift), data_race(rtp->percpu_enqueue_lim), rcu_task_cb_adjust);
>  }
>  
>  // IRQ-work handler that does deferred wakeup for call_rcu_tasks_generic().
> -- 
> 2.25.1
>